Go to file
Dr. Matthias St. Pierre 5b4cb385c1 RAND_add(): fix heap corruption in error path
This bug was introduced by #7382 which enhanced RAND_add() to
accept large buffer sizes. As a consequence, RAND_add() now fails
for buffer sizes less than 32 bytes (i.e. less than 256 bits).
In addition, rand_drbg_get_entropy() forgets to reset the attached
drbg->pool in the case of an error, which leads to the heap corruption.

The problem occurred with RAND_load_file(), which reads the file in
chunks of 1024 bytes each. If the size of the final chunk is less than
32 bytes, then RAND_add() fails, whence RAND_load_file() fails
silently for buffer sizes n = k * 1024 + r with r = 1,...,31.

This commit fixes the heap corruption only. The other issues will
be addressed in a separate pull request.

Thanks to Gisle Vanem for reporting this issue.

Fixes #7449

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7455)
2018-10-22 14:54:55 +02:00
.github
apps Don't complain and fail about unknown TLSv1.3 PSK identities in s_server 2018-10-19 15:19:15 +01:00
boringssl@2070f8ad91
Configurations build file templates: have targets for all shared library names 2018-10-21 15:47:06 +02:00
crypto RAND_add(): fix heap corruption in error path 2018-10-22 14:54:55 +02:00
demos Add a GMAC demonstration program. 2018-09-19 11:38:43 +10:00
doc s390x assembly pack: add OPENSSL_s390xcap man page. 2018-10-17 14:03:59 +02:00
engines Change the build of engines to use ordinal files for symbol export 2018-10-05 08:22:42 +02:00
external/perl Update copyright year 2018-09-11 13:45:17 +01:00
fuzz print() is a function in Python 3 2018-10-17 07:31:25 +02:00
include Deprecate ECDH_KDF_X9_62() 2018-10-17 13:22:14 +03:00
krb5@b9ad6c4950
ms
os-dep
pyca-cryptography@09403100de Update the pyca-cryptography submodule 2018-09-10 12:04:03 +01:00
ssl Buffer a ClientHello with a cookie received via DTLSv1_listen 2018-10-19 14:25:22 +01:00
test Test DTLS cookie generation and verification 2018-10-19 14:12:51 +01:00
tools
util s390x assembly pack: add OPENSSL_s390xcap man page. 2018-10-17 14:03:59 +02:00
VMS
.gitattributes
.gitignore Ignore libcrypto.ld and libssl.ld 2018-10-03 16:40:18 +01:00
.gitmodules
.travis-apt-pin.preferences
.travis-create-release.sh
.travis.yml Revert ".travis.yml: omit linux-ppc64le target." 2018-08-31 10:56:35 +02:00
ACKNOWLEDGEMENTS
appveyor.yml CI config: no need to make both install and install_docs 2018-05-14 17:51:48 +02:00
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
build.info Refactor util/mkdef.pl for clearer separation of functionality 2018-10-03 22:16:10 +02:00
CHANGES Deprecate ECDH_KDF_X9_62() 2018-10-17 13:22:14 +03:00
config Configure: move --noexecstack probe to Configure. 2018-05-05 20:44:56 +02:00
config.com
Configure Configure: use correct variable to infer the .ld file location 2018-10-05 08:22:42 +02:00
CONTRIBUTING Add a note on CHANGES and NEWS in CONTRIBUTING 2018-05-17 13:51:11 +02:00
e_os.h test/secmemtest: test secure memory only if it is implemented 2018-10-05 12:19:48 +02:00
FAQ
INSTALL typo-fixes: miscellaneous typo fixes 2018-09-21 23:55:22 +02:00
LICENSE
NEWS The next version in master is at least 1.1.2, not 1.1.1x 2018-09-11 16:51:38 +02:00
NOTES.ANDROID Configurations/15-android.conf: add support for "standalone toolchain". 2018-10-19 10:35:36 +02:00
NOTES.DJGPP
NOTES.PERL
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VMS
NOTES.WIN INSTALL,NOTES.WIN: classify no-asm as non-production option. 2018-07-25 15:47:12 +02:00
README The next version in master is at least 1.1.2, not 1.1.1x 2018-09-11 16:51:38 +02:00
README.ENGINE
README.FIPS

 OpenSSL 1.1.2-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.