openssl/crypto/x509
Gunnar Kudrjavets 4c9b0a0314 Initialize potentially uninitialized local variables
Compiling OpenSSL code with MSVC and /W4 results in a number of warnings.
One category of warnings is particularly interesting - C4701 (potentially
uninitialized local variable 'name' used). This warning pretty much means
that there's a code path which results in uninitialized variables being used
or returned. Depending on compiler, its options, OS, values in registers
and/or stack, the results can be nondeterministic. Cases like this are very
hard to debug so it's rational to fix these issues.

This patch contains a set of trivial fixes for all the C4701 warnings (just
initializing variables to 0 or NULL or appropriate error code) to make sure
that deterministic values will be returned from all the execution paths.

RT#3835

Signed-off-by: Matt Caswell <matt@openssl.org>

Matt's note: All of these appear to be bogus warnings, i.e. there isn't
actually a code path where an unitialised variable could be used - its just
that the compiler hasn't been able to figure that out from the logic. So
this commit is just about silencing spurious warnings.

Reviewed-by: Rich Salz <rsalz@openssl.org>
2015-05-06 13:06:46 +01:00
..
by_dir.c Use safer sizeof variant in malloc 2015-05-04 15:00:13 -04:00
by_file.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
Makefile Remove EXHEADER, TEST, APPS, links:, install: and uninstall: where relevant 2015-03-31 20:16:01 +02:00
x509_att.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
x509_cmp.c free NULL cleanup 2015-03-28 10:54:15 -04:00
x509_d2.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x509_def.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x509_err.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x509_ext.c Remove obsolete IMPLEMENT_ASN1_SET_OF 2015-02-09 12:47:28 +00:00
x509_lcl.h make X509_VERIFY_PARAM opaque 2015-05-02 14:15:00 +01:00
x509_lu.c Use safer sizeof variant in malloc 2015-05-04 15:00:13 -04:00
x509_obj.c free NULL cleanup -- coda 2015-05-01 14:37:16 -04:00
x509_r2x.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
x509_req.c remove malloc casts 2015-04-28 15:28:14 -04:00
x509_set.c Remove old ASN.1 code. 2015-03-23 13:15:06 +00:00
x509_trs.c Use safer sizeof variant in malloc 2015-05-04 15:00:13 -04:00
x509_txt.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x509_v3.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
x509_vfy.c Initialize potentially uninitialized local variables 2015-05-06 13:06:46 +01:00
x509_vpm.c Use safer sizeof variant in malloc 2015-05-04 15:00:13 -04:00
x509cset.c Remove old ASN.1 code. 2015-03-23 13:15:06 +00:00
x509name.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
x509rset.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x509spki.c free null cleanup finale 2015-05-01 10:02:07 -04:00
x509type.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_all.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
x_attrib.c free NULL cleanup 5a 2015-04-30 17:33:59 -04:00
x_exten.c make X509_EXTENSION opaque 2015-03-23 18:27:04 +00:00
x_name.c Use safer sizeof variant in malloc 2015-05-04 15:00:13 -04:00