openssl/ssl
Matt Caswell 47e81a1bfa Pass an EVP_PKEY for SSL_SECOP_TMP_DH in the security callback
The security operation SSL_SECOP_TMP_DH is defined to take an EVP_PKEY
in the "other" parameter:

 /* Temporary DH key */
 # define SSL_SECOP_TMP_DH                (7 | SSL_SECOP_OTHER_PKEY)

In most places this is what is passed. All these places occur server side.
However there is one client side call of this security operation and it
passes a DH object instead. This is incorrect according to the
definition of SSL_SECOP_TMP_DH, and is inconsistent with all of the other
locations.

Our own default security callback, and the debug callback in the apps,
never look at this value and therefore this issue was never noticed
previously. In theory a client side application could be relying on this
behaviour and could be broken by this change. This is probably fairly
unlikely but can't be ruled out.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from https://github.com/openssl/openssl/pull/13136)
2020-10-16 14:58:44 +01:00
..
record Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
statem Pass an EVP_PKEY for SSL_SECOP_TMP_DH in the security callback 2020-10-16 14:58:44 +01:00
bio_ssl.c Update copyright year 2020-05-15 14:09:49 +01:00
build.info Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
d1_lib.c Reorganize local header files 2019-09-28 20:26:35 +02:00
d1_msg.c Reorganize local header files 2019-09-28 20:26:35 +02:00
d1_srtp.c Fix safestack issues in ssl.h 2020-09-13 11:09:45 +01:00
ktls.c Move KTLS inline functions only used by libssl into ssl/ktls.c. 2020-08-31 09:34:19 +01:00
methods.c Update some inclusions of <openssl/macros.h> 2019-11-07 11:37:25 +01:00
pqueue.c Reorganize local header files 2019-09-28 20:26:35 +02:00
s3_cbc.c TLS fixes for CBC mode and no-deprecated 2020-09-09 17:59:08 +10:00
s3_enc.c Improve some error messages if a digest is not available 2020-08-29 17:56:20 +10:00
s3_lib.c [ssl] Support ssl_encapsulate on server side 2020-10-14 18:42:59 +03:00
s3_msg.c Reorganize local header files 2019-09-28 20:26:35 +02:00
ssl_asn1.c Explicitly test against NULL; do not use !p or similar 2019-10-09 21:32:15 +02:00
ssl_cert_table.h
ssl_cert.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
ssl_ciph.c Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
ssl_conf.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
ssl_err.c Improve some error messages if a digest is not available 2020-08-29 17:56:20 +10:00
ssl_init.c Providerized libssl fallout: cleanup init 2020-07-11 15:13:09 -07:00
ssl_lib.c Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
ssl_local.h Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
ssl_mcnf.c Rename OPENSSL_CTX prefix to OSSL_LIB_CTX 2020-10-15 11:59:53 +01:00
ssl_rsa.c Run the withlibctx.pl script 2020-10-01 09:25:20 +01:00
ssl_sess.c Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
ssl_stat.c Reorganize local header files 2019-09-28 20:26:35 +02:00
ssl_txt.c Update copyright year 2020-04-23 13:55:52 +01:00
ssl_utst.c Reorganize local header files 2019-09-28 20:26:35 +02:00
t1_enc.c TLS AEAD ciphers: more bytes for key_block than needed 2020-10-02 08:49:47 +02:00
t1_lib.c Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
t1_trce.c t1_trce: Fix remaining places where the 24 bit shift overflow happens 2020-05-20 17:31:56 +02:00
tls13_enc.c Support for KTLS TX on FreeBSD for TLS 1.3. 2020-08-31 09:34:19 +01:00
tls_depr.c Concentrate deprecated libssl API usage in one file 2020-10-16 14:47:21 +01:00
tls_srp.c Update copyright year 2020-04-23 13:55:52 +01:00