openssl/ssl/record
Matt Caswell 2f90f85cc0 Remove an unnecessary setup of the read buffer
Now everything has been moved to the record layer the additional check
for setting up the read buffer is not needed and can be removed.

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18132)
2022-08-18 16:38:13 +01:00
..
methods Remove an unnecessary setup of the read buffer 2022-08-18 16:38:13 +01:00
build.info Move some DTLS read code into the read record layer 2022-08-18 16:38:13 +01:00
dtls1_bitmap.c SSL object refactoring using SSL_CONNECTION object 2022-07-28 10:04:28 +01:00
README.md
rec_layer_d1.c Clear away some unused fields and cruft in the record layer 2022-08-18 16:38:13 +01:00
rec_layer_s3.c Clear away some unused fields and cruft in the record layer 2022-08-18 16:38:13 +01:00
record_local.h Clear away some unused fields and cruft in the record layer 2022-08-18 16:38:13 +01:00
record.h Clear away some unused fields and cruft in the record layer 2022-08-18 16:38:13 +01:00
recordmethod.h Remove some TODO(RECLAYER) comments 2022-08-18 16:38:13 +01:00
ssl3_buffer.c Remove some unnecessary function pointers from OSSL_RECORD_METHOD 2022-08-18 16:38:13 +01:00
ssl3_record_tls13.c Check that IV length is not less than zero 2022-08-01 08:14:23 +01:00
ssl3_record.c Resolve a TODO(RECLAYER) in the SSLv3 code 2022-08-18 16:38:13 +01:00
tls_pad.c Fix leakage when the cacheline is 32-bytes in CBC_MAC_ROTATE_IN_PLACE 2022-05-09 16:40:21 +02:00

Record Layer Design

This file provides some guidance on the thinking behind the design of the record layer code to aid future maintenance.

The record layer is divided into a number of components. At the time of writing there are four: SSL3_RECORD, SSL3_BUFFER, DLTS1_BITMAP and RECORD_LAYER. Each of these components is defined by:

  1. A struct definition of the same name as the component
  2. A set of source files that define the functions for that component
  3. A set of accessor macros

All struct definitions are in record.h. The functions and macros are either defined in record.h or record_local.h dependent on whether they are intended to be private to the record layer, or whether they form part of the API to the rest of libssl.

The source files map to components as follows:

dtls1_bitmap.c                 -> DTLS1_BITMAP component
ssl3_buffer.c                  -> SSL3_BUFFER component
ssl3_record.c                  -> SSL3_RECORD component
rec_layer_s3.c, rec_layer_d1.c -> RECORD_LAYER component

The RECORD_LAYER component is a facade pattern, i.e. it provides a simplified interface to the record layer for the rest of libssl. The other 3 components are entirely private to the record layer and therefore should never be accessed directly by libssl.

Any component can directly access its own members - they are private to that component, e.g. ssl3_buffer.c can access members of the SSL3_BUFFER struct without using a macro. No component can directly access the members of another component, e.g. ssl3_buffer cannot reach inside the RECORD_LAYER component to directly access its members. Instead components use accessor macros, so if code in ssl3_buffer.c wants to access the members of the RECORD_LAYER it uses the RECORD_LAYER_* macros.

Conceptually it looks like this:

                      libssl
                         |
-------------------------|-----record.h------------------------------------
                         |
                  _______V______________
                 |                      |
                 |    RECORD_LAYER      |
                 |                      |
                 |    rec_layer_s3.c    |
                 |          ^           |
                 | _________|__________ |
                 ||                    ||
                 || DTLS1_RECORD_LAYER ||
                 ||                    ||
                 || rec_layer_d1.c     ||
                 ||____________________||
                 |______________________|
      record_local.h     ^   ^   ^
       _________________|   |   |_________________
      |                     |                     |
 _____V_________      ______V________      _______V________
|               |    |               |    |                |
| SSL3_BUFFER   |    | SSL3_RECORD   |    | DTLS1_BITMAP   |
|               |--->|               |    |                |
| ssl3_buffer.c |    | ssl3_record.c |    | dtls1_bitmap.c |
|_______________|    |_______________|    |________________|

The two RECORD_LAYER source files build on each other, i.e. the main one is rec_layer_s3.c which provides the core SSL/TLS layer. The second one is rec_layer_d1.c which builds off of the SSL/TLS code to provide DTLS specific capabilities. It uses some DTLS specific RECORD_LAYER component members which should only be accessed from rec_layer_d1.c. These are held in the DTLS1_RECORD_LAYER struct.