mirror of
https://github.com/openssl/openssl.git
synced 2024-12-21 06:09:35 +08:00
7932982b88
Now handle [http[s]://][userinfo@]host[:port][/path][?query][#frag] by optionally providing any userinfo, query, and frag components. All usages of this function, which are client-only, silently ignore userinfo and frag components, while the query component is taken as part of the path. Update and extend the unit tests and all affected documentation. Document and deprecat OCSP_parse_url(). Fixes an issue that came up when discussing FR #14001. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from https://github.com/openssl/openssl/pull/14009)
281 lines
8.3 KiB
C
281 lines
8.3 KiB
C
/*
|
|
* Copyright 2020-2021 The OpenSSL Project Authors. All Rights Reserved.
|
|
* Copyright Siemens AG 2020
|
|
*
|
|
* Licensed under the Apache License 2.0 (the "License"). You may not use
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
* in the file LICENSE in the source distribution or at
|
|
* https://www.openssl.org/source/license.html
|
|
*/
|
|
|
|
#include <openssl/http.h>
|
|
#include <openssl/pem.h>
|
|
#include <openssl/x509v3.h>
|
|
#include <string.h>
|
|
|
|
#include "testutil.h"
|
|
|
|
static const ASN1_ITEM *x509_it = NULL;
|
|
static X509 *x509 = NULL;
|
|
#define SERVER "mock.server"
|
|
#define PORT "81"
|
|
#define RPATH "path/any.crt"
|
|
static const char *rpath;
|
|
|
|
/*
|
|
* pretty trivial HTTP mock server:
|
|
* for POST, copy request headers+body from mem BIO 'in' as response to 'out'
|
|
* for GET, first redirect the request then respond with 'rsp' of ASN1 type 'it'
|
|
*/
|
|
static int mock_http_server(BIO *in, BIO *out,
|
|
ASN1_VALUE *rsp, const ASN1_ITEM *it)
|
|
{
|
|
const char *req;
|
|
long count = BIO_get_mem_data(in, (unsigned char **)&req);
|
|
const char *hdr = (char *)req;
|
|
int is_get = count >= 4 && strncmp(hdr, "GET ", 4) == 0;
|
|
int len;
|
|
|
|
/* first line should contain "<GET or POST> <rpath> HTTP/1.x" */
|
|
if (is_get)
|
|
hdr += 4;
|
|
else if (TEST_true(count >= 5 && strncmp(hdr, "POST ", 5) == 0))
|
|
hdr += 5;
|
|
else
|
|
return 0;
|
|
|
|
while (*rpath == '/')
|
|
rpath++;
|
|
while (*hdr == '/')
|
|
hdr++;
|
|
len = strlen(rpath);
|
|
if (!TEST_strn_eq(hdr, rpath, len) || !TEST_char_eq(hdr++[len], ' '))
|
|
return 0;
|
|
hdr += len;
|
|
len = strlen("HTTP/1.");
|
|
if (!TEST_strn_eq(hdr, "HTTP/1.", len))
|
|
return 0;
|
|
hdr += len;
|
|
/* check for HTTP version 1.0 .. 1.1 */
|
|
if (!TEST_char_le('0', *hdr) || !TEST_char_le(*hdr++, '1'))
|
|
return 0;
|
|
if (!TEST_char_eq(*hdr++, '\r') || !TEST_char_eq(*hdr++, '\n'))
|
|
return 0;
|
|
count -= (hdr - req);
|
|
if (count <= 0 || out == NULL)
|
|
return 0;
|
|
|
|
if (is_get && strcmp(rpath, RPATH) == 0) {
|
|
rpath = "path/new.crt";
|
|
return BIO_printf(out, "HTTP/1.1 301 Moved Permanently\r\n"
|
|
"Location: /%s\r\n\r\n", rpath) > 0; /* same server */
|
|
}
|
|
if (BIO_printf(out, "HTTP/1.1 200 OK\r\n") <= 0)
|
|
return 0;
|
|
if (is_get) { /* construct new header and body */
|
|
if ((len = ASN1_item_i2d(rsp, NULL, it)) <= 0)
|
|
return 0;
|
|
if (BIO_printf(out, "Content-Type: application/x-x509-ca-cert\r\n"
|
|
"Content-Length: %d\r\n\r\n", len) <= 0)
|
|
return 0;
|
|
return ASN1_item_i2d_bio(it, out, rsp);
|
|
} else {
|
|
return BIO_write(out, hdr, count) == count; /* echo header and body */
|
|
}
|
|
}
|
|
|
|
static long http_bio_cb_ex(BIO *bio, int oper, const char *argp, size_t len,
|
|
int cmd, long argl, int ret, size_t *processed)
|
|
{
|
|
|
|
if (oper == (BIO_CB_CTRL | BIO_CB_RETURN) && cmd == BIO_CTRL_FLUSH)
|
|
ret = mock_http_server(bio, (BIO *)BIO_get_callback_arg(bio),
|
|
(ASN1_VALUE *)x509, x509_it);
|
|
return ret;
|
|
}
|
|
|
|
static int test_http_x509(int do_get)
|
|
{
|
|
X509 *rcert = NULL;
|
|
BIO *wbio = BIO_new(BIO_s_mem());
|
|
BIO *rbio = BIO_new(BIO_s_mem());
|
|
STACK_OF(CONF_VALUE) *headers = NULL;
|
|
int res = 0;
|
|
|
|
if (wbio == NULL || rbio == NULL)
|
|
goto err;
|
|
BIO_set_callback_ex(wbio, http_bio_cb_ex);
|
|
BIO_set_callback_arg(wbio, (char *)rbio);
|
|
|
|
rpath = RPATH;
|
|
rcert = (X509 *)
|
|
(do_get ?
|
|
OSSL_HTTP_get_asn1("http://"SERVER":"PORT"/"RPATH,
|
|
NULL /* proxy */, NULL /* no_proxy */,
|
|
wbio, rbio, NULL /* bio_update_fn */, NULL,
|
|
headers, 0 /* maxline */,
|
|
0 /* max_resp_len */, 0 /* timeout */,
|
|
"application/x-x509-ca-cert", x509_it)
|
|
:
|
|
OSSL_HTTP_post_asn1(SERVER, PORT, RPATH, 0 /* use_ssl */,
|
|
NULL /* proxy */, NULL /* no_proxy */,
|
|
wbio, rbio, NULL /* bio_update_fn */, NULL,
|
|
headers, "application/x-x509-ca-cert",
|
|
(ASN1_VALUE *)x509, x509_it, 0 /* maxline */,
|
|
0 /* max_resp_len */, 0 /* timeout */,
|
|
"application/x-x509-ca-cert", x509_it)
|
|
);
|
|
res = TEST_ptr(rcert) && TEST_int_eq(X509_cmp(x509, rcert), 0);
|
|
|
|
err:
|
|
X509_free(rcert);
|
|
BIO_free(wbio);
|
|
BIO_free(rbio);
|
|
sk_CONF_VALUE_pop_free(headers, X509V3_conf_free);
|
|
return res;
|
|
}
|
|
|
|
static int test_http_url_ok(const char *url, int exp_ssl, const char *exp_host,
|
|
const char *exp_port, const char *exp_path)
|
|
{
|
|
char *user, *host, *port, *path, *query, *frag;
|
|
int exp_num, num, ssl;
|
|
int res;
|
|
|
|
TEST_int_eq(sscanf(exp_port, "%d", &exp_num), 1);
|
|
res = TEST_true(OSSL_HTTP_parse_url(url, &ssl, &user, &host, &port, &num,
|
|
&path, &query, &frag))
|
|
&& TEST_str_eq(host, exp_host)
|
|
&& TEST_str_eq(port, exp_port)
|
|
&& TEST_int_eq(num, exp_num)
|
|
&& TEST_str_eq(path, exp_path)
|
|
&& TEST_int_eq(ssl, exp_ssl);
|
|
if (res && *user != '\0')
|
|
res = TEST_str_eq(user, "user:pass");
|
|
if (res && *frag != '\0')
|
|
res = TEST_str_eq(frag, "fr");
|
|
if (res && *query != '\0')
|
|
res = TEST_str_eq(query, "q");
|
|
OPENSSL_free(user);
|
|
OPENSSL_free(host);
|
|
OPENSSL_free(port);
|
|
OPENSSL_free(path);
|
|
OPENSSL_free(query);
|
|
OPENSSL_free(frag);
|
|
return res;
|
|
}
|
|
|
|
static int test_http_url_path_query_ok(const char *url, const char *exp_path_qu)
|
|
{
|
|
char *host, *path;
|
|
int res;
|
|
|
|
res = TEST_true(OSSL_HTTP_parse_url(url, NULL, NULL, &host, NULL, NULL,
|
|
&path, NULL, NULL))
|
|
&& TEST_str_eq(host, "host")
|
|
&& TEST_str_eq(path, exp_path_qu);
|
|
OPENSSL_free(host);
|
|
OPENSSL_free(path);
|
|
return res;
|
|
}
|
|
|
|
static int test_http_url_dns(void)
|
|
{
|
|
return test_http_url_ok("host:65535/path", 0, "host", "65535", "/path");
|
|
}
|
|
|
|
static int test_http_url_path_query(void)
|
|
{
|
|
return test_http_url_path_query_ok("http://usr@host:1/p?q=x#frag", "/p?q=x")
|
|
&& test_http_url_path_query_ok("http://host?query#frag", "/?query")
|
|
&& test_http_url_path_query_ok("http://host:9999#frag", "/");
|
|
}
|
|
|
|
static int test_http_url_userinfo_query_fragment(void)
|
|
{
|
|
return test_http_url_ok("user:pass@host/p?q#fr", 0, "host", "80", "/p");
|
|
}
|
|
|
|
static int test_http_url_ipv4(void)
|
|
{
|
|
return test_http_url_ok("https://1.2.3.4/p/q", 1, "1.2.3.4", "443", "/p/q");
|
|
}
|
|
|
|
static int test_http_url_ipv6(void)
|
|
{
|
|
return test_http_url_ok("http://[FF01::101]:6", 0, "FF01::101", "6", "/");
|
|
}
|
|
|
|
static int test_http_url_invalid(const char *url)
|
|
{
|
|
char *host = "1", *port = "1", *path = "1";
|
|
int num = 1, ssl = 1;
|
|
int res;
|
|
|
|
res = TEST_false(OSSL_HTTP_parse_url(url, &ssl, NULL, &host, &port, &num,
|
|
&path, NULL, NULL))
|
|
&& TEST_ptr_null(host)
|
|
&& TEST_ptr_null(port)
|
|
&& TEST_ptr_null(path);
|
|
if (!res) {
|
|
OPENSSL_free(host);
|
|
OPENSSL_free(port);
|
|
OPENSSL_free(path);
|
|
}
|
|
return res;
|
|
}
|
|
|
|
static int test_http_url_invalid_prefix(void)
|
|
{
|
|
return test_http_url_invalid("htttps://1.2.3.4:65535/pkix");
|
|
}
|
|
|
|
static int test_http_url_invalid_port(void)
|
|
{
|
|
return test_http_url_invalid("https://1.2.3.4:65536/pkix");
|
|
}
|
|
|
|
static int test_http_url_invalid_path(void)
|
|
{
|
|
return test_http_url_invalid("https://[FF01::101]pkix");
|
|
}
|
|
|
|
static int test_http_get_x509(void)
|
|
{
|
|
return test_http_x509(1);
|
|
}
|
|
|
|
static int test_http_post_x509(void)
|
|
{
|
|
return test_http_x509(0);
|
|
}
|
|
|
|
void cleanup_tests(void)
|
|
{
|
|
X509_free(x509);
|
|
}
|
|
|
|
int setup_tests(void)
|
|
{
|
|
if (!test_skip_common_options()) {
|
|
TEST_error("Error parsing test options\n");
|
|
return 0;
|
|
}
|
|
|
|
x509_it = ASN1_ITEM_rptr(X509);
|
|
if (!TEST_ptr((x509 = load_cert_pem(test_get_argument(0), NULL))))
|
|
return 1;
|
|
|
|
ADD_TEST(test_http_url_dns);
|
|
ADD_TEST(test_http_url_path_query);
|
|
ADD_TEST(test_http_url_userinfo_query_fragment);
|
|
ADD_TEST(test_http_url_ipv4);
|
|
ADD_TEST(test_http_url_ipv6);
|
|
ADD_TEST(test_http_url_invalid_prefix);
|
|
ADD_TEST(test_http_url_invalid_port);
|
|
ADD_TEST(test_http_url_invalid_path);
|
|
ADD_TEST(test_http_get_x509);
|
|
ADD_TEST(test_http_post_x509);
|
|
return 1;
|
|
}
|