mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2024-11-21 01:15:20 +08:00
Code Issues Packages Projects Releases Wiki Activity
22f0c72b92
openssl/crypto
History
Nicola Tuveri 67cc2bae02 [SM2_sign] fix double free and return value 
Currently, critical bugs prevent using SM2 signatures through the
`EVP_PKEY` interface: any application that managed to satisfy the
requirement of forcing SM3 as the message digest – even if this is
currently not possible transparently through the `EVP_PKEY` interface
and requires manually forcing the MD selection – would crash with a
segmentation fault upon calling the `SM2_sign()` function.

This is easily verified using the OpenSSL CLI to execute this critical
code path under the right conditions:
`openssl dgst -sm3 -hex -sign sm2.eckey /path/to/file/to/sign`

The issue is caused by a double free at the end of `SM2_sign()` in
`crypto/sm2/sm2_sign.c` in case of successful signature generation.
In addition, even if the double free was not causing segfaults,
the function returns the wrong return value in case of success (it
would return 0 rather than 1).

This patch fixes both problems.

Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6066)
2018-04-25 10:24:43 +01:00
..
aes Update copyright year 2018-03-20 13:08:46 +00:00
aria
asn1 a_strex.c: improve documentation of 'tag2nbyte' lookup table 2018-04-24 08:06:11 +02:00
async Update copyright year 2018-04-17 15:18:40 +02:00
bf
bio Ensure the thread keys are always allocated in the same order 2018-04-20 15:45:06 +02:00
blake2
bn Remove superfluous NULL checks. Add Andy's BN_FLG comment. 2018-04-23 19:14:25 +01:00
buffer Update copyright year 2018-04-03 13:57:12 +01:00
camellia
cast
chacha
cmac Update copyright year 2018-04-17 15:18:40 +02:00
cms Update copyright year 2018-04-17 15:18:40 +02:00
comp Update copyright year 2018-04-03 13:57:12 +01:00
conf Update copyright year 2018-04-17 15:18:40 +02:00
ct
des Update copyright year 2018-04-03 13:57:12 +01:00
dh Update copyright year 2018-04-17 15:18:40 +02:00
dsa Update copyright year 2018-04-17 15:18:40 +02:00
dso openssl#5668: corrections after compiling with -qinfo=all:als. 2018-04-14 13:28:31 +02:00
ec Remove superfluous NULL checks. Add Andy's BN_FLG comment. 2018-04-23 19:14:25 +01:00
engine Ensure the thread keys are always allocated in the same order 2018-04-20 15:45:06 +02:00
err Add missing malloc-return-null instance 2018-04-24 12:41:45 -04:00
evp Update copyright year 2018-04-17 15:18:40 +02:00
hmac Update copyright year 2018-04-17 15:18:40 +02:00
idea
include/internal Ensure the thread keys are always allocated in the same order 2018-04-20 15:45:06 +02:00
kdf Update copyright year 2018-04-17 15:18:40 +02:00
lhash
md2
md4
md5
mdc2
modes ARM assembly pack: make it work with older assembler. 2018-04-23 17:29:59 +02:00
objects Update copyright year 2018-04-17 15:18:40 +02:00
ocsp
pem Clear buffer in PEM_write_bio 2018-04-19 15:47:43 +02:00
perlasm
pkcs7 Update copyright year 2018-03-20 13:08:46 +00:00
pkcs12
poly1305 poly1305/asm/poly1305-armv4.pl: remove unintentional relocation. 2018-04-18 19:47:53 +02:00
rand Fix usage of ossl_assert() 2018-04-23 18:45:53 +02:00
rc2
rc4 Update copyright year 2018-03-20 13:08:46 +00:00
rc5
ripemd
rsa Update copyright year 2018-04-17 15:18:40 +02:00
seed
sha 00-base-templates.conf: wire keccak1600-armv4 module. 2018-04-23 17:27:58 +02:00
siphash Update copyright year 2018-04-17 15:18:40 +02:00
sm2 [SM2_sign] fix double free and return value 2018-04-25 10:24:43 +01:00
sm3
sm4
srp Fix a memory leak in an error path 2018-04-17 17:26:16 +01:00
stack Update copyright year 2018-04-17 15:18:40 +02:00
store
ts o_time.c: use gmtime_s with MSVC 2018-03-27 20:12:34 +02:00
txt_db Update copyright year 2018-04-03 13:57:12 +01:00
ui Update copyright year 2018-04-17 15:18:40 +02:00
whrlpool
x509 Add missing malloc-return-null instance 2018-04-24 12:41:45 -04:00
x509v3 X509: add more error codes on malloc or sk_TYP_push failure 2018-04-24 09:08:33 +02:00
alphacpuid.pl
arm64cpuid.pl
arm_arch.h Fix building linux-armv4 with --strict-warnings 2018-04-20 15:49:33 +02:00
armcap.c
armv4cpuid.pl ARM assembly pack: make it work with older assembler. 2018-04-23 17:29:59 +02:00
build.info Remove import/use of File::Spec::Function 2018-04-01 22:41:04 +02:00
c64xpluscpuid.pl
cpt_err.c Set error code if alloc returns NULL 2018-04-05 15:13:55 -04:00
cryptlib.c Enabled OneCore Conf for Console Apps (removed nonUniversal API) 2018-04-03 18:39:22 +02:00
ctype.c
cversion.c
dllmain.c
ebcdic.c
ex_data.c Ensure the thread keys are always allocated in the same order 2018-04-20 15:45:06 +02:00
ia64cpuid.S
init.c Ensure the thread keys are always allocated in the same order 2018-04-20 15:45:06 +02:00
LPdir_nyi.c
LPdir_unix.c
LPdir_vms.c
LPdir_win32.c
LPdir_win.c
LPdir_wince.c
mem_clr.c
mem_dbg.c
mem_sec.c
mem.c
mips_arch.h
o_dir.c
o_fips.c
o_fopen.c Set error code on alloc failures 2018-04-03 11:31:16 -04:00
o_init.c
o_str.c
o_time.c Update copyright year 2018-04-03 13:57:12 +01:00
pariscid.pl Update copyright year 2018-04-03 13:57:12 +01:00
ppc_arch.h
ppccap.c
ppccpuid.pl
s390x_arch.h s390x assembly pack: add KMF code path for aes-cfb/cfb8 2018-03-28 23:31:01 +02:00
s390xcap.c
s390xcpuid.pl s390x assembly pack: add KMF code path for aes-cfb/cfb8 2018-03-28 23:31:01 +02:00
sparc_arch.h
sparccpuid.S
sparcv9cap.c
threads_none.c Update copyright year 2018-04-17 15:18:40 +02:00
threads_pthread.c Update copyright year 2018-04-17 15:18:40 +02:00
threads_win.c Update copyright year 2018-04-17 15:18:40 +02:00
uid.c
vms_rms.h
x86_64cpuid.pl
x86cpuid.pl