openssl/crypto/rand
Matt Caswell 302d38e3f7 Deprecate RAND_pseudo_bytes
The justification for RAND_pseudo_bytes is somewhat dubious, and the reality
is that it is frequently being misused. RAND_bytes and RAND_pseudo_bytes in
the default implementation both end up calling ssleay_rand_bytes. Both may
return -1 in an error condition. If there is insufficient entropy then
both will return 0, but RAND_bytes will additionally add an error to the
error queue. They both return 1 on success.
Therefore the fundamental difference between the two is that one will add an
error to the error queue with insufficient entory whilst the other will not.
Frequently there are constructions of this form:

if(RAND_pseudo_bytes(...) <= 1)
	goto err;

In the above form insufficient entropy is treated as an error anyway, so
RAND_bytes is probably the better form to use.

This form is also seen:
if(!RAND_pseudo_bytes(...))
	goto err;

This is technically not correct at all since a -1 return value is
incorrectly handled - but this form will also treat insufficient entropy as
an error.

Within libssl it is required that you have correctly seeded your entropy
pool and so there seems little benefit in using RAND_pseudo_bytes.
Similarly in libcrypto many operations also require a correctly seeded
entropy pool and so in most interesting cases you would be better off
using RAND_bytes anyway. There is a significant risk of RAND_pseudo_bytes
being incorrectly used in scenarios where security can be compromised by
insufficient entropy.

If you are not using the default implementation, then most engines use the
same function to implement RAND_bytes and RAND_pseudo_bytes in any case.

Given its misuse, limited benefit, and potential to compromise security,
RAND_pseudo_bytes has been deprecated.

Reviewed-by: Richard Levitte <levitte@openssl.org>
2015-03-25 12:38:19 +00:00
..
Makefile Remove fipscanister build functionality from makefiles. 2014-12-08 13:23:45 +00:00
md_rand.c Deprecate RAND_pseudo_bytes 2015-03-25 12:38:19 +00:00
rand_egd.c RT3684: rand_egd needs stddef.h 2015-02-12 12:50:09 -05:00
rand_err.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
rand_lcl.h OPENSSL_NO_xxx cleanup: SHA 2015-01-27 12:34:45 -05:00
rand_lib.c Deprecate RAND_pseudo_bytes 2015-03-25 12:38:19 +00:00
rand_nw.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
rand_os2.c Unchecked malloc fixes 2015-03-05 09:09:57 +00:00
rand_unix.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
rand_vms.c Run util/openssl-format-source -v -c . 2015-01-22 09:20:09 +00:00
rand_win.c Live code cleanup: remove #if 1 stuff 2015-02-06 10:54:20 -05:00
rand.h Deprecate RAND_pseudo_bytes 2015-03-25 12:38:19 +00:00
randfile.c ifdef cleanup part 3: OPENSSL_SYSNAME 2015-01-23 11:58:26 -05:00
randtest.c RAND_bytes updates 2015-03-25 12:38:07 +00:00