mirror of
https://github.com/openssl/openssl.git
synced 2024-12-03 05:41:46 +08:00
e077455e9e
Since OPENSSL_malloc() and friends report ERR_R_MALLOC_FAILURE, and
at least handle the file name and line number they are called from,
there's no need to report ERR_R_MALLOC_FAILURE where they are called
directly, or when SSLfatal() and RLAYERfatal() is used, the reason
`ERR_R_MALLOC_FAILURE` is changed to `ERR_R_CRYPTO_LIB`.
There were a number of places where `ERR_R_MALLOC_FAILURE` was reported
even though it was a function from a different sub-system that was
called. Those places are changed to report ERR_R_{lib}_LIB, where
{lib} is the name of that sub-system.
Some of them are tricky to get right, as we have a lot of functions
that belong in the ASN1 sub-system, and all the `sk_` calls or from
the CRYPTO sub-system.
Some extra adaptation was necessary where there were custom OPENSSL_malloc()
wrappers, and some bugs are fixed alongside these changes.
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19301)
119 lines
3.0 KiB
C
119 lines
3.0 KiB
C
/*
|
|
* Copyright 2002-2021 The OpenSSL Project Authors. All Rights Reserved.
|
|
*
|
|
* Licensed under the Apache License 2.0 (the "License"). You may not use
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
* in the file LICENSE in the source distribution or at
|
|
* https://www.openssl.org/source/license.html
|
|
*/
|
|
|
|
/*
|
|
* ECDSA low level APIs are deprecated for public use, but still ok for
|
|
* internal use.
|
|
*/
|
|
#include "internal/deprecated.h"
|
|
|
|
#include "ec_local.h"
|
|
#include <openssl/err.h>
|
|
|
|
int EC_GROUP_check_named_curve(const EC_GROUP *group, int nist_only,
|
|
BN_CTX *ctx)
|
|
{
|
|
int nid;
|
|
BN_CTX *new_ctx = NULL;
|
|
|
|
if (group == NULL) {
|
|
ERR_raise(ERR_LIB_EC, ERR_R_PASSED_NULL_PARAMETER);
|
|
return NID_undef;
|
|
}
|
|
|
|
if (ctx == NULL) {
|
|
ctx = new_ctx = BN_CTX_new_ex(NULL);
|
|
if (ctx == NULL) {
|
|
ERR_raise(ERR_LIB_EC, ERR_R_BN_LIB);
|
|
return NID_undef;
|
|
}
|
|
}
|
|
|
|
nid = ossl_ec_curve_nid_from_params(group, ctx);
|
|
if (nid > 0 && nist_only && EC_curve_nid2nist(nid) == NULL)
|
|
nid = NID_undef;
|
|
|
|
BN_CTX_free(new_ctx);
|
|
return nid;
|
|
}
|
|
|
|
int EC_GROUP_check(const EC_GROUP *group, BN_CTX *ctx)
|
|
{
|
|
#ifdef FIPS_MODULE
|
|
/*
|
|
* ECC domain parameter validation.
|
|
* See SP800-56A R3 5.5.2 "Assurances of Domain-Parameter Validity" Part 1b.
|
|
*/
|
|
return EC_GROUP_check_named_curve(group, 1, ctx) >= 0 ? 1 : 0;
|
|
#else
|
|
int ret = 0;
|
|
const BIGNUM *order;
|
|
BN_CTX *new_ctx = NULL;
|
|
EC_POINT *point = NULL;
|
|
|
|
if (group == NULL || group->meth == NULL) {
|
|
ERR_raise(ERR_LIB_EC, ERR_R_PASSED_NULL_PARAMETER);
|
|
return 0;
|
|
}
|
|
|
|
/* Custom curves assumed to be correct */
|
|
if ((group->meth->flags & EC_FLAGS_CUSTOM_CURVE) != 0)
|
|
return 1;
|
|
|
|
if (ctx == NULL) {
|
|
ctx = new_ctx = BN_CTX_new();
|
|
if (ctx == NULL) {
|
|
ERR_raise(ERR_LIB_EC, ERR_R_BN_LIB);
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
/* check the discriminant */
|
|
if (!EC_GROUP_check_discriminant(group, ctx)) {
|
|
ERR_raise(ERR_LIB_EC, EC_R_DISCRIMINANT_IS_ZERO);
|
|
goto err;
|
|
}
|
|
|
|
/* check the generator */
|
|
if (group->generator == NULL) {
|
|
ERR_raise(ERR_LIB_EC, EC_R_UNDEFINED_GENERATOR);
|
|
goto err;
|
|
}
|
|
if (EC_POINT_is_on_curve(group, group->generator, ctx) <= 0) {
|
|
ERR_raise(ERR_LIB_EC, EC_R_POINT_IS_NOT_ON_CURVE);
|
|
goto err;
|
|
}
|
|
|
|
/* check the order of the generator */
|
|
if ((point = EC_POINT_new(group)) == NULL)
|
|
goto err;
|
|
order = EC_GROUP_get0_order(group);
|
|
if (order == NULL)
|
|
goto err;
|
|
if (BN_is_zero(order)) {
|
|
ERR_raise(ERR_LIB_EC, EC_R_UNDEFINED_ORDER);
|
|
goto err;
|
|
}
|
|
|
|
if (!EC_POINT_mul(group, point, order, NULL, NULL, ctx))
|
|
goto err;
|
|
if (!EC_POINT_is_at_infinity(group, point)) {
|
|
ERR_raise(ERR_LIB_EC, EC_R_INVALID_GROUP_ORDER);
|
|
goto err;
|
|
}
|
|
|
|
ret = 1;
|
|
|
|
err:
|
|
BN_CTX_free(new_ctx);
|
|
EC_POINT_free(point);
|
|
return ret;
|
|
#endif /* FIPS_MODULE */
|
|
}
|