openssl/crypto/ec/asm
Nicola Tuveri 00da0f6989 [crypto/ec] Remove unreachable AVX2 code in NISTZ256 implementation
`crypto/ec/ecp_nistz256.c` contained code sections guarded by a
`ECP_NISTZ256_AVX2` define.

The relevant comment read:

> /*
>  * Note that by default ECP_NISTZ256_AVX2 is undefined. While it's great
>  * code processing 4 points in parallel, corresponding serial operation
>  * is several times slower, because it uses 29x29=58-bit multiplication
>  * as opposite to 64x64=128-bit in integer-only scalar case. As result
>  * it doesn't provide *significant* performance improvement. Note that
>  * just defining ECP_NISTZ256_AVX2 is not sufficient to make it work,
>  * you'd need to compile even asm/ecp_nistz256-avx.pl module.
>  */

Without diminishing the quality of the original submission, it's evident
that this code has been basically unreachable without modifications to
the library source code and is under-tested.

This commit removes these sections from the codebase.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/12019)
2020-06-04 18:35:28 +03:00
..
ecp_nistz256-armv4.pl Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256-armv8.pl Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256-ppc64.pl Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256-sparcv9.pl Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256-x86_64.pl Update copyright year 2020-04-23 13:55:52 +01:00
ecp_nistz256-x86.pl Update copyright year 2020-04-23 13:55:52 +01:00
x25519-ppc64.pl Update copyright year 2020-04-23 13:55:52 +01:00
x25519-x86_64.pl Update copyright year 2020-04-23 13:55:52 +01:00