Go to file
Dr. Matthias St. Pierre 0fda9f7c29 trace: don't pretend success if it's not enabled
Partially reverts d33d76168f Don't fail when tracing is disabled

Commit d33d76168f fixed the problem that the initialization of
libcrypto failed when tracing was disabled, because the unoperational
ossl_trace_init() function returned a failure code. The problem was
fixed by changing its return value from failure to success.

As part of the fix the return values of other unimplemented trace API
functions (like OSSL_trace_set_channel(),OSSL_trace_set_callback())
was changed from failure to success, too. This change was not necessary
and is a bit problematic IMHO, because nobody expects an unimplemented
function to pretend it succeeded.

It's the application's duty to handle the case correctly when the trace
API is not enabled (i.e., OPENSSL_NO_TRACE is defined), not the API's job
to pretend success just to prevent the application from failing.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8552)
2019-03-29 23:59:06 +01:00
.github
apps trace: don't pretend success if it's not enabled 2019-03-29 23:59:06 +01:00
boringssl@2070f8ad91
Configurations Windows, VMS: build fixes 2019-03-29 12:52:58 +01:00
crypto trace: don't pretend success if it's not enabled 2019-03-29 23:59:06 +01:00
demos Fix memory leaks in pkread.c demo file 2019-03-13 09:54:49 +00:00
doc Remove heartbeats completely 2019-03-29 13:50:59 +01:00
engines Ensure that the struct msghdr is properly zeroed. 2019-03-29 20:52:00 +10:00
external/perl
fuzz Support SM2 certificate verification 2019-03-13 15:29:39 +08:00
include Remove heartbeats completely 2019-03-29 13:50:59 +01:00
krb5@b9ad6c4950
ms Windows: Call TerminateProcess, not ExitProcess 2019-02-22 21:03:45 +01:00
os-dep
providers Implement SHA256 in the default provider 2019-03-21 09:23:38 +00:00
pyca-cryptography@09403100de
ssl Remove heartbeats completely 2019-03-29 13:50:59 +01:00
test Correctly initialise PACKET to zero in the tests to avoid possible problems 2019-03-29 20:52:01 +10:00
tools
util Implement EVP_MD_fetch() 2019-03-21 09:23:38 +00:00
VMS
.gitattributes
.gitignore
.gitmodules
.travis-apt-pin.preferences
.travis-create-release.sh
.travis.yml Update to xenial 2019-03-16 15:53:39 +01:00
ACKNOWLEDGEMENTS
appveyor.yml
AUTHORS
build.info Add a skeleton default provider 2019-03-21 09:23:38 +00:00
CHANGES Remove heartbeats completely 2019-03-29 13:50:59 +01:00
config Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
config.com
Configure Remove heartbeats completely 2019-03-29 13:50:59 +01:00
CONTRIBUTING Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
e_os.h Limit DEVRANDOM_WAIT to linux 2019-03-07 22:36:31 +01:00
FAQ
INSTALL Configure: disable new trace api by default 2019-03-14 10:32:58 +01:00
LICENSE
NEWS Remove heartbeats completely 2019-03-29 13:50:59 +01:00
NOTES.ANDROID Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.DJGPP Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.PERL
NOTES.UNIX
NOTES.VMS Remove unnecessary trailing whitespace 2019-02-05 16:25:11 +01:00
NOTES.WIN
README
README.ENGINE
README.FIPS

 OpenSSL 3.0.0-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.

 The OpenSSL toolkit is licensed under the Apache License 2.0, which means
 that you are free to get and use it for commercial and non-commercial
 purposes as long as you fulfill its conditions.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.