openssl/crypto/dsa
Nicola Tuveri 0c5d725ebf Fix segfault in RSA_free() (and DSA/DH/EC_KEY)
`RSA_free()` and friends are called in case of error from
`RSA_new_method(ENGINE *e)` (or the respective equivalent functions).

For the rest of the description I'll talk about `RSA_*`, but the same
applies for the equivalent `DSA_free()`, `DH_free()`, `EC_KEY_free()`.

If `RSA_new_method()` fails because the engine does not implement the
required method, when `RSA_free(RSA *r)` is called,
`r->meth == NULL` and a segfault happens while checking if
`r->meth->finish` is defined.

This commit fixes this issue by ensuring that `r->meth` is not NULL
before dereferencing it to check for `r->meth->finish`.

Fixes #7102 .

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7121)
2018-09-05 15:22:35 +03:00
..
build.info
dsa_ameth.c
dsa_asn1.c
dsa_depr.c
dsa_err.c
dsa_gen.c
dsa_key.c
dsa_lib.c Fix segfault in RSA_free() (and DSA/DH/EC_KEY) 2018-09-05 15:22:35 +03:00
dsa_locl.h
dsa_meth.c
dsa_ossl.c Add blinding to a DSA signature 2018-06-21 10:15:57 +01:00
dsa_pmeth.c Remove DSA digest length checks when no digest is passed 2018-07-29 21:26:29 +02:00
dsa_prn.c
dsa_sign.c Use DEPRECATEDIN_1_2_0 macro for DSA_sign_setup declaration 2018-06-21 11:01:32 +01:00
dsa_vrf.c