mirror of
https://github.com/openssl/openssl.git
synced 2024-11-27 05:21:51 +08:00
65e2d67254
SSL_set_rbio() and SSL_set_wbio() are new functions in 1.1.0 and really should be called SSL_set0_rbio() and SSL_set0_wbio(). The old implementation was not consistent with what "set0" means though as there were special cases around what happens if the rbio and wbio are the same. We were only ever taking one reference on the BIO, and checking everywhere whether the rbio and wbio are the same so as not to double free. A better approach is to rename the functions to SSL_set0_rbio() and SSL_set0_wbio(). If an existing BIO is present it is *always* freed regardless of whether the rbio and wbio are the same or not. It is therefore the callers responsibility to ensure that a reference is taken for *each* usage, i.e. one for the rbio and one for the wbio. The legacy function SSL_set_bio() takes both the rbio and wbio in one go and sets them both. We can wrap up the old behaviour in the implementation of that function, i.e. previously if the rbio and wbio are the same in the call to this function then the caller only needed to ensure one reference was passed. This behaviour is retained by internally upping the ref count. This commit was inspired by BoringSSL commit f715c423224. RT#4572 Reviewed-by: Rich Salz <rsalz@openssl.org> |
||
|---|---|---|
| .. | ||
| perl/OpenSSL/Util | ||
| TLSProxy | ||
| ck_errf.pl | ||
| copy.pl | ||
| dofile.pl | ||
| find-doc-nits.pl | ||
| find-undoc-api.pl | ||
| find-unused-errs | ||
| fipslink.pl | ||
| incore | ||
| indent.pro | ||
| libcrypto.num | ||
| libssl.num | ||
| mkbuildinf.pl | ||
| mkcerts.sh | ||
| mkdef.pl | ||
| mkdir-p.pl | ||
| mkerr.pl | ||
| mkrc.pl | ||
| openssl-format-source | ||
| opensslwrap.sh | ||
| point.sh | ||
| process_docs.pl | ||
| selftest.pl | ||
| shlib_wrap.sh | ||
| su-filter.pl | ||
| with_fallback.pm | ||