6 Commits

Author	SHA1	Message	Date
Matt Caswell	08029dfa03	Convert WPACKET_put_bytes to use convenience macros ... All the other functions that take an argument for the number of bytes use convenience macros for this purpose. We should do the same with WPACKET_put_bytes(). Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-20 14:47:44 +01:00
Matt Caswell	869d0a37cf	Encourage use of the macros for the various "sub" functions ... Don't call WPACKET_sub_memcpy(), WPACKET_sub_allocation_bytes() and WPACKET_start_sub_packet_len() directly. Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-14 00:02:34 +01:00
Matt Caswell	c9216d1485	Make wpackettest conform to style rules ... Remove extra indentation at the start of an "if". Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-14 00:02:34 +01:00
Matt Caswell	b2b3024e0e	Add a WPACKET_sub_allocate_bytes() function ... Updated the construction code to use the new function. Also added some convenience macros for WPACKET_sub_memcpy(). Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-14 00:02:34 +01:00
Matt Caswell	de451856f0	Address WPACKET review comments ... A few style tweaks here and there. The main change is that curr and packet_len are now offsets into the buffer to account for the fact that the pointers can change if the buffer grows. Also dropped support for the WPACKET_set_packet_len() function. I thought that was going to be needed but so far it hasn't been. It doesn't really work any more due to the offsets change. Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-13 09:41:21 +01:00
Matt Caswell	d6c4cc2939	Add tests for the WPACKET implementation ... The tests will only work in no-shared builds because WPACKET is an internal only API that does not get exported by the shared library. Reviewed-by: Rich Salz <rsalz@openssl.org>	2016-09-13 09:41:21 +01:00