mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-17 14:32:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

CRYPTO_mem_debug_push() and CRYPTO_mem_debug_pop() should return 0

Browse Source 
Those 2 functions historically only ever returned 0 or 1. In OpenSSL 3.0
they were made no-ops and the documentation says they always return 0. In
fact they were returning -1. If any application was actually using these
functions then it may appear that they were actually successful (e.g. -1
could be interpreted as "true").

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18967)
This commit is contained in:
Matt Caswell 2022-08-09 11:59:22 +01:00 committed by Tomas Mraz
parent 2c35d61790
commit f868454257
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/mem.c
View File

@ -285,12 +285,12 @@ int CRYPTO_set_mem_debug(int flag)
int CRYPTO_mem_debug_push(const char *info, const char *file, int line)
{
(void)info; (void)file; (void)line;
return -1;
return 0;
}
int CRYPTO_mem_debug_pop(void)
{
return -1;
return 0;
}
void CRYPTO_mem_debug_malloc(void *addr, size_t num, int flag,