mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-01-18 13:44:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent NULL dereference in async clear-fd code

Browse Source 
If the list of fds contains only (one or more) entries marked
as deleted prior to the entry currently being deleted, and the
entry currently being deleted was only just added, the 'prev'
pointer would never be updated from its initial NULL value, and
we would dereference NULL while trying to remove the entry from
the linked list.

Reported by Coverity.

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
(Merged from https://github.com/openssl/openssl/pull/4602)
This commit is contained in:
Benjamin Kaduk 2017-10-27 09:54:14 -05:00 committed by Ben Kaduk
parent 85155346b3
commit f403feea11
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crypto/async/async_wait.c
View File

@ -145,6 +145,7 @@ int ASYNC_WAIT_CTX_clear_fd(ASYNC_WAIT_CTX *ctx, const void *key)
while (curr != NULL) { while (curr != NULL) {
if (curr->del == 1) { if (curr->del == 1) {
/* This one has been marked deleted already so do nothing */ /* This one has been marked deleted already so do nothing */
prev = curr;
curr = curr->next; curr = curr->next;
continue; continue;
} }