mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-01-18 13:44:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Coverity issues 1596850, 1596851 and 1596852

Browse Source 
These are newly introduced memory leaks and UAF in evp_test.c

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24339)
This commit is contained in:
Tomas Mraz 2024-05-06 20:13:52 +02:00 committed by Pauli
parent 57bb112c07
commit deaa83af70
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/evp_test.c
View File

@ -411,10 +411,10 @@ static int parse_bin_chunk(const char *value, size_t offset, size_t max,
return -1;
if (!TEST_ptr(*buf = OPENSSL_hexstr2buf(chunk, &len))) {
OPENSSL_free(chunk);
TEST_info("Can't convert chunk %s", chunk);
TEST_openssl_errors();
return -1;
}
OPENSSL_free(chunk);
*buflen = len;
}
*out_offset = value[0] == '"' ? offset + (*buflen) : offset + 2 * (*buflen);
@ -742,6 +742,8 @@ static int cipher_test_init(EVP_TEST *t, const char *alg)
if (data_chunk_size != 0 && !cipher_test_valid_fragmentation(cdat)) {
ERR_pop_to_mark();
EVP_CIPHER_free(fetched_cipher);
OPENSSL_free(cdat);
t->skip = 1;
TEST_info("skipping, '%s' does not support fragmentation", alg);
return 1;