mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2024-11-27 05:21:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

apps: fix coverity 1474463, 1474465 & 1474467: resource leaks

Browse Source 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14716)
This commit is contained in:
Pauli 2021-03-29 12:37:43 +10:00 committed by Tomas Mraz
parent 92b3e62fdd
commit d1a57d873b
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/speed.c
View File

@ -3603,8 +3603,8 @@ static void multiblock_speed(const EVP_CIPHER *evp_cipher, int lengths_single,
const int *mblengths = mblengths_list; const int *mblengths = mblengths_list;
int j, count, keylen, num = OSSL_NELEM(mblengths_list); int j, count, keylen, num = OSSL_NELEM(mblengths_list);
const char *alg_name; const char *alg_name;
unsigned char *inp, *out, *key, no_key[32], no_iv[16]; unsigned char *inp = NULL, *out = NULL, *key, no_key[32], no_iv[16];
EVP_CIPHER_CTX *ctx; EVP_CIPHER_CTX *ctx = NULL;
double d = 0.0; double d = 0.0;
if (lengths_single) { if (lengths_single) {
@ -3621,7 +3621,7 @@ static void multiblock_speed(const EVP_CIPHER *evp_cipher, int lengths_single,
if ((keylen = EVP_CIPHER_CTX_key_length(ctx)) < 0) { if ((keylen = EVP_CIPHER_CTX_key_length(ctx)) < 0) {
BIO_printf(bio_err, "Impossible negative key length: %d\n", keylen); BIO_printf(bio_err, "Impossible negative key length: %d\n", keylen);
return; goto err;
} }
key = app_malloc(keylen, "evp_cipher key"); key = app_malloc(keylen, "evp_cipher key");
if (!EVP_CIPHER_CTX_rand_key(ctx, key)) if (!EVP_CIPHER_CTX_rand_key(ctx, key))
@ -3710,6 +3710,7 @@ static void multiblock_speed(const EVP_CIPHER *evp_cipher, int lengths_single,
fprintf(stdout, "\n"); fprintf(stdout, "\n");
} }
err:
OPENSSL_free(inp); OPENSSL_free(inp);
OPENSSL_free(out); OPENSSL_free(out);
EVP_CIPHER_CTX_free(ctx); EVP_CIPHER_CTX_free(ctx);