mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-23 14:42:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not ignore EVP_PKEY_print_public/EVP_PKEY_print_private return values

Browse Source 
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/7007)
This commit is contained in:
Dmitry Belyavskiy 2018-08-18 19:43:23 +03:00 committed by Nicola Tuveri
parent 324b956052
commit c87af534e6
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
apps/pkey.c
View File

@ -186,23 +186,29 @@ int pkey_main(int argc, char **argv)
if (!noout) { if (!noout) {
if (outformat == FORMAT_PEM) { if (outformat == FORMAT_PEM) {
if (pubout) { if (pubout) {
PEM_write_bio_PUBKEY(out, pkey); if (!PEM_write_bio_PUBKEY(out, pkey))
goto end;
} else { } else {
assert(private); assert(private);
if (traditional) if (traditional) {
PEM_write_bio_PrivateKey_traditional(out, pkey, cipher, if (!PEM_write_bio_PrivateKey_traditional(out, pkey, cipher,
NULL, 0, NULL, NULL, 0, NULL,
passout); passout))
else goto end;
PEM_write_bio_PrivateKey(out, pkey, cipher, } else {
NULL, 0, NULL, passout); if (!PEM_write_bio_PrivateKey(out, pkey, cipher,
NULL, 0, NULL, passout))
goto end;
}
} }
} else if (outformat == FORMAT_ASN1) { } else if (outformat == FORMAT_ASN1) {
if (pubout) { if (pubout) {
i2d_PUBKEY_bio(out, pkey); if (!i2d_PUBKEY_bio(out, pkey))
goto end;
} else { } else {
assert(private); assert(private);
i2d_PrivateKey_bio(out, pkey); if (!i2d_PrivateKey_bio(out, pkey))
goto end;
} }
} else { } else {
BIO_printf(bio_err, "Bad format specified for key\n"); BIO_printf(bio_err, "Bad format specified for key\n");
@ -212,10 +218,12 @@ int pkey_main(int argc, char **argv)
if (text) { if (text) {
if (pubtext) { if (pubtext) {
EVP_PKEY_print_public(out, pkey, 0, NULL); if (EVP_PKEY_print_public(out, pkey, 0, NULL) <= 0)
goto end;
} else { } else {
assert(private); assert(private);
EVP_PKEY_print_private(out, pkey, 0, NULL); if (EVP_PKEY_print_private(out, pkey, 0, NULL) <= 0)
goto end;
} }
} }