From c407d5e568ee0755d0c96c09a832af9760349c00 Mon Sep 17 00:00:00 2001 From: Hugo Landau Date: Tue, 6 Jun 2023 16:25:10 +0100 Subject: [PATCH] QUIC: Note that we do not retransmit stream data for retransmitted streams Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/21135) --- ssl/quic/quic_fifd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ssl/quic/quic_fifd.c b/ssl/quic/quic_fifd.c index 8eca7520df..e5ebc14adc 100644 --- a/ssl/quic/quic_fifd.c +++ b/ssl/quic/quic_fifd.c @@ -124,6 +124,12 @@ static void on_lost(void *arg) sstream_updated = 0; if (chunks[i].end >= chunks[i].start) { + /* + * Note: If the stream is being reset, we do not need to retransmit + * old data as this is pointless. In this case this will be handled + * by (sstream == NULL) above as the QSM will free the QUIC_SSTREAM + * and our call to get_sstream_by_id above will return NULL. + */ ossl_quic_sstream_mark_lost(sstream, chunks[i].start, chunks[i].end); sstream_updated = 1;