mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-17 14:32:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix EC_KEY_set_private_key() priv_key regression

Browse Source 
This allows to set EC_KEY's private key to NULL and fixes regression
issue following OTC guideline in
https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696

Fixes #18744.

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/18942)
This commit is contained in:
Roberto Hueso Gomez 2022-07-26 20:41:02 +02:00 committed by Nicola Tuveri
parent 0a90577e71
commit b304b3e8f7
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crypto/ec/ec_key.c
View File

@ -720,6 +720,16 @@ int EC_KEY_set_private_key(EC_KEY *key, const BIGNUM *priv_key)
&& key->meth->set_private(key, priv_key) == 0)
return 0;
/*
* Return `0` to comply with legacy behavior for this function, see
* https://github.com/openssl/openssl/issues/18744#issuecomment-1195175696
*/
if (priv_key == NULL) {
BN_clear_free(key->priv_key);
key->priv_key = NULL;
return 0; /* intentional for legacy compatibility */
}
/*
* We should never leak the bit length of the secret scalar in the key,
* so we always set the `BN_FLG_CONSTTIME` flag on the internal `BIGNUM`