diff --git a/doc/man3/EVP_PKEY_set1_RSA.pod b/doc/man3/EVP_PKEY_set1_RSA.pod index c0366d34fc..f2bdede46f 100644 --- a/doc/man3/EVP_PKEY_set1_RSA.pod +++ b/doc/man3/EVP_PKEY_set1_RSA.pod @@ -62,13 +62,16 @@ see L: EVP_PKEY_get_base_id() returns the type of I. For example an RSA key will return B. -EVP_PKEY_get_id() returns the actual OID associated with I. -Historically keys using the same algorithm could use different OIDs. -For example an RSA key could use the OIDs corresponding to +EVP_PKEY_get_id() returns the actual NID associated with I +only if the I type isn't implemented just in a L. +Historically keys using the same algorithm could use different NIDs. +For example an RSA key could use the NIDs corresponding to the NIDs B (equivalent to B) or B (equivalent to B). The use of -alternative non-standard OIDs is now rare so B et al are not +alternative non-standard NIDs is now rare so B et al are not often seen in practice. +EVP_PKEY_get_id() returns -1 (B) if the I is +only implemented in a L. EVP_PKEY_type() returns the underlying type of the NID I. For example EVP_PKEY_type(EVP_PKEY_RSA2) will return B. @@ -142,6 +145,9 @@ EVP_PKEY_get_id(), EVP_PKEY_get_base_id(), EVP_PKEY_type() For EVP_PKEY key type checking purposes, L is more generic. +For purposes of retrieving the name of the B the function +L is more generally useful. + The keys returned from the functions EVP_PKEY_get0_RSA(), EVP_PKEY_get0_DSA(), EVP_PKEY_get0_DH() and EVP_PKEY_get0_EC_KEY() were changed to have a "const" return type in OpenSSL 3.0. As described above the keys returned may be cached diff --git a/doc/man7/migration_guide.pod b/doc/man7/migration_guide.pod index bad1eab873..5294f57225 100644 --- a/doc/man7/migration_guide.pod +++ b/doc/man7/migration_guide.pod @@ -2242,6 +2242,28 @@ Use L and L instead. =back +=head3 NID handling for provided keys and algorithms + +The following functions for NID (numeric id) handling have changed semantics. + +=over 4 + +=item * + +EVP_PKEY_id(), EVP_PKEY_get_id() + +This function was previously used to reliably return the NID of +an EVP_PKEY object, e.g., to look up the name of the algorithm of +such EVP_PKEY by calling L. With the introduction +of Ls EVP_PKEY_id() or its new equivalent +L might now also return the value -1 +(B) indicating the use of a provider to +implement the EVP_PKEY object. Therefore, the use of +L is recommended for retrieving +the name of the EVP_PKEY algorithm. + +=back + =head2 Using the FIPS Module in applications See L and L for details. diff --git a/ssl/t1_lib.c b/ssl/t1_lib.c index 7ec8be4c27..e528467dd9 100644 --- a/ssl/t1_lib.c +++ b/ssl/t1_lib.c @@ -1855,7 +1855,7 @@ int tls12_check_peer_sigalg(SSL_CONNECTION *s, uint16_t sig, EVP_PKEY *pkey) } lu = tls1_lookup_sigalg(s, sig); /* if this sigalg is loaded, set so far unknown pkeyid to its sig NID */ - if ((pkeyid == -1) && (lu != NULL)) + if ((pkeyid == EVP_PKEY_KEYMGMT) && (lu != NULL)) pkeyid = lu->sig; /* Should never happen */