mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-17 14:32:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix endianness problem in params_api_test

Browse Source 
On a big endian machine, we get test failures in params_api_test like

        # ERROR: (memory) 'buf1 == buf2' failed @ test/params_api_test.c:473
        # --- buf1
        # +++ buf2
        # 0000:-e901
        # 0000:+01e9
        #       ^^^^
        #
        # OPENSSL_TEST_RAND_ORDER=1643313367
        not ok 157 - iteration 3

They are due to an additional conversion copy.  Remove this copy to solve the
problem.

Signed-off-by: Juergen Christ <jchrist@linux.ibm.com>

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17608)
This commit is contained in:
Juergen Christ 2022-01-28 10:53:43 +01:00 committed by Pauli
parent e180bf641e
commit 9927749ec2
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/params_api_test.c
View File

@ -428,14 +428,15 @@ static int test_param_bignum(int n)
int ret = 0;
param.data = bnbuf;
param.data_size = len;
param.data_size = sizeof(bnbuf);
le_copy(buf, len, raw_values[n].value, len);
if (!TEST_ptr(b = BN_lebin2bn(raw_values[n].value, (int)len, NULL)))
goto err;
if (!TEST_true(OSSL_PARAM_set_BN(&param, b))
|| !TEST_mem_eq(bnbuf, param.return_size, buf, param.return_size))
if (!TEST_true(OSSL_PARAM_set_BN(&param, b)))
goto err;
le_copy(buf, len, bnbuf, sizeof(bnbuf));
if (!TEST_mem_eq(raw_values[n].value, len, buf, len))
goto err;
param.data_size = param.return_size;
if (!TEST_true(OSSL_PARAM_get_BN(&param, &c))
@ -451,7 +452,7 @@ err:
static int test_param_signed_bignum(int n)
{
unsigned char buf1[MAX_LEN], buf2[MAX_LEN], bnbuf[MAX_LEN];
unsigned char buf[MAX_LEN], bnbuf[MAX_LEN];
const size_t len = raw_values[n].len;
BIGNUM *b = NULL, *c = NULL;
OSSL_PARAM param = OSSL_PARAM_DEFN("bn", OSSL_PARAM_INTEGER, NULL, 0);
@ -460,7 +461,6 @@ static int test_param_signed_bignum(int n)
param.data = bnbuf;
param.data_size = sizeof(bnbuf);
le_copy(buf1, len, raw_values[n].value, len);
if (!TEST_ptr(b = BN_signed_lebin2bn(raw_values[n].value, (int)len, NULL)))
goto err;
@ -469,8 +469,8 @@ static int test_param_signed_bignum(int n)
goto err;
if (!TEST_true(OSSL_PARAM_set_BN(&param, b)))
goto err;
le_copy(buf2, len, bnbuf, sizeof(bnbuf));
if (!TEST_mem_eq(buf1, len, buf2, len))
le_copy(buf, len, bnbuf, sizeof(bnbuf));
if (!TEST_mem_eq(raw_values[n].value, len, buf, len))
goto err;
param.data_size = param.return_size;
if (!TEST_true(OSSL_PARAM_get_BN(&param, &c))