mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-23 14:42:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

dh_test: fix coverity 1473239 Argument cannot be negative (NEGATIVE_RETURNS)

Browse Source 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15943)
This commit is contained in:
Pauli 2021-06-29 08:18:30 +10:00
parent 159dacca46
commit 98431c4313
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/dhtest.c
View File

@ -558,6 +558,7 @@ static int rfc5114_test(void)
DH *dhB = NULL;
unsigned char *Z1 = NULL;
unsigned char *Z2 = NULL;
int szA, szB;
const rfc5114_td *td = NULL;
BIGNUM *priv_key = NULL, *pub_key = NULL;
const BIGNUM *pub_key_tmp;
@ -580,12 +581,14 @@ static int rfc5114_test(void)
goto bad_err;
priv_key = pub_key = NULL;
if (!TEST_uint_eq(td->Z_len, (size_t)DH_size(dhA))
|| !TEST_uint_eq(td->Z_len, (size_t)DH_size(dhB)))
if (!TEST_int_gt(szA = DH_size(dhA), 0)
|| !TEST_int_gt(szB = DH_size(dhB), 0)
|| !TEST_size_t_eq(td->Z_len, (size_t)szA)
|| !TEST_size_t_eq(td->Z_len, (size_t)szB))
goto err;
if (!TEST_ptr(Z1 = OPENSSL_malloc(DH_size(dhA)))
|| !TEST_ptr(Z2 = OPENSSL_malloc(DH_size(dhB))))
if (!TEST_ptr(Z1 = OPENSSL_malloc((size_t)szA))
|| !TEST_ptr(Z2 = OPENSSL_malloc((size_t)szB)))
goto bad_err;
/*
* Work out shared secrets using both sides and compare with expected