From 8e520d2714abf4c6254ceec24b57f238433541ee Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Tue, 17 Oct 2023 08:58:22 +0200 Subject: [PATCH] Postpone two TODO(QUIC) items appropriately The one in ch_rx_handle_packet() is a tuning thing -> QUIC FUTURE The one in ossl_quic_tserver_shutdown() is a server thing -> QUIC SERVER Reviewed-by: Hugo Landau Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/22408) --- ssl/quic/quic_channel.c | 2 +- ssl/quic/quic_tserver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ssl/quic/quic_channel.c b/ssl/quic/quic_channel.c index 0462fd2411..3b9993b96a 100644 --- a/ssl/quic/quic_channel.c +++ b/ssl/quic/quic_channel.c @@ -2302,7 +2302,7 @@ static void ch_rx_handle_packet(QUIC_CHANNEL *ch) * non-zero Token Length field MUST either discard the packet or * generate a connection error of type PROTOCOL_VIOLATION. * - * TODO(QUIC): consider the implications of RFC 9000 s. 10.2.3 + * TODO(QUIC FUTURE): consider the implications of RFC 9000 s. 10.2.3 * Immediate Close during the Handshake: * However, at the cost of reducing feedback about * errors for legitimate peers, some forms of denial of diff --git a/ssl/quic/quic_tserver.c b/ssl/quic/quic_tserver.c index 3630577e70..3fc51b4a77 100644 --- a/ssl/quic/quic_tserver.c +++ b/ssl/quic/quic_tserver.c @@ -508,7 +508,7 @@ int ossl_quic_tserver_shutdown(QUIC_TSERVER *srv, uint64_t app_error_code) { ossl_quic_channel_local_close(srv->ch, app_error_code, NULL); - /* TODO(QUIC): !SSL_SHUTDOWN_FLAG_NO_STREAM_FLUSH */ + /* TODO(QUIC SERVER): !SSL_SHUTDOWN_FLAG_NO_STREAM_FLUSH */ if (ossl_quic_channel_is_terminated(srv->ch)) return 1;