mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-02-17 14:32:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove TODO in test/acvp_test.c related to setting AES-GCM iv.

Browse Source 
Fixes #14330

Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14525)
This commit is contained in:
Shane Lontis 2021-03-12 12:53:14 +10:00 committed by Pauli
parent cd3f8c1b11
commit 8bfb8f3458
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/acvp_test.c
View File

@ -837,8 +837,9 @@ static int aes_gcm_enc_dec(const char *alg,
goto err;
}
/*
* TODO(3.0): The IV should not be set outside the boundary as it is now.
* It needs to be fed in via a dummy entropy source for this test.
* For testing purposes the IV it being set here. In a compliant application
* the IV would be generated internally. A fake entropy source could also
* be used to feed in the random IV bytes (see fake_random.c)
*/
if (!TEST_true(EVP_CipherInit_ex(ctx, NULL, NULL, key, iv, enc))
|| !TEST_true(EVP_CIPHER_CTX_set_padding(ctx, 0))