From 73a815defe428e42ccc27fdc9d5be507f980278b Mon Sep 17 00:00:00 2001 From: Pauli Date: Thu, 4 Nov 2021 11:59:55 +1000 Subject: [PATCH] Fix coverity 1493364 & 1493375: unchecked return value Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/16962) --- crypto/comp/c_zlib.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/crypto/comp/c_zlib.c b/crypto/comp/c_zlib.c index b36a562d88..9a7087e444 100644 --- a/crypto/comp/c_zlib.c +++ b/crypto/comp/c_zlib.c @@ -380,7 +380,11 @@ static int bio_zlib_read(BIO *b, char *out, int outl) ERR_raise(ERR_LIB_COMP, ERR_R_MALLOC_FAILURE); return 0; } - inflateInit(zin); + if ((ret = inflateInit(zin)) != Z_OK) { + ERR_raise_data(ERR_LIB_COMP, COMP_R_ZLIB_INFLATE_ERROR, + "zlib error: %s", zError(ret)); + return 0; + } zin->next_in = ctx->ibuf; zin->avail_in = 0; } @@ -443,7 +447,11 @@ static int bio_zlib_write(BIO *b, const char *in, int inl) } ctx->optr = ctx->obuf; ctx->ocount = 0; - deflateInit(zout, ctx->comp_level); + if ((ret = deflateInit(zout, ctx->comp_level)) != Z_OK) { + ERR_raise_data(ERR_LIB_COMP, COMP_R_ZLIB_DEFLATE_ERROR, + "zlib error: %s", zError(ret)); + return 0; + } zout->next_out = ctx->obuf; zout->avail_out = ctx->obufsize; }