mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-03-25 20:00:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check for negative return for signature size.Addresses Coverity 1442933

Browse Source 
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8392)
This commit is contained in:
Pauli 2019-03-04 13:37:39 +10:00
parent 38023b87f0
commit 68ad17e874
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/ecdsatest.c
View File

@ -205,6 +205,7 @@ static int test_builtin(int n)
EVP_MD_CTX *mctx = NULL;
size_t sig_len;
int nid, ret = 0;
int temp;
nid = curves[n].nid;
@ -231,9 +232,10 @@ static int test_builtin(int n)
|| !TEST_true(EVP_PKEY_assign_EC_KEY(pkey_neg, eckey_neg)))
goto err;
sig_len = ECDSA_size(eckey);
temp = ECDSA_size(eckey);
if (!TEST_ptr(sig = OPENSSL_malloc(sig_len))
if (!TEST_int_ge(temp, 0)
|| !TEST_ptr(sig = OPENSSL_malloc(sig_len = (size_t)temp))
/* create a signature */
|| !TEST_true(EVP_DigestSignInit(mctx, NULL, NULL, NULL, pkey))
|| !TEST_true(EVP_DigestSign(mctx, sig, &sig_len, tbs, sizeof(tbs)))