mirror of
https://github.com/openssl/openssl.git
synced 2025-02-23 14:42:15 +08:00
Avoid leaking *ba_ret on reconnections
Also fixes Coverity 1604639 There is no point in checking ba_ret as it can never be NULL. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> (Merged from https://github.com/openssl/openssl/pull/24931)
This commit is contained in:
parent
f41b5ffe33
commit
4fa9d1f40f
apps
@ -84,9 +84,6 @@ int init_client(int *sock, const char *host, const char *port,
|
||||
int ret;
|
||||
int options = 0;
|
||||
|
||||
if (tfo && ba_ret != NULL)
|
||||
*ba_ret = NULL;
|
||||
|
||||
if (BIO_sock_init() != 1)
|
||||
return 0;
|
||||
|
||||
|
@ -2167,6 +2167,9 @@ int s_client_main(int argc, char **argv)
|
||||
if (tfo)
|
||||
BIO_printf(bio_c_out, "Connecting via TFO\n");
|
||||
re_start:
|
||||
/* peer_addr might be set from previous connections */
|
||||
BIO_ADDR_free(peer_addr);
|
||||
peer_addr = NULL;
|
||||
if (init_client(&sock, host, port, bindhost, bindport, socket_family,
|
||||
socket_type, protocol, tfo, !isquic, &peer_addr) == 0) {
|
||||
BIO_printf(bio_err, "connect:errno=%d\n", get_last_socket_error());
|
||||
|
Loading…
Reference in New Issue
Block a user