From 3c4c8dd84ac18345a44120bb28f7fc85e33da093 Mon Sep 17 00:00:00 2001 From: Pauli Date: Fri, 19 Mar 2021 13:05:16 +1000 Subject: [PATCH] encoder: fix coverity 1473235: null dereference Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/14618) --- crypto/encode_decode/encoder_pkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/encode_decode/encoder_pkey.c b/crypto/encode_decode/encoder_pkey.c index fc5a391420..713aa44131 100644 --- a/crypto/encode_decode/encoder_pkey.c +++ b/crypto/encode_decode/encoder_pkey.c @@ -261,7 +261,7 @@ static int ossl_encoder_ctx_setup_for_pkey(OSSL_ENCODER_CTX *ctx, } } - if (OSSL_ENCODER_CTX_get_num_encoders(ctx) != 0) { + if (data != NULL && OSSL_ENCODER_CTX_get_num_encoders(ctx) != 0) { if (!OSSL_ENCODER_CTX_set_construct(ctx, encoder_construct_pkey) || !OSSL_ENCODER_CTX_set_construct_data(ctx, data) || !OSSL_ENCODER_CTX_set_cleanup(ctx, encoder_destruct_pkey))