Add notes on use of strdup

Added notes to OPENSSL_INIT_set_config_filename and
OPENSSL_INIT_set_config_appname explaining why strdup
is used instead of OPENSSL_strdup.

CLA: trivial

Co-authored-by: Jean Apolo <jean.apolo@garmin.com>
Signed-off-by: Jean Apolo <jean.apolo@garmin.com>
Signed-off-by: Nate Karstens <nate.karstens@garmin.com>

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21742)
This commit is contained in:
Nate Karstens 2023-10-20 11:24:33 -05:00 committed by Matt Caswell
parent a2fe10ca39
commit 26f75c2d60

View File

@ -421,6 +421,12 @@ OPENSSL_INIT_SETTINGS *OPENSSL_INIT_new(void)
#ifndef OPENSSL_NO_STDIO
/*
* If CRYPTO_set_mem_functions is called after this, then
* memory allocation and deallocation in this function can
* become disjointed. Avoid this by always using standard
* strdup & free instead of OPENSSL_strdup & OPENSSL_free.
*/
int OPENSSL_INIT_set_config_filename(OPENSSL_INIT_SETTINGS *settings,
const char *filename)
{
@ -444,6 +450,12 @@ void OPENSSL_INIT_set_config_file_flags(OPENSSL_INIT_SETTINGS *settings,
settings->flags = flags;
}
/*
* If CRYPTO_set_mem_functions is called after this, then
* memory allocation and deallocation in this function can
* become disjointed. Avoid this by always using standard
* strdup & free instead of OPENSSL_strdup & OPENSSL_free.
*/
int OPENSSL_INIT_set_config_appname(OPENSSL_INIT_SETTINGS *settings,
const char *appname)
{