mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2024-11-27 05:21:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

bn: remove TODOs

Browse Source 
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15539)
This commit is contained in:
Pauli 2021-05-31 14:29:55 +10:00
parent 79cabd7e27
commit 26b3e44a66
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crypto/bn/bn_ctx.c
View File

@ -11,19 +11,6 @@
#include "internal/cryptlib.h" #include "internal/cryptlib.h"
#include "bn_local.h" #include "bn_local.h"
/*-
* TODO list
*
* 1. Check a bunch of "(words+1)" type hacks in various bignum functions and
* check they can be safely removed.
* - Check +1 and other ugliness in BN_from_montgomery()
*
* 2. Consider allowing a BN_new_ex() that, at least, lets you specify an
* appropriate 'block' size that will be honoured by bn_expand_internal() to
* prevent piddly little reallocations. OTOH, profiling bignum expansions in
* BN_CTX doesn't show this to be a big issue.
*/
/* How many bignums are in each "pool item"; */ /* How many bignums are in each "pool item"; */
#define BN_CTX_POOL_SIZE 16 #define BN_CTX_POOL_SIZE 16
/* The stack frame info is resizing, set a first-time expansion size; */ /* The stack frame info is resizing, set a first-time expansion size; */

1
crypto/bn/bn_prime.c
View File

@ -483,7 +483,6 @@ static int probable_prime(BIGNUM *rnd, int bits, int safe, prime_t *mods,
BN_ULONG maxdelta = BN_MASK2 - primes[trial_divisions - 1]; BN_ULONG maxdelta = BN_MASK2 - primes[trial_divisions - 1];
again: again:
/* TODO: Not all primes are private */
if (!BN_priv_rand_ex(rnd, bits, BN_RAND_TOP_TWO, BN_RAND_BOTTOM_ODD, 0, if (!BN_priv_rand_ex(rnd, bits, BN_RAND_TOP_TWO, BN_RAND_BOTTOM_ODD, 0,
ctx)) ctx))
return 0; return 0;