mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-01-30 14:01:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in quic_trace.c

Browse Source 
Fixes #24340

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24568)
This commit is contained in:
Amir Mohammadi 2024-06-05 22:26:19 +03:30 committed by Tomas Mraz
parent d4700c0b23
commit 1977c00f00
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ssl/quic/quic_trace.c
View File

@ -79,20 +79,21 @@ static int frame_ack(BIO *bio, PACKET *pkt)
OSSL_QUIC_ACK_RANGE *ack_ranges = NULL;
uint64_t total_ranges = 0;
uint64_t i;
int ret = 0;
if (!ossl_quic_wire_peek_frame_ack_num_ranges(pkt, &total_ranges)
/* In case sizeof(uint64_t) > sizeof(size_t) */
|| total_ranges > SIZE_MAX / sizeof(ack_ranges[0])
|| (ack_ranges = OPENSSL_zalloc(sizeof(ack_ranges[0])
* (size_t)total_ranges)) == NULL)
return 0;
return ret;
ack.ack_ranges = ack_ranges;
ack.num_ack_ranges = (size_t)total_ranges;
/* Ack delay exponent is 0, so we can get the raw delay time below */
if (!ossl_quic_wire_decode_frame_ack(pkt, 0, &ack, NULL))
return 0;
goto end;
BIO_printf(bio, " Largest acked: %llu\n",
(unsigned long long)ack.ack_ranges[0].end);
@ -112,8 +113,10 @@ static int frame_ack(BIO *bio, PACKET *pkt)
- ack.ack_ranges[i].start));
}
ret = 1;
end:
OPENSSL_free(ack_ranges);
return 1;
return ret;
}
static int frame_reset_stream(BIO *bio, PACKET *pkt)