mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2024-11-27 05:21:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't try to test ctype functions for values < 0 or > 255

Browse Source 
Values that aren't representable as unsigned give undefined results.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4219)
This commit is contained in:
Richard Levitte 2017-08-22 15:51:35 +02:00
parent 176db6dc51
commit 196f5c4b0d
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/ctype_internal_test.c
View File

@ -42,11 +42,6 @@ static int test_ctype_chars(int n)
&& TEST_int_eq(isxdigit(n) != 0, ossl_isxdigit(n) != 0);
}
static int test_ctype_negative(int n)
{
return test_ctype_chars(-n);
}
static struct {
int u;
int l;
@ -58,10 +53,7 @@ static struct {
{ '%', '%' },
{ '~', '~' },
{ 0, 0 },
{ EOF, EOF },
{ 333, 333 },
{ -333, -333 },
{ -128, -128 }
{ EOF, EOF }
};
static int test_ctype_toupper(int n)
@ -79,7 +71,6 @@ static int test_ctype_tolower(int n)
int setup_tests(void)
{
ADD_ALL_TESTS(test_ctype_chars, 256);
ADD_ALL_TESTS(test_ctype_negative, 128);
ADD_ALL_TESTS(test_ctype_toupper, OSSL_NELEM(case_change));
ADD_ALL_TESTS(test_ctype_tolower, OSSL_NELEM(case_change));
return 1;