mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-01-18 13:44:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

TLS 1.3 client sigalgs test no longer needs TLS 1.2

Browse Source 
Per the TODO comment, we now have proper certificate selection for
TLS 1.3 client certificates, so this test can move into its own
block.  (It cannot merge with the previous block, as it requires EC.)

Verified that the test passes when configured with enable-tls1_3
no-tls1 no-tls1_1 no-tls1_2.

Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3131)
This commit is contained in:
Benjamin Kaduk 2017-04-05 13:32:18 -05:00 committed by Matt Caswell
parent cf34d54d82
commit 0e1e4045c4
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/recipes/70-test_sslsigalgs.t
View File

@ -92,20 +92,20 @@ SKIP: {
}
SKIP: {
skip "EC, TLSv1.3 or TLSv1.2 disabled", 2
if disabled("tls1_2") || disabled("tls1_3") || disabled("ec");
skip "EC or TLSv1.3 disabled", 1
if disabled("tls1_3") || disabled("ec");
#Test 7: Sending a valid sig algs list but not including a sig type that
# matches the certificate should fail in TLSv1.3. We need TLSv1.2
# enabled for this test - otherwise the client will not attempt to
# connect due to no TLSv1.3 ciphers being available.
# TODO(TLS1.3): When proper TLSv1.3 certificate selection is working
# we can move this test into the section above
# matches the certificate should fail in TLSv1.3.
$proxy->clear();
$proxy->clientflags("-sigalgs ECDSA+SHA256");
$proxy->filter(undef);
$proxy->start();
ok(TLSProxy::Message->fail, "No matching TLSv1.3 sigalgs");
}
SKIP: {
skip "EC, TLSv1.3 or TLSv1.2 disabled", 1
if disabled("tls1_2") || disabled("tls1_3") || disabled("ec");
#Test 8: Sending a full list of TLSv1.3 sig algs but negotiating TLSv1.2
# should succeed