mirror/openssl
2
0
Fork 0
mirror of https://github.com/openssl/openssl.git synced 2025-04-06 20:20:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refactor squeezing out empty tuples

Browse Source 
This is more efficient if multiple empty tuples are present, and may
also help to avoid Coverify false positives.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26732)
This commit is contained in:
Viktor Dukhovni 2025-02-13 18:40:15 +11:00
parent c71c65b922
commit 0554bddd4f
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ssl/t1_lib.c
View File

@ -1675,18 +1675,19 @@ int tls1_set_groups_list(SSL_CTX *ctx,
}
/*
* We check whether a tuple was completly emptied by using "-" prefix excessively,
* in which case we remove the tuple
* We check whether a tuple was completly emptied by using "-" prefix
* excessively, in which case we remove the tuple
*/
for (i = 0; i < gcb.tplcnt; i++) {
if (gcb.tuplcnt_arr[i] == 0) {
for (j = i; j < (gcb.tplcnt - 1); j++) /* Move tuples to the left */
gcb.tuplcnt_arr[j] = gcb.tuplcnt_arr[j + 1];
gcb.tplcnt--; /* We just deleted a tuple, update book keeping */
i--; /* Acount for the fact that the list is shorter now */
}
for (i = j = 0; j < gcb.tplcnt; j++) {
if (gcb.tuplcnt_arr[j] == 0)
continue;
/* If there's a gap, move to first unfilled slot */
if (j == i)
++i;
else
gcb.tuplcnt_arr[i++] = gcb.tuplcnt_arr[j];
}
gcb.tplcnt = i;
/* Some more checks (at least one remaining group, not more that nominally 4 key shares */
if (gcb.gidcnt == 0) {