mirror of
https://git.openldap.org/openldap/openldap.git
synced 2025-01-12 10:54:48 +08:00
9ee9f1e0e1
Now operations that set the status of an entry to CREATING (add.c, modrdn.c) need to set it to COMMIT, by calling cache_entry_commit, before returning the entry itself, otherwise the entry is removed from the cache and its private data is freed. Should fix crashes due to add failures as in ITS#1245
383 lines
8.7 KiB
C
383 lines
8.7 KiB
C
/* add.c - ldap ldbm back-end add routine */
|
|
/* $OpenLDAP$ */
|
|
/*
|
|
* Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
|
|
* COPYING RESTRICTIONS APPLY, see COPYRIGHT file
|
|
*/
|
|
|
|
#include "portable.h"
|
|
|
|
#include <stdio.h>
|
|
|
|
#include <ac/socket.h>
|
|
#include <ac/string.h>
|
|
|
|
#include "slap.h"
|
|
#include "back-ldbm.h"
|
|
#include "proto-back-ldbm.h"
|
|
|
|
int
|
|
ldbm_back_add(
|
|
Backend *be,
|
|
Connection *conn,
|
|
Operation *op,
|
|
Entry *e
|
|
)
|
|
{
|
|
struct ldbminfo *li = (struct ldbminfo *) be->be_private;
|
|
char *pdn;
|
|
Entry *p = NULL;
|
|
int rootlock = 0;
|
|
int rc;
|
|
ID id = NOID;
|
|
const char *text = NULL;
|
|
AttributeDescription *children = slap_schema.si_ad_children;
|
|
char textbuf[SLAP_TEXT_BUFLEN];
|
|
size_t textlen = sizeof textbuf;
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ENTRY,"ldbm_back_add: %s\n",
|
|
e->e_dn ));
|
|
#else
|
|
Debug(LDAP_DEBUG_ARGS, "==> ldbm_back_add: %s\n", e->e_dn, 0, 0);
|
|
#endif
|
|
|
|
|
|
/* nobody else can add until we lock our parent */
|
|
ldap_pvt_thread_mutex_lock(&li->li_add_mutex);
|
|
|
|
if ( ( rc = dn2id( be, e->e_ndn, &id ) ) || id != NOID ) {
|
|
/* if (rc) something bad happened to ldbm cache */
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
send_ldap_result( conn, op,
|
|
rc ? LDAP_OPERATIONS_ERROR : LDAP_ALREADY_EXISTS,
|
|
NULL, NULL, NULL, NULL );
|
|
return( -1 );
|
|
}
|
|
|
|
rc = entry_schema_check( e, NULL, &text, textbuf, textlen );
|
|
|
|
if ( rc != LDAP_SUCCESS ) {
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: entry (%s) failed schema check.\n",
|
|
e->e_dn ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "entry failed schema check: %s\n",
|
|
text, 0, 0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op, rc,
|
|
NULL, text, NULL, NULL );
|
|
return( -1 );
|
|
}
|
|
|
|
/*
|
|
* Get the parent dn and see if the corresponding entry exists.
|
|
* If the parent does not exist, only allow the "root" user to
|
|
* add the entry.
|
|
*/
|
|
|
|
pdn = dn_parent( be, e->e_ndn );
|
|
|
|
if( pdn != NULL && *pdn != '\0' ) {
|
|
Entry *matched = NULL;
|
|
|
|
assert( *pdn != '\0' );
|
|
|
|
/* get parent with writer lock */
|
|
if ( (p = dn2entry_w( be, pdn, &matched )) == NULL ) {
|
|
char *matched_dn;
|
|
struct berval **refs;
|
|
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
|
|
if ( matched != NULL ) {
|
|
matched_dn = ch_strdup( matched->e_dn );
|
|
refs = is_entry_referral( matched )
|
|
? get_entry_referrals( be, conn, op, matched )
|
|
: NULL;
|
|
cache_return_entry_r( &li->li_cache, matched );
|
|
|
|
} else {
|
|
matched_dn = NULL;
|
|
refs = default_referral;
|
|
}
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: Parent of (%s) does not exist.\n",
|
|
e->e_dn ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "parent does not exist\n",
|
|
0, 0, 0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op, LDAP_REFERRAL, matched_dn,
|
|
refs == NULL ? "parent does not exist" : "parent is referral",
|
|
refs, NULL );
|
|
|
|
if( matched != NULL ) {
|
|
ber_bvecfree( refs );
|
|
free( matched_dn );
|
|
}
|
|
|
|
free( pdn );
|
|
return -1;
|
|
}
|
|
|
|
/* don't need the add lock anymore */
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
|
|
free(pdn);
|
|
|
|
if ( ! access_allowed( be, conn, op, p,
|
|
children, NULL, ACL_WRITE ) )
|
|
{
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: No write access to parent (%s).\n",
|
|
e->e_dn ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "no write access to parent\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
|
|
send_ldap_result( conn, op, LDAP_INSUFFICIENT_ACCESS,
|
|
NULL, "no write access to parent", NULL, NULL );
|
|
|
|
|
|
return -1;
|
|
}
|
|
|
|
if ( is_entry_alias( p ) ) {
|
|
/* parent is an alias, don't allow add */
|
|
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: Parent is an alias.\n"));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "parent is alias\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op, LDAP_ALIAS_PROBLEM,
|
|
NULL, "parent is an alias", NULL, NULL );
|
|
|
|
return -1;
|
|
}
|
|
|
|
if ( is_entry_referral( p ) ) {
|
|
/* parent is a referral, don't allow add */
|
|
char *matched_dn = ch_strdup( p->e_dn );
|
|
struct berval **refs = is_entry_referral( p )
|
|
? get_entry_referrals( be, conn, op, p )
|
|
: NULL;
|
|
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: Parent is referral.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "parent is referral\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
|
|
send_ldap_result( conn, op, LDAP_REFERRAL,
|
|
matched_dn, NULL, refs, NULL );
|
|
|
|
ber_bvecfree( refs );
|
|
free( matched_dn );
|
|
return -1;
|
|
}
|
|
|
|
} else {
|
|
if(pdn != NULL) {
|
|
assert( *pdn == '\0' );
|
|
free(pdn);
|
|
}
|
|
|
|
/* no parent, must be adding entry to root */
|
|
if ( !be_isroot( be, op->o_ndn ) && !be_issuffix( be, "" ) ) {
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: %s add denied.\n",
|
|
pdn == NULL ? "suffix" : "entry at root" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "%s add denied\n",
|
|
pdn == NULL ? "suffix" : "entry at root",
|
|
0, 0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op, LDAP_INSUFFICIENT_ACCESS,
|
|
NULL, NULL, NULL, NULL );
|
|
|
|
return -1;
|
|
}
|
|
|
|
/*
|
|
* no parent, acquire the root write lock
|
|
* and release the add lock.
|
|
*/
|
|
ldap_pvt_thread_mutex_lock(&li->li_root_mutex);
|
|
rootlock = 1;
|
|
ldap_pvt_thread_mutex_unlock(&li->li_add_mutex);
|
|
}
|
|
|
|
if ( next_id( be, &e->e_id ) ) {
|
|
if( p != NULL) {
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
}
|
|
|
|
if ( rootlock ) {
|
|
/* release root lock */
|
|
ldap_pvt_thread_mutex_unlock(&li->li_root_mutex);
|
|
}
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: next_id failed.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_ANY, "ldbm_add: next_id failed\n",
|
|
0, 0, 0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op, LDAP_OTHER,
|
|
NULL, "next_id add failed", NULL, NULL );
|
|
|
|
return( -1 );
|
|
}
|
|
|
|
/*
|
|
* Try to add the entry to the cache, assign it a new dnid.
|
|
*/
|
|
rc = cache_add_entry_rw(&li->li_cache, e, CACHE_WRITE_LOCK);
|
|
|
|
if ( rc != 0 ) {
|
|
if( p != NULL) {
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
}
|
|
|
|
if ( rootlock ) {
|
|
/* release root lock */
|
|
ldap_pvt_thread_mutex_unlock(&li->li_root_mutex);
|
|
}
|
|
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: cache_add_entry_lock failed.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_ANY, "cache_add_entry_lock failed\n", 0, 0,
|
|
0 );
|
|
#endif
|
|
|
|
|
|
send_ldap_result( conn, op,
|
|
rc > 0 ? LDAP_ALREADY_EXISTS : LDAP_OTHER,
|
|
NULL, rc > 0 ? NULL : "cache add failed", NULL, NULL );
|
|
|
|
return( -1 );
|
|
}
|
|
|
|
rc = -1;
|
|
|
|
/* attribute indexes */
|
|
if ( index_entry_add( be, e, e->e_attrs ) != LDAP_SUCCESS ) {
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: index_entry_add failed.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "index_entry_add failed\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
|
|
send_ldap_result( conn, op, LDAP_OTHER,
|
|
NULL, "index generation failed", NULL, NULL );
|
|
|
|
goto return_results;
|
|
}
|
|
|
|
/* dn2id index */
|
|
if ( dn2id_add( be, e->e_ndn, e->e_id ) != 0 ) {
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: dn2id_add failed.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "dn2id_add failed\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
/* FIXME: delete attr indices? */
|
|
|
|
send_ldap_result( conn, op, LDAP_OTHER,
|
|
NULL, "DN index generation failed", NULL, NULL );
|
|
|
|
goto return_results;
|
|
}
|
|
|
|
/* id2entry index */
|
|
if ( id2entry_add( be, e ) != 0 ) {
|
|
#ifdef NEW_LOGGING
|
|
LDAP_LOG(( "backend", LDAP_LEVEL_ERR,
|
|
"ldbm_back_add: id2entry_add failed.\n" ));
|
|
#else
|
|
Debug( LDAP_DEBUG_TRACE, "id2entry_add failed\n", 0,
|
|
0, 0 );
|
|
#endif
|
|
|
|
/* FIXME: delete attr indices? */
|
|
(void) dn2id_delete( be, e->e_ndn, e->e_id );
|
|
|
|
send_ldap_result( conn, op, LDAP_OTHER,
|
|
NULL, "entry store failed", NULL, NULL );
|
|
|
|
goto return_results;
|
|
}
|
|
|
|
send_ldap_result( conn, op, LDAP_SUCCESS,
|
|
NULL, NULL, NULL, NULL );
|
|
|
|
/* marks the entry as committed, so it is added to the cache;
|
|
* otherwise it is removed from the cache, but not destroyed;
|
|
* it will be destroyed by the caller */
|
|
rc = 0;
|
|
cache_entry_commit( e );
|
|
|
|
return_results:;
|
|
if (p != NULL) {
|
|
/* free parent and writer lock */
|
|
cache_return_entry_w( &li->li_cache, p );
|
|
}
|
|
|
|
if ( rootlock ) {
|
|
/* release root lock */
|
|
ldap_pvt_thread_mutex_unlock(&li->li_root_mutex);
|
|
}
|
|
|
|
if ( rc ) {
|
|
/* in case of error, writer lock is freed
|
|
* and entry's private data is destroyed */
|
|
cache_return_entry_w( &li->li_cache, e );
|
|
}
|
|
|
|
return( rc );
|
|
}
|