Pierangelo Masarati
ab4eb5e673
skip operations when internal
2011-01-02 23:36:30 +00:00
Pierangelo Masarati
d562608e40
memberof handling of rename (ITS#6700)
2011-01-02 23:03:13 +00:00
Pierangelo Masarati
7c77d9b801
fix control value generation (ITS#6652)
2011-01-02 17:19:14 +00:00
Pierangelo Masarati
0a12ea91df
hex digits need to be in pairs (ITS#6652)
2011-01-02 15:58:48 +00:00
Pierangelo Masarati
cddaeff565
fix reqControls validator (partially addresses ITS#6652)
2011-01-02 15:50:00 +00:00
Pierangelo Masarati
b672d8535d
make sure initialization is only tried once; improve error messages
2011-01-02 15:06:11 +00:00
Pierangelo Masarati
f2df9f0cf5
add some logging (under TRACE)
2011-01-02 12:29:19 +00:00
Pierangelo Masarati
5c8d655bbb
quick fix for null DN
2011-01-02 02:15:21 +00:00
Hallvard Furuseth
bdb078a778
ITS#6758 Reset dangerous REP_ENTRY_* flags.
...
If SlapReply.sr_un cannot contain an entry but does or soon may
contain another member than sru_search: Ensure nothing will see
leftover REP_ENTRY_* flags and try to clean up the "entry" there.
2010-12-31 20:53:17 +00:00
Hallvard Furuseth
b26c767ed6
ITS#6758 slap.h: Cast REP_* #defines to slap_mask_t
2010-12-31 20:02:41 +00:00
Hallvard Furuseth
9467059b0b
ITS#6758 fix/add slap_send_search_entry() comments
2010-12-31 19:57:53 +00:00
Hallvard Furuseth
a4c2d54127
ITS#6758 result.c:Use rs_*(). Frees entries earlier.
...
For readability, use rs_flush_entry() where slap_send_search_entry() and
slap_send_search_reference() release entries before network operations.
This change also frees entires marked MUSTBEFREED earlier.
2010-12-31 18:14:31 +00:00
Hallvard Furuseth
f4a3304477
ITS#6758 Use rs_*() to manage SlapReply entries.
...
Some noop changes + fixes entry leaks and REP_ENTRY_MODIFIABLE flag leaks.
2010-12-31 17:55:36 +00:00
Hallvard Furuseth
15aa7c472a
noop commit: cleanup 0 -> REP_RESULT in SlapReply
2010-12-31 14:08:34 +00:00
Hallvard Furuseth
713886ec07
ITS#6758, pcache.c: Avoid SlapReply reuse.
...
refresh_merge(): Do not reuse Search SlapReply parameter for a Modify,
use a local one and copy its sr_err to the parameter. The parameter is
from refresh_query(). Move its SlapReply parameter to a local variable.
2010-12-31 13:46:48 +00:00
Hallvard Furuseth
6d7c1880a8
ITS#6758 Avoid SlapReply reuse.
...
Caller provides a SlapReply and reads the result after the operation,
then reuses it. Reinitialize before reuse, or move declaration inwards.
2010-12-31 13:08:11 +00:00
Hallvard Furuseth
04f8fa5619
ITS#6760: Fix rwm entry handling
2010-12-31 12:01:03 +00:00
Hallvard Furuseth
13f52646b2
ITS#6758 Avoid SlapReply reuse, simple cases.
...
Caller provides and reuses a SlapReply it does not read after
initialization. So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().
2010-12-31 10:46:22 +00:00
Hallvard Furuseth
cb15a4c687
ITS#6758 rs_reinit() += slap_reply_t parameter
2010-12-31 09:45:16 +00:00
Hallvard Furuseth
b120b2a05b
ITS#6758 config_build_entry, avoid SlapReply reuse
...
Do not use the 'SlapReply *rs' passed to config_build_entry(). Instead
pass a new one to op->o_bd->be_add() and copy the output sr_err to rs.
This takes care of most SlapReply reuse in bconfig.c.
2010-12-31 09:02:34 +00:00
Hallvard Furuseth
ab1bc728fa
ITS#6758 bconfig.c: ensure sr_text==NULL if sr_err==LDAP_SUCCESS
...
config_modify_internal(): Do not send rs->sr_text with success.
config_back_modify(): When slap_bv2ad() can set rs->sr_text,
set sr->sr_err too and catch failure.
2010-12-31 08:45:48 +00:00
Howard Chu
089cf2d421
ITS#6670 partial fix - ignore member/memberof pointing to same entry
2010-12-31 01:38:24 +00:00
Hallvard Furuseth
abf7f2efce
ITS#6758 back-bdb: Delay setting sr->sr_entry until we know it will be used
2010-12-31 00:04:38 +00:00
Hallvard Furuseth
1ea8de9fda
ITS#6758 Do not set sr_err=error before be_search.
...
glue_op_search() set LDAP_UNWILLING_TO_PERFORM before be_search() as
well as when there was no be_search.
2010-12-30 23:59:23 +00:00
Hallvard Furuseth
d2b024be4a
ITS#6758 Reset some SlapReply flags & data.
...
Reset data more consistenlty. When resetting sr_entry after sending
data, reset sr_flag as well. Reset rs_attrs and Extended Operation
oid/data after setting and sending them.
2010-12-30 23:55:07 +00:00
Hallvard Furuseth
f7a77545ad
noop commit for ITS#6758: simplify future commits
2010-12-30 23:48:41 +00:00
Hallvard Furuseth
98966abeef
noop commit for ITS#6758: Remove no-effect code.
...
Unused variable resets, unused SlapReply parameters to some functions.
2010-12-30 23:43:12 +00:00
Hallvard Furuseth
cd6e9156e7
Remove lint (unused vars/labels/funcs/default:s)
2010-12-30 23:34:55 +00:00
Hallvard Furuseth
5c3f806fca
ITS#6758 Add rs_reinit(), rs_flush_entry()
2010-12-30 23:32:07 +00:00
Hallvard Furuseth
ea2b675dca
ITS#6758 Add rs_assert*, RS_ASSERT, USE_RS_ASSERT
2010-12-30 23:29:46 +00:00
Hallvard Furuseth
c9e85af35c
ITS#6759: assert;Debug -> Debug;assert
2010-12-30 23:19:02 +00:00
Pierangelo Masarati
7443e6fc8c
op->o_conn->c_sb may be 0 for internal operations
2010-12-30 21:41:07 +00:00
Rein Tollevik
a1a5affeb0
ITS#6754: Fail if there are unrecognized command-line arguments.
2010-12-30 19:45:08 +00:00
Howard Chu
97d9b07814
ITS#5862 Assert control for rootDSE/subschema
2010-12-30 17:28:19 +00:00
Hallvard Furuseth
027b6812ee
ITS#6686 Fix last commit (declaration after code)
2010-12-28 15:59:48 +00:00
Howard Chu
e907ba219b
ITS#6686 add multiple sorts per connection, from Raphael Ouazana @ Linagora
2010-12-23 22:29:57 +00:00
Howard Chu
56888eac30
Move assertion checking to slap_compare_entry()
2010-12-23 21:53:05 +00:00
Howard Chu
9bb47f74ae
ITS#6753 use slap_compare_entry()
2010-12-23 21:45:36 +00:00
Howard Chu
149313fd25
ITS#6573 export compare_entry as slap_compare_entry()
2010-12-23 21:36:57 +00:00
Howard Chu
0393fe8974
Cleanup for #6660
2010-12-23 04:40:57 +00:00
Howard Chu
f58a646ad6
ITS#6660 preliminary fix. debug additions need to be cleaned up.
2010-12-23 00:16:19 +00:00
Hallvard Furuseth
720aa4b77e
Plug mutex/rwlock leaks (destroy them)
2010-12-20 10:57:06 +00:00
Hallvard Furuseth
78a0be6a42
Plug memory leaks
2010-12-20 10:51:14 +00:00
Hallvard Furuseth
9e6331f14f
ITS#6752 Remove OpenLDAP 2.[23] dynlist code
2010-12-20 10:25:11 +00:00
Hallvard Furuseth
e7df2ef95f
ITS#6752 Handle REP_ENTRY_* flags correctly
2010-12-20 10:22:19 +00:00
Hallvard Furuseth
42a0f5efc2
ITS#6752 Fix dynlist Compare callback
...
Replace dynlist_sc_save_entry() with dynlist_sc_compare_entry() which
compares instead of saves the entry. Check rs->sr_type == REP_SEARCH.
2010-12-20 10:20:38 +00:00
Hallvard Furuseth
abbf57fd79
ITS#6752 dynlist: Do less work, simplify a bit.
...
Rearrange dynlist_compare(), tweak dynlist_response().
2010-12-20 10:19:21 +00:00
Hallvard Furuseth
2a9c5154ef
ITS#6748 Drop possibly-broken memberof log message
2010-12-14 15:26:42 +00:00
Hallvard Furuseth
5feeec67d7
ITS#6747 Fix LDAP_CONNECTIONLESS Debug(), warnings
2010-12-14 15:06:32 +00:00
Hallvard Furuseth
0aa8c028b3
ITS#6746: Preserve error code, plug entry leak
2010-12-14 13:35:42 +00:00
Rein Tollevik
b4aa8dc68c
ITS#6716: Keep sessionlog sorted by csn, compare mincsn with head.
2010-12-12 18:12:05 +00:00
Pierangelo Masarati
351bc07fcc
re-fix ITS#6645 commit
2010-12-07 11:58:38 +00:00
Pierangelo Masarati
615d1c7703
fix ITS#6645 commit
2010-12-07 11:55:27 +00:00
Pierangelo Masarati
15f1e7bdb7
move ctxcsn and schema check code in helpers; also apply to slapmodify (ITS#6737)
2010-12-07 10:50:54 +00:00
Pierangelo Masarati
dc156d7f6e
allow to set LDIF max line width (ITS#6645)
2010-12-07 10:14:51 +00:00
Hallvard Furuseth
87a9ee9e83
For ITS#6739: Fix last commit (private debuging)
2010-12-06 09:27:30 +00:00
Hallvard Furuseth
5fc18b9d66
For ITS#6739: Move variables into do_syncrep2 loop
2010-12-06 09:23:44 +00:00
Hallvard Furuseth
a5d1029f53
ITS#6736: Delay destruction of slap_listeners[]
2010-12-06 08:17:00 +00:00
Hallvard Furuseth
6be3671985
Fix rev 1.132 (ITS#6632): Initialize all of roc in rwm_callback_get()
2010-12-03 10:08:59 +00:00
Hallvard Furuseth
50b1c4e1b1
ITS#6620: Don't delete absent pwdChangedTime.
...
Based on patch by Martin Evans.
2010-12-02 12:19:31 +00:00
Hallvard Furuseth
4ed4c3a28f
ITS#6731: Fix scrambled back-ldif error strings.
...
* Move apply_modify_to_entry():textbuf[] into caller.
* Reset rs->sr_text at end of functions that can set it to textbuf.
2010-12-02 10:24:19 +00:00
Hallvard Furuseth
3d48d5a360
ITS#6730: Only update modifiersName once per entry
2010-12-01 11:21:29 +00:00
Hallvard Furuseth
a36512660f
ITS#6730: Fix missing refint updates with subtrees/subordinates
2010-12-01 11:19:17 +00:00
Hallvard Furuseth
9a9302a2f5
ITS#6663: Fix refint_nothing.
...
Also move callback trace output out of inner loop in callback.
2010-12-01 10:48:43 +00:00
Pierangelo Masarati
bce526a8cf
test slap_dontUseCopy_propnames (ITS#6729)
2010-12-01 10:41:05 +00:00
Pierangelo Masarati
fa4dbb871b
fix double free related to ITS#6720
2010-11-29 16:03:43 +00:00
Hallvard Furuseth
c9a63dc01a
Fix a comment
2010-11-28 18:20:54 +00:00
Hallvard Furuseth
f23fb051d5
Add/fix comments. No other change.
2010-11-28 18:04:22 +00:00
Hallvard Furuseth
5f2af361ba
ITS#6532 Support extensible match=...OrderingMatch
...
Handles: caseExactOrderingMatch, generalizedTimeOrderingMatch,
caseIgnoreOrderingMatch, integerOrderingMatch,
octetStringOrderingMatch, numericStringOrderingMatch.
Based on patch from Daniel Pluta.
2010-11-24 13:10:29 +00:00
Hallvard Furuseth
def5d26f13
ITS#6722: Fix some matching rules to ensure strict ordering
...
booleanMatch, octetStringMatch, octetStringOrderingMatch, uniqueMemberMatch
2010-11-23 11:17:40 +00:00
Hallvard Furuseth
4484781b0d
ITS#6721: Fix uninitialized tv_usec from ITS#6282
2010-11-23 10:10:45 +00:00
Hallvard Furuseth
0ab060091e
Silence gcc -Wsign-compare (no real change)
2010-11-22 13:45:11 +00:00
Hallvard Furuseth
e1469fff44
For ITS#5421: Also LBER_FREE() -> ber_memfree()
2010-11-22 13:14:29 +00:00
Hallvard Furuseth
b39e9d151d
For ITS#5421: Remove ldap-int.h dependencies.
...
LDAP_FREE() -> ber_memfree(), msg->lm_ber -> ldap_get_message_ber(msg).
2010-11-22 12:51:44 +00:00
Hallvard Furuseth
92986c3434
ITS#6715 cleanup: Handle attr_valfind(0 values) when SLAP_ATTR_SORTED_VALS
2010-11-22 12:16:08 +00:00
Pierangelo Masarati
b68703031b
initialize rc in syncrepl_add_glue_ancestors (ITS#6719)
2010-11-22 12:09:45 +00:00
Hallvard Furuseth
2a9cbcc5b5
No-op change for ITS#6715: help compiler a bit in attr_valfind()
2010-11-22 12:09:43 +00:00
Rein Tollevik
d3cddce244
ITS#6718: Send NEW_COOKIE messages to all consumers.
2010-11-21 19:00:38 +00:00
Rein Tollevik
990d8f562f
ITS#6710: Force clients to refresh if context is dirty.
2010-11-21 17:56:09 +00:00
Rein Tollevik
877fc0ab37
ITS#6709: Wait for active mods to finish before initiating new consumers.
2010-11-21 15:31:38 +00:00
Hallvard Furuseth
efcb0ad5a3
ITS#6715: Fix slap_sort_vals(attr with 1 value)
...
Also rearrange slightly to silence gcc -Wuninitialized, get a single
exit point, and skip the unnecessary sorting of the single value.
2010-11-19 12:21:34 +00:00
Pierangelo Masarati
9c1eae14a7
fix previous commit (ITS#6712)
2010-11-18 11:54:23 +00:00
Pierangelo Masarati
67f21784fd
do not add hasSubordinates if already present (blind-fixes ITS#6712 for back-monitor)
2010-11-18 11:53:59 +00:00
Pierangelo Masarati
3dcc62503a
do not add hasSubordinates if already present (blind-fixes ITS#6712 for back-sql)
2010-11-18 11:51:15 +00:00
Pierangelo Masarati
41858b7047
do not add hasSubordinates if already present (blind-fixes ITS#6712 for back-ndb)
2010-11-18 11:46:18 +00:00
Pierangelo Masarati
40831ba54f
do not add hasSubordinates if already present (fixes ITS#6712 for back-bdb/hdb, other backends may need work)
2010-11-18 11:33:47 +00:00
Ralf Haferkamp
66fa1f6198
ITS#6693 value dependent ACL didn't work when they were the first ACL
2010-11-15 16:27:56 +00:00
Rein Tollevik
ba86259aa0
ITS#6708: Mutex protect fixing the filter.
2010-11-15 15:42:06 +00:00
Rein Tollevik
e1dfe6e911
ITS#6707: Free the presentlist (if any) before connecting.
2010-11-15 14:15:46 +00:00
Pierangelo Masarati
001b30ebc6
fix slapo-chain startup issue when using back-config, related to ITS#6540
2010-11-14 23:53:54 +00:00
Howard Chu
1e18b823a0
ITS#6699 search references must turn onelevel scope to base
2010-11-12 04:35:49 +00:00
Ralf Haferkamp
e1c2a67517
Unregister VLV control as well when last overlay instance
...
is removed (additional fix for ITS#6647)
2010-11-04 12:13:26 +00:00
Ralf Haferkamp
ccd5b3d52d
Added -VVV to usage output
2010-11-01 15:20:39 +00:00
Ralf Haferkamp
c4d6e40ee1
List static overlays/backends when started with -VVV
2010-11-01 14:51:23 +00:00
Howard Chu
de6dbc981e
ITS#6685 fix result code tag
2010-10-26 00:59:10 +00:00
Ralf Haferkamp
76c611ad42
Removed unused variables
2010-10-19 10:48:21 +00:00
Ralf Haferkamp
02753d1555
ITS#6677 moved one more #endif, addtional fix for previous commit
2010-10-19 10:47:41 +00:00
Howard Chu
2cd0b96158
ITS#6677 move #endif
2010-10-17 01:36:47 +00:00
Pierangelo Masarati
2ec0347152
set rebind proc if needed and bind succeeds (ITS#6665)
2010-10-08 22:42:55 +00:00
Pierangelo Masarati
85369497aa
do not expose control until sssvlv overlay is actually instantiated at least once (ITS#6647)
2010-10-06 08:24:45 +00:00
