Commit Graph

5869 Commits

Author SHA1 Message Date
Kurt Zeilenga
2782b6f46f cleanup 2004-08-27 19:00:15 +00:00
Kurt Zeilenga
6cde4bdeb3 Move LDAP_COMP_MATCH define from ldap.h to slap.h 2004-08-27 18:53:44 +00:00
Luke Howard
410ca3d1a9 Allow mods to be NULL in slapi_int_ldapmods2modifications() 2004-08-27 17:27:09 +00:00
Luke Howard
8c764e8d63 Fix a SLAPI bug where slapd could crash if a preop plugin changed the mods
list and a subsequent plugin aborted the operation -- regardless of the
preop result the frontend must refetch the array of LDAPMods
2004-08-27 17:12:01 +00:00
Sang Seok Lim
78d08a8271 Misc Bug Fix:
- Remove unused variables
- Remove the attribute for component filter test in core.schema
2004-08-26 16:43:28 +00:00
Luke Howard
8d1f26b7b6 Check for opinfo->boi_txn before using it - sometimes it is NULL even if
opinfo isn't
2004-08-26 10:17:53 +00:00
Luke Howard
400458c9c5 Don't use SLAPI_TARGET_DN for group plugins - it is required elsewhere 2004-08-26 10:04:08 +00:00
Luke Howard
739dcf2193 boi_bdb must be set 2004-08-26 05:27:59 +00:00
Luke Howard
563f73b81d backend_compute_output_attr() should use actual computed attribute type
returned by the plugin, rather than that requested by backend_attribute(),
for ACL checking.

They should of course be the same but this is the "correct" approach from
both a security and readability perspective
2004-08-26 05:18:33 +00:00
Luke Howard
815efedff5 Fix "FIXME" in slapi_attr_add_value() - store normalized value as well as
real value
2004-08-26 05:02:21 +00:00
Luke Howard
102cd721ef Extend backend_attribute() to support computed attributes (SLAPI) 2004-08-26 05:02:01 +00:00
Luke Howard
5f6996c8bf Add SLAPI_X_GROUP_TARGET_ENTRY so that group plugin can use target entry 2004-08-26 04:24:29 +00:00
Sang Seok Lim
2af6457771 This patch is for a component filter. please refer ITS#3260 for detail
and "implementing GSER and Component Matching" in ODD 2004.
All codes are #ifdef'd with LDAP_COMP_MATCH.
test031-component-filter works correctly only when the LDAP_COMP_MATCH macro is set.
To disable it, set AC_WITH_COMP_MATCH "no" in "openldap_src/tests/run.in".
2004-08-26 00:06:39 +00:00
Howard Chu
05e7632c30 ITS#3301 fix prev commit, don't fail op on DB_NOTFOUND 2004-08-25 20:53:39 +00:00
Luke Howard
d45b89823f Support pre-operation and post-operations for backend_group()
This allows computed attribute plugins to also provide their attributes to
the ACL engine, for example
2004-08-25 15:20:19 +00:00
Pierangelo Masarati
ba7bb04ed3 check if "rootdn" is defined 2004-08-25 14:29:40 +00:00
Howard Chu
5cba217006 ITS#3301 check for dn2entry failure 2004-08-25 13:55:55 +00:00
Luke Howard
2316461b93 Remove unused variable 2004-08-25 12:31:43 +00:00
Pierangelo Masarati
81b5755364 try with "order by"... 2004-08-25 12:09:05 +00:00
Luke Howard
ea6f5bad65 This patch fixes some subtle interactions between SLAPI and syncrepl. Due to
SLAPI always assigning connection and operation IDs of zero for internal
operations, such operations would cause a stale contextCSN to be returned from
slap_get_commit_csn(). As a result, SLAPI internal updates would be invisible
to replicas until an external update was made. Also, SLAPI internal operations
never called slap_graduate_commit_csn() which leaked pending CSNs.

Also included in this patch is a general cleanup of some of the SLAPI code.

Note that we need to use a separate mutex on conn_nextid to avoid a deadlock
where a post-operation plugin tries to acquire connections_mutex, having locked
the per-connection mutex, while the listener thread tries to acquire the
per-connection mutex (having locked connections_mutex). connection.c needs to
be fixed to acquire mutexes in the same order.
2004-08-25 11:52:55 +00:00
Pierangelo Masarati
e745d15f02 remove cruft 2004-08-25 11:32:47 +00:00
Pierangelo Masarati
53483e012d more definitive improvements; now write operations are consistent; plugged some more leaks/invalid frees; tests are more complete. IBM db2 doesn't pass write test because the entries are written in a different order; need to write a script that sorts the results... 2004-08-25 10:41:13 +00:00
Pierangelo Masarati
752bffb16c write test is almost working for ibmdb2 as well... 2004-08-24 17:08:30 +00:00
Pierangelo Masarati
d25ade71e9 need to perform a select after adds... 2004-08-24 15:37:10 +00:00
Pierangelo Masarati
aae3c074f1 cleanup 2004-08-24 15:16:06 +00:00
Pierangelo Masarati
aaf52b28ff further fixes 2004-08-24 15:01:39 +00:00
Pierangelo Masarati
be3c14e4f4 ready for test... 2004-08-24 11:45:33 +00:00
Pierangelo Masarati
a8674f59d7 fix various issues; line up with new tests 2004-08-24 10:31:02 +00:00
Pierangelo Masarati
00f1c085cf move call to frontend API 2004-08-24 09:29:11 +00:00
Pierangelo Masarati
23cbd59126 - proxy cache erroneously returns the filtering attributes
and the objectClass right after caching, even if not requested,
  while subsequent searches are fine;
- the response callback needs be apended at the end of the
  callback list, otherwise the resulting entries are cached
  before other overlays can alter them
- the callback structure and its contents needs be freed
2004-08-24 09:24:55 +00:00
Pierangelo Masarati
809e623cd9 add paged results support to back-ldap 2004-08-24 09:19:33 +00:00
Luke Howard
4fdefa106f ITS#3297 (double free) 2004-08-24 01:20:49 +00:00
Luke Howard
253f66041f Harmonize bvptr2obj_copy() with values2obj_copy() - ie. don't fail if NULL
is passed in.
2004-08-23 03:59:07 +00:00
Pierangelo Masarati
19ea555ca3 blind update of IBM db2 example data 2004-08-21 09:48:49 +00:00
Pierangelo Masarati
b7c0b9ed7f further improve tests; line-up with code 2004-08-21 09:45:14 +00:00
Pierangelo Masarati
6956e3d483 cleanup previous commit 2004-08-21 09:38:58 +00:00
Pierangelo Masarati
467524ef92 handle referrals correctly; allow to add suffix entry; fix multiple values add bug; cleanup 2004-08-21 09:38:08 +00:00
Jong Hyuk Choi
37db80eadb attrs=*,+ becmoes the default behavior when attrs are not specified in syncrepl definition. When attrs are specified, operational attributes other than objectClass, structuralObjectClass, and entryCSN need to be explicitly specified to be included in the replication content. 2004-08-20 16:26:58 +00:00
Pierangelo Masarati
0ed0cd66bf more on back-sql test 2004-08-20 16:12:49 +00:00
Pierangelo Masarati
f59089b5b0 now PostgreSQL seems to work... 2004-08-20 15:24:39 +00:00
Pierangelo Masarati
930f415673 update of RDBMS data for test031 2004-08-20 14:27:32 +00:00
Pierangelo Masarati
d12fdece77 allow to search for "auxiliary" objectClasses (i.e. those in ldap_entry_objclasses); allow to return all objectClasses including "auxiliary"; various cleanup 2004-08-20 12:06:03 +00:00
Pierangelo Masarati
6b8fd66364 split entry_free in entry_clean ... 2004-08-20 12:01:15 +00:00
Howard Chu
af8cb90ed8 ITS#3289 - add SLAP_AT_DYNAMIC flag for dynamically generated attributes.
Set flag for hasSubordinates and subschemaSubentry. Strip dynamic attributes
before storing entries in syncrepl.
2004-08-19 23:39:45 +00:00
Howard Chu
f2ee179c3f ITS#3291 delay use of slap_known_controls until all configuration is done 2004-08-19 12:10:22 +00:00
Howard Chu
91033d6552 Reworked fix for ITS#3140 - add access parameter to backend_attribute 2004-08-18 17:14:22 +00:00
Howard Chu
d504ae047e More for ITS#3288 be_pcl_mutex fixes 2004-08-18 16:43:19 +00:00
Howard Chu
c7313c09b4 More fixes for prev commit 2004-08-18 15:23:37 +00:00
Howard Chu
3081f2df88 Delete unused be_context_csn_mutex 2004-08-18 10:54:58 +00:00
Howard Chu
77ba70be13 Fix ITS#3288: use be_pcl_mutexp instead of be_pcl_mutex 2004-08-18 10:53:34 +00:00
Howard Chu
77df33a164 Fix crash on modify if userpassword didn't exist yet 2004-08-15 22:23:58 +00:00
Pierangelo Masarati
bde0761a04 should fix ITS#3265 2004-08-12 10:33:49 +00:00
Pierangelo Masarati
05b81e623d cleanup attr flags; provide a helper 2004-08-06 17:29:59 +00:00
Pierangelo Masarati
7760b20f7f fix permissive; cleanup 2004-08-06 16:40:48 +00:00
Pierangelo Masarati
bfb6465533 cleanup 2004-08-06 16:40:15 +00:00
Pierangelo Masarati
41569c5ed7 fix attr_merge() usage; cleanup 2004-08-06 16:39:45 +00:00
Pierangelo Masarati
4297cbaed2 fix attr_merge() usage 2004-08-06 16:38:41 +00:00
Pierangelo Masarati
9300a9415f fix malformed test and var initialization 2004-08-06 16:14:05 +00:00
Pierangelo Masarati
559397c44a allow to compare on hasSubordinates 2004-07-31 10:42:28 +00:00
Jong Hyuk Choi
9978007997 slapadd -i <rid list> fix 2004-07-31 00:03:58 +00:00
Pierangelo Masarati
9dcdeef319 don't recompute userattrs 2004-07-30 17:34:47 +00:00
Pierangelo Masarati
614e5a9de6 make sure sun_path is cleared out before accept() 2004-07-30 09:56:22 +00:00
Pierangelo Masarati
7b4a51cc28 further improve loglevel selection 2004-07-29 12:39:51 +00:00
Pierangelo Masarati
f33b51832a allow to use names to set loglevel 2004-07-29 00:10:03 +00:00
Pierangelo Masarati
7507596ccc minor cleanup 2004-07-28 23:48:08 +00:00
Jong Hyuk Choi
8b5b2e715b should not assert(0) in UUIDValidate 2004-07-28 17:27:52 +00:00
Jong Hyuk Choi
95e56c6243 Patch for ITS#3259 2004-07-28 17:24:54 +00:00
Pierangelo Masarati
d723dbc34b in case of early exit, frontendDB might be uninitialized 2004-07-27 21:15:33 +00:00
Pierangelo Masarati
cd9a9c628d frontend stuff moved into a database structure, essentially to allow overlays to be processed before database selection; passes all tests (ITS#3080) 2004-07-26 21:26:34 +00:00
Pierangelo Masarati
cc60b5ce76 cleanup previous fix; maybe the advanced url parsing funcs should go in some ldap_pvt.h header? 2004-07-26 08:31:01 +00:00
Pierangelo Masarati
9f6f5491fe slightly rework user/operational attributes handling (including fixing a bug in the logic of the previous change to backend_operational()); cleanup; more improvements to slapo-rwm and back-relay 2004-07-25 23:16:40 +00:00
Pierangelo Masarati
392366818e fix ITS#3254 2004-07-25 22:57:52 +00:00
Howard Chu
d9927adf88 Fix ITS#3255, boi_bdb comparisons 2004-07-25 21:10:41 +00:00
Howard Chu
05fd32498d Fix spurious warning for fasttool keyword when running in Server mode 2004-07-25 19:49:24 +00:00
Pierangelo Masarati
075a450b49 cleanup 2004-07-24 17:10:29 +00:00
Pierangelo Masarati
cd7540feee cleanup URI parsing/checking (fixes ITS#3253) 2004-07-24 11:17:03 +00:00
Pierangelo Masarati
a7b55f4f44 assert administrative identity instead of the required one if doing auth check in non-caching mode 2004-07-23 00:11:05 +00:00
Pierangelo Masarati
32d9856fb1 hack to handle cases where o_req_dn = o_req_ndn 2004-07-22 23:48:04 +00:00
Pierangelo Masarati
07f010a01f fix previous fix 2004-07-22 23:03:04 +00:00
Howard Chu
dd7003cf9f Added linearindex option for slapindex. Improves performance when database
size exceeds dbcache size by minimizing cache thrashing.
2004-07-22 22:32:37 +00:00
Howard Chu
f9f22058e7 ITS#3178 add "fasttool" option to disable transaction logging in tool mode 2004-07-22 22:14:35 +00:00
Howard Chu
bff0b64cb3 One more Windows tweak 2004-07-20 21:42:00 +00:00
Howard Chu
39fbae025e Windoes compatibility tweaks 2004-07-20 21:40:33 +00:00
Pierangelo Masarati
52a49e0840 improve manual and make naming contexts uniform; NOTE: backwards compatibility not preserved 2004-07-20 00:46:20 +00:00
Pierangelo Masarati
b29808f4ae cleanup function name in log 2004-07-20 00:32:43 +00:00
Pierangelo Masarati
dbb4593d75 rework passwd_extop to comply with rwm requirements... 2004-07-20 00:22:05 +00:00
Pierangelo Masarati
4c16e67094 minor cleanup 2004-07-19 21:43:03 +00:00
Pierangelo Masarati
1bbdcba854 add {creators|modifiers}Name to all entries 2004-07-19 21:42:11 +00:00
Howard Chu
ebd1832d21 Required by backover.c -r1.22 2004-07-19 20:25:43 +00:00
Howard Chu
e918210fc2 Required by backover.c -r1.22 2004-07-19 20:01:26 +00:00
Pierangelo Masarati
b94d5e17e2 rework op/rs structures to deal with opeartional attributes 2004-07-18 21:44:29 +00:00
Pierangelo Masarati
448e2dcad4 fix empty uniqueMember dn portion (ITS#3247) 2004-07-18 21:40:16 +00:00
Pierangelo Masarati
47415023b4 startup and shutdown backends only if not in dryrun mode 2004-07-18 21:36:39 +00:00
Pierangelo Masarati
5992a9b7e6 dnMatch must be called with valid args 2004-07-18 21:34:01 +00:00
Pierangelo Masarati
256d845f08 helpers for special attribute lists 2004-07-18 21:33:15 +00:00
Howard Chu
a14bda1df4 strptime is unreliable, just parse time ourselves 2004-07-18 18:28:16 +00:00
Howard Chu
26b4758938 Make sure hdb gets signed chars for len comparison 2004-07-18 12:29:52 +00:00
Hallvard Furuseth
af5ab4f196 Add missing format argument for 'unhandled idassert-method' error message. 2004-07-18 07:16:34 +00:00
Hallvard Furuseth
9c9c92a6a4 Fix coredump in slap_sasl_check_authz() due to wrong LDAP_LOG() format string. 2004-07-18 07:14:07 +00:00
Hallvard Furuseth
b81b0216a9 Split string literal to keep it below ANSI C's allowed 509-char limit. 2004-07-18 00:47:35 +00:00
Pierangelo Masarati
6a02b9b4fd don't ask for attributes 2004-07-17 17:06:03 +00:00
Pierangelo Masarati
512a70af47 more cleanup 2004-07-17 15:35:06 +00:00
Pierangelo Masarati
6aca8c16c6 cleanup 2004-07-17 15:15:59 +00:00
Pierangelo Masarati
854863f0b6 normalize authcDN (ITS#3246); don't touch databases when running slapadd in dryryn mode (ITS#3244); release lock when acquiring entry in tool mode (ITS#3245) 2004-07-17 14:45:07 +00:00
Pierangelo Masarati
5a32683d02 to be safe, always start backends and database 2004-07-16 16:42:57 +00:00
Pierangelo Masarati
dc5f95cd3e uninitialized var 2004-07-14 08:18:26 +00:00
Pierangelo Masarati
02c5b51717 cleanup; fix loop 2004-07-14 01:34:46 +00:00
Pierangelo Masarati
56303ce55a cleanup 2004-07-14 01:16:23 +00:00
Pierangelo Masarati
922a7e4488 cleanup; plug potential leak? 2004-07-14 01:10:35 +00:00
Pierangelo Masarati
d02a8cab65 revert previous change; anticipate backend_operational before overlays callbacks (thanks, Howard); rework overlays cycle to allow callbacks to free themselves (thanks Howard) 2004-07-14 00:42:23 +00:00
Pierangelo Masarati
8d03d74bfd silence warning 2004-07-14 00:22:27 +00:00
Pierangelo Masarati
3b8111f1c4 use a separate field for a modified entry in SlapReply 2004-07-13 22:52:54 +00:00
Pierangelo Masarati
89b284eef5 more on AttributeDescription error messages 2004-07-13 22:49:50 +00:00
Pierangelo Masarati
d58055b7de swap overlay and internal cleanup 2004-07-13 22:00:28 +00:00
Pierangelo Masarati
d6e3c93001 memory hanling cleanup 2004-07-13 01:00:48 +00:00
Pierangelo Masarati
7011c4f3e2 change flags only if entry massaging goes fine 2004-07-12 22:50:34 +00:00
Pierangelo Masarati
f4a428d060 cleanup 2004-07-12 22:33:44 +00:00
Howard Chu
2954a90483 Add backend_startup_one() 2004-07-12 20:27:33 +00:00
Howard Chu
856a8c1177 Don't bother logging lock failures for tryOnly mode 2004-07-12 20:02:24 +00:00
Howard Chu
3fd4d04168 Release cache locker on db close 2004-07-12 14:29:13 +00:00
Howard Chu
214d3b26c1 Fix for non-thread run 2004-07-12 04:05:26 +00:00
Pierangelo Masarati
22bd2667ce mostly done... 2004-07-11 22:57:51 +00:00
Pierangelo Masarati
1b85d17afe minor cleanup 2004-07-11 22:55:57 +00:00
Pierangelo Masarati
4424b9d57f log what backend is starting (bdb/hdb) 2004-07-11 22:52:26 +00:00
Pierangelo Masarati
198b34db35 back-relay doesn't like this 2004-07-11 22:52:01 +00:00
Howard Chu
2d4f58bbf6 Make sure DB result codes are returned to caller; add missing retries to
callers of bdb_cache_find_id().
2004-07-10 19:06:20 +00:00
Howard Chu
3dedb0839c Remove redundant code from previous patch 2004-07-10 18:26:05 +00:00
Pierangelo Masarati
7679f37b1d fix previous commit (needs work) 2004-07-10 15:15:01 +00:00
Pierangelo Masarati
8a9c5bb0f8 make sure we only get here when everything is fine 2004-07-10 11:41:28 +00:00
Pierangelo Masarati
1c2759e689 cache backend was not started up 2004-07-10 11:37:48 +00:00
Howard Chu
22f895a4bb Minor cleanup 2004-07-10 04:48:07 +00:00
Howard Chu
d6c68cdf48 Fix prev commit 2004-07-09 17:44:50 +00:00
Howard Chu
e5ffb0c466 Use previously unused Backend->be_context_csn 2004-07-09 17:27:23 +00:00
Howard Chu
ebc8bb0d83 Use long-lived per-thread TXNs for loading entries from DB.
Make sure only one thread tries to load a given entry at a time.
Bump up the DB environment's max TXNs to accomodate the new TXNs.
2004-07-09 17:00:07 +00:00
Ralf Haferkamp
b8113c5df9 ITS#3226: Clear attribute flags after schema_check failed 2004-07-09 11:18:42 +00:00
Jong Hyuk Choi
70314bd98b SLAP_IDL_CACHE macro removed 2004-07-09 03:31:52 +00:00
Pierangelo Masarati
2afdce8334 cleanup AD stuff (ITS#3225) 2004-07-09 00:14:15 +00:00
Pierangelo Masarati
3c7a3f78dd further improve error log clarity 2004-07-07 23:01:22 +00:00
Pierangelo Masarati
81d89ddd63 validate/pretty before normalizing... (ITS#3218) 2004-07-06 22:02:52 +00:00
Kurt Zeilenga
36e75e10af reverse last commit 2004-07-05 21:45:01 +00:00
Kurt Zeilenga
35cbe6fe84 fix typos in last commit 2004-07-05 21:44:12 +00:00
Kurt Zeilenga
191941c2cf better ssf related error messages
cleanup
2004-07-05 21:41:10 +00:00
Howard Chu
6b59008f26 Plug mem leaks 2004-07-05 21:00:09 +00:00
Howard Chu
5ab38cfa5f Better fix for ITS#3213, plug mem leaks. Also fix postread response. 2004-07-05 20:08:20 +00:00
Pierangelo Masarati
277d921945 clear shared connections when ldap_result fails with -1 (typically, remote server is down); fixes ITS#3217 2004-07-04 23:35:18 +00:00
Howard Chu
c3984d9f59 Plug memleak from ITS#2895 2004-07-04 04:56:36 +00:00
Howard Chu
56103a575b Fix misplaced unlock in prev commit 2004-07-03 21:06:34 +00:00
Howard Chu
473b8cb7db Re-order EntryInfo/DB locks to fix deadlocks 2004-07-03 20:03:14 +00:00
Howard Chu
42e0814247 Fix prev commit 2004-07-03 16:17:54 +00:00
Howard Chu
f696f7ab55 Fix: LRU corruption, HDB rename detection, Ctxcsn assert failure 2004-07-03 15:47:44 +00:00