Pierangelo Masarati
5d9baf3e85
use (noncritical) whoami extop during SASL bind (ITS#6817)
2011-02-03 23:35:56 +00:00
Pierangelo Masarati
ddbcb565d4
use (noncritical) authzid control during SASL bind (ITS#6817)
2011-02-03 23:20:15 +00:00
Howard Chu
cfd29403c0
Just use back-sock OID arc for overlay
2011-02-03 21:54:11 +00:00
Howard Chu
bef7970e8b
As an overlay, always return SLAP_CB_CONTINUE
2011-02-03 21:34:45 +00:00
Howard Chu
d678a83720
Add response message for overlays
2011-02-03 21:24:26 +00:00
Howard Chu
9ca9459ece
More for overlay use, add connid extension
2011-02-03 20:47:38 +00:00
Howard Chu
8ab45884e3
Add overlay wrapper, use for triggers etc.
2011-02-03 20:17:23 +00:00
Pierangelo Masarati
fb2092328c
do not set c_authz_backend unless needed (ITS#6824, thanks to Howard)
2011-02-03 20:04:56 +00:00
Howard Chu
14b7b19c0d
ITS#6821 make sure objectclass is processed before other mods
2011-02-03 00:15:09 +00:00
Hallvard Furuseth
4225acc07a
Revert last ITS#6532 commit, it is incomplete.
...
Needs better MUTATION support in filter.c first.
2011-02-02 23:28:42 +00:00
Hallvard Furuseth
b508c611a6
More ITS#6532: Support (:UUIDOrderingMatch:=foo)
2011-02-02 23:15:17 +00:00
Hallvard Furuseth
e74964d51b
More ITS#6532: Support (:csnOrderingMatch:=foo)
2011-02-02 22:24:39 +00:00
Pierangelo Masarati
4e3eac93f7
prefix undef attrs with undef: (ITS#6823)
2011-02-02 21:45:34 +00:00
Howard Chu
e72c093a55
ITS#6711 minimal tweaks for aclbind/idassertbind for privileged connection
...
in dobind_int().
2011-02-02 20:56:58 +00:00
Howard Chu
d626977848
Cleanup priv/idassert choice: check for configured bind method, not authcDN
2011-02-02 20:32:48 +00:00
Howard Chu
aec5adac17
ITS#6711 use idassert TLS conf for priv connection if aclbind not set
2011-02-02 20:06:28 +00:00
Ralf Haferkamp
c9e49778f4
ITS#6822 fix back-config's default ACL when overlays are in place
2011-02-02 19:56:08 +00:00
Pierangelo Masarati
e4fcc294fa
ignore attrs in search request that do not conform to RFC 4511 4.5.1.8. or standard track extensions (ITS#6819)
2011-02-01 23:13:58 +00:00
Pierangelo Masarati
15c8ad1f46
make sure data is reset
2011-02-01 22:58:41 +00:00
Howard Chu
6059ffaa00
Use larger key buffer
2011-02-01 21:24:38 +00:00
Howard Chu
acf502d99d
ITS#6806 fix uninit'd NA.txn
2011-02-01 21:21:31 +00:00
Pierangelo Masarati
aef310e4d8
do not return void (ITS#6820)
2011-02-01 17:49:27 +00:00
Pierangelo Masarati
75e3a1931d
ignore empty attrs in search requests (ITS#6819; see also ITS#6652)
2011-02-01 13:09:11 +00:00
Pierangelo Masarati
293b5e51a5
first cut at SASL bind issues in idassert (related to ITS#6817)
2011-01-31 22:07:04 +00:00
Pierangelo Masarati
67a9ef8c33
give the caller a chance to use undefined filters (more about ITS#6814)
2011-01-31 21:53:56 +00:00
Pierangelo Masarati
6d35c255d3
do not cause f_result to override undefined ava
2011-01-31 21:33:54 +00:00
Pierangelo Masarati
539a6902de
do not denormalize attrs without equality rule (ITS#6818)
2011-01-31 21:20:33 +00:00
Hallvard Furuseth
4064e3c15d
Re-fix ITS#6793 (back-ldap bad free of matchedDN).
...
Previous fix opened for a ITS#6758-style double free if the
caller was broken. Using REP_MATCHED_MUSTBEFREED is more robust.
2011-01-31 05:30:05 +00:00
Pierangelo Masarati
36d0a161ab
also handle RFC 4526 t-f filters in back-ldap (more about ITS#6814)
2011-01-29 14:23:53 +00:00
Pierangelo Masarati
4acb60f808
also handle RFC 4526 t-f filters in back-ldap (more about ITS#6814)
2011-01-29 14:16:02 +00:00
Pierangelo Masarati
b996c17eb2
handle undefined filters in back-ldap (more about ITS#6814)
2011-01-29 12:29:20 +00:00
Pierangelo Masarati
8fcc9b058b
handle undefined objectClass values in search filters (ITS#6814)
2011-01-29 10:30:17 +00:00
Howard Chu
3f28eeb797
ITS#6812 cleanup error codes
2011-01-29 03:30:22 +00:00
Howard Chu
20e7176183
More for ITS#6807, make sure to check_syncprov() after initial startup
2011-01-28 22:01:18 +00:00
Hallvard Furuseth
42cb7f06f1
cleanup: Rename rs_ensure_entry_modifiable().
...
The name rs_entry2modifiable() is more reasonably sized.
For now, leave behind a macro rs_ensure_entry_modifiable in proto-slap.h.
2011-01-28 16:33:55 +00:00
Howard Chu
36563721bc
Fix a couple FIXMEs: use ldif_put to allow for binary values in
...
compare and modify. Note that line wrapping is disabled; presumably
existing code expects the compare argument to use only a single line.
The manpage should be updated to note whether standard LDIF with
default line wrapping is expected or not. (Add uses default width already.)
2011-01-28 09:40:52 +00:00
Howard Chu
0a96599375
ITS#6809 add missing newline
2011-01-28 09:11:18 +00:00
Pierangelo Masarati
2a513ad623
cleanup monitor unregister (ITS#6808)
2011-01-27 22:27:22 +00:00
Howard Chu
2d37632286
ITS#6807 always use complete cookie on refresh requests
2011-01-27 20:50:08 +00:00
Howard Chu
68081c5a24
ITS#6804 fix ACL_RECORD_VALUE_STATE macro, was skipping past the ACL
...
instead of resuming from the intended one
2011-01-27 00:50:26 +00:00
Pierangelo Masarati
34a21b7f40
add support for subtree-include (ITS#6801); improve support for subtree-exclude
2011-01-22 15:47:37 +00:00
Ralf Haferkamp
35c2869e44
ITS#6794 Fixed slapadd -q for glued databases
...
Cleanup memory/threads more thoroughly in bdb_tool_entry_close() so that a
subsequent bdb_tool_entry_open() (e.g. for a glued database) can setup
things correctly again.
2011-01-21 17:11:21 +00:00
Hallvard Furuseth
a67100a7c1
ITS#6758 whitespace fix for rev 1.350
2011-01-21 12:09:47 +00:00
Hallvard Furuseth
ecc19f03a0
ITS#6758 Remove comment; broken rs.sr_type idea
2011-01-21 11:43:20 +00:00
Hallvard Furuseth
fb6aa52870
Support $NO_RS_ASSERT. Add comments.
...
Use a private rs_assert_() helper function instead of libc assert.
2011-01-21 11:41:45 +00:00
Hallvard Furuseth
2396759291
ITS#6758 Support rs_reinit(rs, rs->sr_type).
...
rs_reinit() looks like a function call, so it should act like one.
2011-01-21 11:23:00 +00:00
Howard Chu
d3b09ef2a9
ITS#5421 drop ldap-int.h
2011-01-19 21:27:16 +00:00
Pierangelo Masarati
f62b4a55c1
fix and improve candidate selection (ITS#6799)
2011-01-19 17:36:35 +00:00
Pierangelo Masarati
d829953dd0
empty query UUID means negative caching (ITS#6796)
2011-01-18 20:44:45 +00:00
Pierangelo Masarati
c4bdb76de0
count attr values; don't free dangling pointers (ITS#6797)
2011-01-18 20:33:12 +00:00
Howard Chu
4c1464f3cd
ITS#6795 plug sr_ctrls memleak
2011-01-18 02:24:35 +00:00
Pierangelo Masarati
85ba0b81ed
fix previous commit
2011-01-17 15:06:11 +00:00
Pierangelo Masarati
3c82ea09c7
make sure rwm_response returns SLAP_CB_CONTINUE (ITS#6792, as indicated by Hallvard)
2011-01-17 13:15:28 +00:00
Hallvard Furuseth
3866da50f5
ITS#6793 Fix back-ldap bad free on matchedDN change
2011-01-17 10:55:41 +00:00
Howard Chu
e3f344bcbd
ITS#6717 refine mincsn check for MMR
2011-01-13 22:45:59 +00:00
Howard Chu
7da903a11d
ITS#6716 partial revert, initialize sl_mincsn at db_open
2011-01-13 22:23:05 +00:00
Howard Chu
85532fc8c7
More cleanup
2011-01-13 02:23:04 +00:00
Howard Chu
9f692a8168
ITS#6787 release entry locks before sending entries
2011-01-13 01:11:08 +00:00
Howard Chu
afa4a82747
Fix typo
2011-01-12 22:54:58 +00:00
Howard Chu
b8cf299007
Minor cleanup
2011-01-12 22:53:43 +00:00
Howard Chu
62ee62c0b0
More for prev commit
2011-01-12 22:48:30 +00:00
Howard Chu
758c6e4dc9
ITS#6783 fix abandon processing, cleanup
2011-01-12 22:28:46 +00:00
Hallvard Furuseth
1ecaeb3b18
noop change: Silence signed vs unsigned warnings
2011-01-12 14:44:03 +00:00
Hallvard Furuseth
6223282235
Catch ber_scanf errors properly
2011-01-12 14:41:33 +00:00
Howard Chu
5ece155e14
More for #6503
2011-01-06 22:46:08 +00:00
Howard Chu
d4523d3142
ITS#6503 - record Adds in sessionlog too, to avoid excessive present phases
2011-01-06 22:37:23 +00:00
Kurt Zeilenga
966cef8c9a
Happy New Year
2011-01-05 00:42:37 +00:00
Pierangelo Masarati
fc6bd40dfc
make sure matched is NULL when err=SUCCESS (ITS#6774)
2011-01-04 18:27:02 +00:00
Pierangelo Masarati
8fcd55bdc0
no need for next control
2011-01-04 16:17:24 +00:00
Pierangelo Masarati
2b44bc5bf6
typo in error message
2011-01-04 16:16:59 +00:00
Hallvard Furuseth
eae5e37ebd
Set sr_type=REP_SEARCH before be_operational
2011-01-04 15:12:45 +00:00
Hallvard Furuseth
a8c8ec5d4c
ITS#6758 config_back_add: Don't set sr_text if compareTrue
2011-01-04 15:02:52 +00:00
Quanah Gibson-Mount
ed620b9ed3
s/producer/provider
2011-01-04 01:31:30 +00:00
Pierangelo Masarati
1a56a1934a
quick fix for vc: allow custom controls tag
2011-01-04 00:09:10 +00:00
Pierangelo Masarati
342980d116
use Paged Results when talking to targets (in response to ITS#6664)
2011-01-03 17:52:55 +00:00
Pierangelo Masarati
53343b421c
force the generation of a new CSN (ITS#6766)
2011-01-03 00:04:53 +00:00
Pierangelo Masarati
ab4eb5e673
skip operations when internal
2011-01-02 23:36:30 +00:00
Pierangelo Masarati
d562608e40
memberof handling of rename (ITS#6700)
2011-01-02 23:03:13 +00:00
Pierangelo Masarati
7c77d9b801
fix control value generation (ITS#6652)
2011-01-02 17:19:14 +00:00
Pierangelo Masarati
0a12ea91df
hex digits need to be in pairs (ITS#6652)
2011-01-02 15:58:48 +00:00
Pierangelo Masarati
cddaeff565
fix reqControls validator (partially addresses ITS#6652)
2011-01-02 15:50:00 +00:00
Pierangelo Masarati
b672d8535d
make sure initialization is only tried once; improve error messages
2011-01-02 15:06:11 +00:00
Pierangelo Masarati
f2df9f0cf5
add some logging (under TRACE)
2011-01-02 12:29:19 +00:00
Pierangelo Masarati
5c8d655bbb
quick fix for null DN
2011-01-02 02:15:21 +00:00
Hallvard Furuseth
bdb078a778
ITS#6758 Reset dangerous REP_ENTRY_* flags.
...
If SlapReply.sr_un cannot contain an entry but does or soon may
contain another member than sru_search: Ensure nothing will see
leftover REP_ENTRY_* flags and try to clean up the "entry" there.
2010-12-31 20:53:17 +00:00
Hallvard Furuseth
b26c767ed6
ITS#6758 slap.h: Cast REP_* #defines to slap_mask_t
2010-12-31 20:02:41 +00:00
Hallvard Furuseth
9467059b0b
ITS#6758 fix/add slap_send_search_entry() comments
2010-12-31 19:57:53 +00:00
Hallvard Furuseth
a4c2d54127
ITS#6758 result.c:Use rs_*(). Frees entries earlier.
...
For readability, use rs_flush_entry() where slap_send_search_entry() and
slap_send_search_reference() release entries before network operations.
This change also frees entires marked MUSTBEFREED earlier.
2010-12-31 18:14:31 +00:00
Hallvard Furuseth
f4a3304477
ITS#6758 Use rs_*() to manage SlapReply entries.
...
Some noop changes + fixes entry leaks and REP_ENTRY_MODIFIABLE flag leaks.
2010-12-31 17:55:36 +00:00
Hallvard Furuseth
15aa7c472a
noop commit: cleanup 0 -> REP_RESULT in SlapReply
2010-12-31 14:08:34 +00:00
Hallvard Furuseth
713886ec07
ITS#6758, pcache.c: Avoid SlapReply reuse.
...
refresh_merge(): Do not reuse Search SlapReply parameter for a Modify,
use a local one and copy its sr_err to the parameter. The parameter is
from refresh_query(). Move its SlapReply parameter to a local variable.
2010-12-31 13:46:48 +00:00
Hallvard Furuseth
6d7c1880a8
ITS#6758 Avoid SlapReply reuse.
...
Caller provides a SlapReply and reads the result after the operation,
then reuses it. Reinitialize before reuse, or move declaration inwards.
2010-12-31 13:08:11 +00:00
Hallvard Furuseth
04f8fa5619
ITS#6760: Fix rwm entry handling
2010-12-31 12:01:03 +00:00
Hallvard Furuseth
13f52646b2
ITS#6758 Avoid SlapReply reuse, simple cases.
...
Caller provides and reuses a SlapReply it does not read after
initialization. So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().
2010-12-31 10:46:22 +00:00
Hallvard Furuseth
cb15a4c687
ITS#6758 rs_reinit() += slap_reply_t parameter
2010-12-31 09:45:16 +00:00
Hallvard Furuseth
b120b2a05b
ITS#6758 config_build_entry, avoid SlapReply reuse
...
Do not use the 'SlapReply *rs' passed to config_build_entry(). Instead
pass a new one to op->o_bd->be_add() and copy the output sr_err to rs.
This takes care of most SlapReply reuse in bconfig.c.
2010-12-31 09:02:34 +00:00
Hallvard Furuseth
ab1bc728fa
ITS#6758 bconfig.c: ensure sr_text==NULL if sr_err==LDAP_SUCCESS
...
config_modify_internal(): Do not send rs->sr_text with success.
config_back_modify(): When slap_bv2ad() can set rs->sr_text,
set sr->sr_err too and catch failure.
2010-12-31 08:45:48 +00:00
Howard Chu
089cf2d421
ITS#6670 partial fix - ignore member/memberof pointing to same entry
2010-12-31 01:38:24 +00:00
Hallvard Furuseth
abf7f2efce
ITS#6758 back-bdb: Delay setting sr->sr_entry until we know it will be used
2010-12-31 00:04:38 +00:00
Hallvard Furuseth
1ea8de9fda
ITS#6758 Do not set sr_err=error before be_search.
...
glue_op_search() set LDAP_UNWILLING_TO_PERFORM before be_search() as
well as when there was no be_search.
2010-12-30 23:59:23 +00:00
Hallvard Furuseth
d2b024be4a
ITS#6758 Reset some SlapReply flags & data.
...
Reset data more consistenlty. When resetting sr_entry after sending
data, reset sr_flag as well. Reset rs_attrs and Extended Operation
oid/data after setting and sending them.
2010-12-30 23:55:07 +00:00
Hallvard Furuseth
f7a77545ad
noop commit for ITS#6758: simplify future commits
2010-12-30 23:48:41 +00:00
Hallvard Furuseth
98966abeef
noop commit for ITS#6758: Remove no-effect code.
...
Unused variable resets, unused SlapReply parameters to some functions.
2010-12-30 23:43:12 +00:00
Hallvard Furuseth
cd6e9156e7
Remove lint (unused vars/labels/funcs/default:s)
2010-12-30 23:34:55 +00:00
Hallvard Furuseth
5c3f806fca
ITS#6758 Add rs_reinit(), rs_flush_entry()
2010-12-30 23:32:07 +00:00
Hallvard Furuseth
ea2b675dca
ITS#6758 Add rs_assert*, RS_ASSERT, USE_RS_ASSERT
2010-12-30 23:29:46 +00:00
Hallvard Furuseth
c9e85af35c
ITS#6759: assert;Debug -> Debug;assert
2010-12-30 23:19:02 +00:00
Pierangelo Masarati
7443e6fc8c
op->o_conn->c_sb may be 0 for internal operations
2010-12-30 21:41:07 +00:00
Rein Tollevik
a1a5affeb0
ITS#6754: Fail if there are unrecognized command-line arguments.
2010-12-30 19:45:08 +00:00
Howard Chu
97d9b07814
ITS#5862 Assert control for rootDSE/subschema
2010-12-30 17:28:19 +00:00
Hallvard Furuseth
027b6812ee
ITS#6686 Fix last commit (declaration after code)
2010-12-28 15:59:48 +00:00
Howard Chu
e907ba219b
ITS#6686 add multiple sorts per connection, from Raphael Ouazana @ Linagora
2010-12-23 22:29:57 +00:00
Howard Chu
56888eac30
Move assertion checking to slap_compare_entry()
2010-12-23 21:53:05 +00:00
Howard Chu
9bb47f74ae
ITS#6753 use slap_compare_entry()
2010-12-23 21:45:36 +00:00
Howard Chu
149313fd25
ITS#6573 export compare_entry as slap_compare_entry()
2010-12-23 21:36:57 +00:00
Howard Chu
0393fe8974
Cleanup for #6660
2010-12-23 04:40:57 +00:00
Howard Chu
f58a646ad6
ITS#6660 preliminary fix. debug additions need to be cleaned up.
2010-12-23 00:16:19 +00:00
Hallvard Furuseth
720aa4b77e
Plug mutex/rwlock leaks (destroy them)
2010-12-20 10:57:06 +00:00
Hallvard Furuseth
78a0be6a42
Plug memory leaks
2010-12-20 10:51:14 +00:00
Hallvard Furuseth
9e6331f14f
ITS#6752 Remove OpenLDAP 2.[23] dynlist code
2010-12-20 10:25:11 +00:00
Hallvard Furuseth
e7df2ef95f
ITS#6752 Handle REP_ENTRY_* flags correctly
2010-12-20 10:22:19 +00:00
Hallvard Furuseth
42a0f5efc2
ITS#6752 Fix dynlist Compare callback
...
Replace dynlist_sc_save_entry() with dynlist_sc_compare_entry() which
compares instead of saves the entry. Check rs->sr_type == REP_SEARCH.
2010-12-20 10:20:38 +00:00
Hallvard Furuseth
abbf57fd79
ITS#6752 dynlist: Do less work, simplify a bit.
...
Rearrange dynlist_compare(), tweak dynlist_response().
2010-12-20 10:19:21 +00:00
Hallvard Furuseth
2a9c5154ef
ITS#6748 Drop possibly-broken memberof log message
2010-12-14 15:26:42 +00:00
Hallvard Furuseth
5feeec67d7
ITS#6747 Fix LDAP_CONNECTIONLESS Debug(), warnings
2010-12-14 15:06:32 +00:00
Hallvard Furuseth
0aa8c028b3
ITS#6746: Preserve error code, plug entry leak
2010-12-14 13:35:42 +00:00
Rein Tollevik
b4aa8dc68c
ITS#6716: Keep sessionlog sorted by csn, compare mincsn with head.
2010-12-12 18:12:05 +00:00
Pierangelo Masarati
351bc07fcc
re-fix ITS#6645 commit
2010-12-07 11:58:38 +00:00
Pierangelo Masarati
615d1c7703
fix ITS#6645 commit
2010-12-07 11:55:27 +00:00
Pierangelo Masarati
15f1e7bdb7
move ctxcsn and schema check code in helpers; also apply to slapmodify (ITS#6737)
2010-12-07 10:50:54 +00:00
Pierangelo Masarati
dc156d7f6e
allow to set LDIF max line width (ITS#6645)
2010-12-07 10:14:51 +00:00
Hallvard Furuseth
87a9ee9e83
For ITS#6739: Fix last commit (private debuging)
2010-12-06 09:27:30 +00:00
Hallvard Furuseth
5fc18b9d66
For ITS#6739: Move variables into do_syncrep2 loop
2010-12-06 09:23:44 +00:00
Hallvard Furuseth
a5d1029f53
ITS#6736: Delay destruction of slap_listeners[]
2010-12-06 08:17:00 +00:00
Hallvard Furuseth
6be3671985
Fix rev 1.132 (ITS#6632): Initialize all of roc in rwm_callback_get()
2010-12-03 10:08:59 +00:00
Hallvard Furuseth
50b1c4e1b1
ITS#6620: Don't delete absent pwdChangedTime.
...
Based on patch by Martin Evans.
2010-12-02 12:19:31 +00:00
Hallvard Furuseth
4ed4c3a28f
ITS#6731: Fix scrambled back-ldif error strings.
...
* Move apply_modify_to_entry():textbuf[] into caller.
* Reset rs->sr_text at end of functions that can set it to textbuf.
2010-12-02 10:24:19 +00:00
Hallvard Furuseth
3d48d5a360
ITS#6730: Only update modifiersName once per entry
2010-12-01 11:21:29 +00:00
Hallvard Furuseth
a36512660f
ITS#6730: Fix missing refint updates with subtrees/subordinates
2010-12-01 11:19:17 +00:00
Hallvard Furuseth
9a9302a2f5
ITS#6663: Fix refint_nothing.
...
Also move callback trace output out of inner loop in callback.
2010-12-01 10:48:43 +00:00
Pierangelo Masarati
bce526a8cf
test slap_dontUseCopy_propnames (ITS#6729)
2010-12-01 10:41:05 +00:00
Pierangelo Masarati
fa4dbb871b
fix double free related to ITS#6720
2010-11-29 16:03:43 +00:00
Hallvard Furuseth
c9a63dc01a
Fix a comment
2010-11-28 18:20:54 +00:00
Hallvard Furuseth
f23fb051d5
Add/fix comments. No other change.
2010-11-28 18:04:22 +00:00
Hallvard Furuseth
5f2af361ba
ITS#6532 Support extensible match=...OrderingMatch
...
Handles: caseExactOrderingMatch, generalizedTimeOrderingMatch,
caseIgnoreOrderingMatch, integerOrderingMatch,
octetStringOrderingMatch, numericStringOrderingMatch.
Based on patch from Daniel Pluta.
2010-11-24 13:10:29 +00:00
Hallvard Furuseth
def5d26f13
ITS#6722: Fix some matching rules to ensure strict ordering
...
booleanMatch, octetStringMatch, octetStringOrderingMatch, uniqueMemberMatch
2010-11-23 11:17:40 +00:00
Hallvard Furuseth
4484781b0d
ITS#6721: Fix uninitialized tv_usec from ITS#6282
2010-11-23 10:10:45 +00:00
Hallvard Furuseth
0ab060091e
Silence gcc -Wsign-compare (no real change)
2010-11-22 13:45:11 +00:00
Hallvard Furuseth
e1469fff44
For ITS#5421: Also LBER_FREE() -> ber_memfree()
2010-11-22 13:14:29 +00:00
Hallvard Furuseth
b39e9d151d
For ITS#5421: Remove ldap-int.h dependencies.
...
LDAP_FREE() -> ber_memfree(), msg->lm_ber -> ldap_get_message_ber(msg).
2010-11-22 12:51:44 +00:00