Commit Graph

1388 Commits

Author SHA1 Message Date
Pierangelo Masarati
15c8ad1f46 make sure data is reset 2011-02-01 22:58:41 +00:00
Pierangelo Masarati
75e3a1931d ignore empty attrs in search requests (ITS#6819; see also ITS#6652) 2011-02-01 13:09:11 +00:00
Pierangelo Masarati
67a9ef8c33 give the caller a chance to use undefined filters (more about ITS#6814) 2011-01-31 21:53:56 +00:00
Howard Chu
3f28eeb797 ITS#6812 cleanup error codes 2011-01-29 03:30:22 +00:00
Hallvard Furuseth
42cb7f06f1 cleanup: Rename rs_ensure_entry_modifiable().
The name rs_entry2modifiable() is more reasonably sized.
For now, leave behind a macro rs_ensure_entry_modifiable in proto-slap.h.
2011-01-28 16:33:55 +00:00
Pierangelo Masarati
2a513ad623 cleanup monitor unregister (ITS#6808) 2011-01-27 22:27:22 +00:00
Pierangelo Masarati
d829953dd0 empty query UUID means negative caching (ITS#6796) 2011-01-18 20:44:45 +00:00
Pierangelo Masarati
c4bdb76de0 count attr values; don't free dangling pointers (ITS#6797) 2011-01-18 20:33:12 +00:00
Howard Chu
4c1464f3cd ITS#6795 plug sr_ctrls memleak 2011-01-18 02:24:35 +00:00
Pierangelo Masarati
85ba0b81ed fix previous commit 2011-01-17 15:06:11 +00:00
Pierangelo Masarati
3c82ea09c7 make sure rwm_response returns SLAP_CB_CONTINUE (ITS#6792, as indicated by Hallvard) 2011-01-17 13:15:28 +00:00
Howard Chu
e3f344bcbd ITS#6717 refine mincsn check for MMR 2011-01-13 22:45:59 +00:00
Howard Chu
7da903a11d ITS#6716 partial revert, initialize sl_mincsn at db_open 2011-01-13 22:23:05 +00:00
Hallvard Furuseth
1ecaeb3b18 noop change: Silence signed vs unsigned warnings 2011-01-12 14:44:03 +00:00
Howard Chu
5ece155e14 More for #6503 2011-01-06 22:46:08 +00:00
Howard Chu
d4523d3142 ITS#6503 - record Adds in sessionlog too, to avoid excessive present phases 2011-01-06 22:37:23 +00:00
Kurt Zeilenga
966cef8c9a Happy New Year 2011-01-05 00:42:37 +00:00
Pierangelo Masarati
53343b421c force the generation of a new CSN (ITS#6766) 2011-01-03 00:04:53 +00:00
Pierangelo Masarati
ab4eb5e673 skip operations when internal 2011-01-02 23:36:30 +00:00
Pierangelo Masarati
d562608e40 memberof handling of rename (ITS#6700) 2011-01-02 23:03:13 +00:00
Pierangelo Masarati
7c77d9b801 fix control value generation (ITS#6652) 2011-01-02 17:19:14 +00:00
Pierangelo Masarati
0a12ea91df hex digits need to be in pairs (ITS#6652) 2011-01-02 15:58:48 +00:00
Pierangelo Masarati
cddaeff565 fix reqControls validator (partially addresses ITS#6652) 2011-01-02 15:50:00 +00:00
Hallvard Furuseth
f4a3304477 ITS#6758 Use rs_*() to manage SlapReply entries.
Some noop changes + fixes entry leaks and REP_ENTRY_MODIFIABLE flag leaks.
2010-12-31 17:55:36 +00:00
Hallvard Furuseth
713886ec07 ITS#6758, pcache.c: Avoid SlapReply reuse.
refresh_merge(): Do not reuse Search SlapReply parameter for a Modify,
use a local one and copy its sr_err to the parameter.  The parameter is
from refresh_query().  Move its SlapReply parameter to a local variable.
2010-12-31 13:46:48 +00:00
Hallvard Furuseth
6d7c1880a8 ITS#6758 Avoid SlapReply reuse.
Caller provides a SlapReply and reads the result after the operation,
then reuses it.  Reinitialize before reuse, or move declaration inwards.
2010-12-31 13:08:11 +00:00
Hallvard Furuseth
04f8fa5619 ITS#6760: Fix rwm entry handling 2010-12-31 12:01:03 +00:00
Hallvard Furuseth
13f52646b2 ITS#6758 Avoid SlapReply reuse, simple cases.
Caller provides and reuses a SlapReply it does not read after
initialization.  So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().
2010-12-31 10:46:22 +00:00
Howard Chu
089cf2d421 ITS#6670 partial fix - ignore member/memberof pointing to same entry 2010-12-31 01:38:24 +00:00
Hallvard Furuseth
d2b024be4a ITS#6758 Reset some SlapReply flags & data.
Reset data more consistenlty.  When resetting sr_entry after sending
data, reset sr_flag as well.  Reset rs_attrs and Extended Operation
oid/data after setting and sending them.
2010-12-30 23:55:07 +00:00
Hallvard Furuseth
f7a77545ad noop commit for ITS#6758: simplify future commits 2010-12-30 23:48:41 +00:00
Hallvard Furuseth
98966abeef noop commit for ITS#6758: Remove no-effect code.
Unused variable resets, unused SlapReply parameters to some functions.
2010-12-30 23:43:12 +00:00
Hallvard Furuseth
cd6e9156e7 Remove lint (unused vars/labels/funcs/default:s) 2010-12-30 23:34:55 +00:00
Hallvard Furuseth
027b6812ee ITS#6686 Fix last commit (declaration after code) 2010-12-28 15:59:48 +00:00
Howard Chu
e907ba219b ITS#6686 add multiple sorts per connection, from Raphael Ouazana @ Linagora 2010-12-23 22:29:57 +00:00
Hallvard Furuseth
720aa4b77e Plug mutex/rwlock leaks (destroy them) 2010-12-20 10:57:06 +00:00
Hallvard Furuseth
78a0be6a42 Plug memory leaks 2010-12-20 10:51:14 +00:00
Hallvard Furuseth
9e6331f14f ITS#6752 Remove OpenLDAP 2.[23] dynlist code 2010-12-20 10:25:11 +00:00
Hallvard Furuseth
e7df2ef95f ITS#6752 Handle REP_ENTRY_* flags correctly 2010-12-20 10:22:19 +00:00
Hallvard Furuseth
42a0f5efc2 ITS#6752 Fix dynlist Compare callback
Replace dynlist_sc_save_entry() with dynlist_sc_compare_entry() which
compares instead of saves the entry.  Check rs->sr_type == REP_SEARCH.
2010-12-20 10:20:38 +00:00
Hallvard Furuseth
abbf57fd79 ITS#6752 dynlist: Do less work, simplify a bit.
Rearrange dynlist_compare(), tweak dynlist_response().
2010-12-20 10:19:21 +00:00
Hallvard Furuseth
2a9c5154ef ITS#6748 Drop possibly-broken memberof log message 2010-12-14 15:26:42 +00:00
Hallvard Furuseth
0aa8c028b3 ITS#6746: Preserve error code, plug entry leak 2010-12-14 13:35:42 +00:00
Rein Tollevik
b4aa8dc68c ITS#6716: Keep sessionlog sorted by csn, compare mincsn with head. 2010-12-12 18:12:05 +00:00
Hallvard Furuseth
6be3671985 Fix rev 1.132 (ITS#6632): Initialize all of roc in rwm_callback_get() 2010-12-03 10:08:59 +00:00
Hallvard Furuseth
50b1c4e1b1 ITS#6620: Don't delete absent pwdChangedTime.
Based on patch by Martin Evans.
2010-12-02 12:19:31 +00:00
Hallvard Furuseth
3d48d5a360 ITS#6730: Only update modifiersName once per entry 2010-12-01 11:21:29 +00:00
Hallvard Furuseth
a36512660f ITS#6730: Fix missing refint updates with subtrees/subordinates 2010-12-01 11:19:17 +00:00
Hallvard Furuseth
9a9302a2f5 ITS#6663: Fix refint_nothing.
Also move callback trace output out of inner loop in callback.
2010-12-01 10:48:43 +00:00
Pierangelo Masarati
fa4dbb871b fix double free related to ITS#6720 2010-11-29 16:03:43 +00:00
Hallvard Furuseth
0ab060091e Silence gcc -Wsign-compare (no real change) 2010-11-22 13:45:11 +00:00
Hallvard Furuseth
b39e9d151d For ITS#5421: Remove ldap-int.h dependencies.
LDAP_FREE() -> ber_memfree(), msg->lm_ber -> ldap_get_message_ber(msg).
2010-11-22 12:51:44 +00:00
Rein Tollevik
d3cddce244 ITS#6718: Send NEW_COOKIE messages to all consumers. 2010-11-21 19:00:38 +00:00
Rein Tollevik
990d8f562f ITS#6710: Force clients to refresh if context is dirty. 2010-11-21 17:56:09 +00:00
Rein Tollevik
877fc0ab37 ITS#6709: Wait for active mods to finish before initiating new consumers. 2010-11-21 15:31:38 +00:00
Rein Tollevik
ba86259aa0 ITS#6708: Mutex protect fixing the filter. 2010-11-15 15:42:06 +00:00
Ralf Haferkamp
e1c2a67517 Unregister VLV control as well when last overlay instance
is removed (additional fix for ITS#6647)
2010-11-04 12:13:26 +00:00
Howard Chu
de6dbc981e ITS#6685 fix result code tag 2010-10-26 00:59:10 +00:00
Ralf Haferkamp
76c611ad42 Removed unused variables 2010-10-19 10:48:21 +00:00
Ralf Haferkamp
02753d1555 ITS#6677 moved one more #endif, addtional fix for previous commit 2010-10-19 10:47:41 +00:00
Howard Chu
2cd0b96158 ITS#6677 move #endif 2010-10-17 01:36:47 +00:00
Pierangelo Masarati
85369497aa do not expose control until sssvlv overlay is actually instantiated at least once (ITS#6647) 2010-10-06 08:24:45 +00:00
Pierangelo Masarati
dc78654c0b make sure so is correctly initialized (spotted by valgrind, possibly related to ITS#6649) 2010-09-18 18:27:28 +00:00
Pierangelo Masarati
79d4e4cf6a add support for ADD_IF_NOT_PRESENT and SOFTDEL internal modification types (ITS#6561) 2010-09-07 13:21:20 +00:00
Pierangelo Masarati
c405143a0a ignore undefined attrs (ITS#6600, based on patch by Jonathan CLARKE) 2010-09-07 02:03:23 +00:00
Pierangelo Masarati
c78014bc5d make sure callback is freed (ITS#6640) 2010-09-07 02:01:35 +00:00
Pierangelo Masarati
df2573b4a9 hacks ITS#6632 2010-08-29 08:08:42 +00:00
Howard Chu
a8ffb63331 Better fix - avoid allocating callback for non-logged mod ops 2010-08-04 08:50:29 +00:00
Howard Chu
21d299e370 More for ITS#6608 - don't replicate ppolicy state changes on replicas 2010-08-04 08:14:59 +00:00
Howard Chu
9434a7d676 ITS#6608 don't update mod opattrs on single-master slaves 2010-07-28 02:43:21 +00:00
Howard Chu
7e7f24f13f ITS#6606 send error if consumer is newer than provider 2010-07-28 02:21:27 +00:00
Howard Chu
c7305c4133 Check for SLAP_SYNTAX_DN flag instead of distinguishedName syntax 2010-07-12 03:20:57 +00:00
Ralf Haferkamp
c4f0c2cc2b unregister controls when removing syncprov, ppolicy, valsort, chain or
sssvlv overlay
2010-07-01 11:51:43 +00:00
Ralf Haferkamp
7b2dc4c059 Send error to active psearches upon overlay removal 2010-06-23 16:34:25 +00:00
Howard Chu
9a0e94b4dc More for ITS#6572, fix copy/paste error 2010-06-17 22:05:33 +00:00
Howard Chu
28072167c7 ITS#6572 zero out freed DN vals. from mbackes@symas.com 2010-06-13 18:47:21 +00:00
Howard Chu
c8c3847103 ITS#6566 use Debug, not fprintf(stderr) 2010-06-02 00:18:32 +00:00
Howard Chu
a07d3630cb Quit send loops if slapd is shutting down 2010-05-21 17:47:17 +00:00
Ralf Haferkamp
a06696a1ef During the refresh phase the sync filter needs to be adjusted (skipping
the "(entrycsn>=cookie)" part that was inserted) when checking whether a
change needs to be replicated, otherwise we lose DELETES that happen during
the refresh phase (ITS#6555).
2010-05-20 17:08:28 +00:00
Howard Chu
c45fca65fc Init uninit'd vlv flag 2010-05-18 07:35:12 +00:00
Ralf Haferkamp
5743591419 Reset BackendInfo to original value after checkpoint. Plugs a memory leak
when deleting the syncprov overlay from a database (when compiled with
-DSLAP_CONFIG_DELETE)
2010-04-29 15:47:27 +00:00
Pierangelo Masarati
71a11b44e8 fix memory handling in rewrite parsing (ITS#6526) 2010-04-17 16:29:34 +00:00
Pierangelo Masarati
9d2e03f052 allow to specify a per-database list of attributes that need to be always collected, even if not explicitly requested by clients (addresses ITS#6513) 2010-04-15 05:26:21 +00:00
Pierangelo Masarati
a3a603eca6 malloc as much as possible on slab 2010-04-15 05:11:23 +00:00
Howard Chu
68ce33cd77 ITS#6519 don't replicate purge deletes 2010-04-13 23:28:35 +00:00
Kurt Zeilenga
3dadeb3efe happy belated New Year 2010-04-13 22:17:29 +00:00
Pierangelo Masarati
5564ee0173 don't free before use 2010-04-12 16:24:01 +00:00
Pierangelo Masarati
a6298f97fc keep attrs count consistent (ITS#6508) 2010-04-08 17:24:44 +00:00
Pierangelo Masarati
063c844b2a increment counter (ITS#6497) 2010-03-23 20:33:06 +00:00
Pierangelo Masarati
7ca6247395 check for NULL backend (ITS#6490) 2010-03-22 21:48:25 +00:00
Howard Chu
7cec659d74 Fix prev commit 2010-03-13 21:41:51 +00:00
Howard Chu
968663d6e4 Fix for CB_TAIL with cached results 2010-03-10 22:25:42 +00:00
Howard Chu
e85ca5d49a ITS#6484 don't bypass other overlays' entry_release handler 2010-03-03 23:36:29 +00:00
Howard Chu
f992b66f05 ITS#6484 - cache DB needs to release its own entries 2010-03-02 21:29:32 +00:00
Pierangelo Masarati
3cd65c0a5d reduce code duplication 2010-02-12 08:55:34 +00:00
Ralf Haferkamp
837320eaac plugged one time memory leak (found with valgrind) 2010-01-22 18:01:25 +00:00
Ralf Haferkamp
9e3517595d Plugged memory leak. Syncentry wasn't free'd when sending
LDAP_SYNC_NEW_COOKIE intermediate results. (ITS#6459)
2010-01-21 13:33:21 +00:00
Howard Chu
0c195fc013 ITS#6438 check for redundant syncops_free() ? 2010-01-05 03:50:10 +00:00
Pierangelo Masarati
ade09a57da allow direct insert/delete of olcRwmMap (ITS#6436) 2009-12-21 18:58:21 +00:00
Pierangelo Masarati
0329d982a2 better fix to ITS#6434 (olcRwmMap needs work to allow atomic mods) 2009-12-21 17:32:05 +00:00
Pierangelo Masarati
8ddb160ae8 fix in-database configuration of olcRwmMap (no ITS# yet) 2009-12-20 18:31:08 +00:00
Pierangelo Masarati
85621c882a guard against simultaneous REP_ENTRY_MUSTRELEASE and REP_ENTRY_MODIFIABLE (related to ITS#6423) 2009-12-08 20:53:39 +00:00
Pierangelo Masarati
173873172c guard against simultaneous REP_ENTRY_MUSTRELEASE and REP_ENTRY_MODIFIABLE (ITS#6423) 2009-12-08 19:36:10 +00:00
Pierangelo Masarati
40065adb4d remove REP_ENTRY_MUSTRELEASE when copying (ITS#6423) 2009-12-08 18:47:17 +00:00
Pierangelo Masarati
2c1c200662 log about invalid URI (more about ITS#6421) 2009-12-08 01:34:22 +00:00
Pierangelo Masarati
db852e4378 handle simple filters with no brackets (ITS#6421) 2009-12-08 00:17:25 +00:00
Howard Chu
111b27cfd4 ITS#6270, refix patch from ITS#5511 2009-11-30 06:07:22 +00:00
Hallvard Furuseth
492b2cda2b ITS#6403: reset 'entry' output argument to overlay_entry_get_ov() 2009-11-29 19:53:01 +00:00
Howard Chu
3b2380254a ITS#6400 clarify... 2009-11-24 03:41:24 +00:00
Howard Chu
fae4df1ed6 more for #6397 2009-11-23 22:17:25 +00:00
Howard Chu
e72e0507f8 ITS#6397 cleanup psearch if cookie is stale 2009-11-23 22:13:42 +00:00
Hallvard Furuseth
da747ed63a Fix rev 1.200 commit: C90 forbids mixed declarations and code 2009-11-23 16:04:00 +00:00
Howard Chu
faddd86f54 Revert prev commit, simpler fix... 2009-11-22 17:43:48 +00:00
Pierangelo Masarati
1970251bb7 check result of str2filter; syncrepl: can be broken; retcode: can't; pcache: shouldn't (ITS#6391) 2009-11-22 11:57:17 +00:00
Howard Chu
993fbf4514 Short-circuit backend_operational; sent entry's e_private doesn't belong
to the backend any more
2009-11-22 04:43:34 +00:00
Howard Chu
c365ac359e ITS#6368 use dup'd entries in response queue 2009-11-22 04:42:00 +00:00
Howard Chu
650ebba22b Fix prev commit 2009-11-21 11:54:59 +00:00
Howard Chu
4bdc6fcbc9 in op_response, rearrange contextCSN update checks 2009-11-21 11:43:01 +00:00
Howard Chu
af0d762c1c Mostly revert prev commit, broke test054 2009-11-21 03:38:13 +00:00
Howard Chu
ae5af832db Always log outgoing cookie, just use op->o_csn instead of commit_csn since
all responses are now serialized.
2009-11-21 02:37:53 +00:00
Howard Chu
198cbd6ea8 ITS#6368 partially revert 1.273, always check for skips, not just on
first matchops call
2009-11-19 11:17:53 +00:00
Howard Chu
ddfe3cde10 ITS#6387 plug leaks 2009-11-18 23:58:39 +00:00
Pierangelo Masarati
1ec443df53 trim unnecessary test 2009-11-16 10:02:47 +00:00
Howard Chu
ff98f4abc5 Use fake_init2 in db_open/db_close since they can execute from a
back-config operation (and could wipe out the state otherwise)
2009-11-15 10:38:13 +00:00
Howard Chu
67edd75e48 Cleanup for #6373 2009-11-14 21:53:06 +00:00
Howard Chu
dd2f158b52 Fix prev commit 2009-11-14 09:35:23 +00:00
Howard Chu
fe911c5960 ITS#6376 plug potential leak 2009-11-14 09:34:29 +00:00
Howard Chu
3f9e8eeeec ITS#6373 more for subentry creation 2009-11-11 04:03:27 +00:00
Howard Chu
9ad558b78c ITS#6373 create subentry if missing 2009-11-11 03:36:46 +00:00
Howard Chu
46a97b9204 ITS#6373 sync_use_subentry support 2009-11-11 03:19:01 +00:00
Pierangelo Masarati
17a185b32a unparse checkpoint time in minutes (ITS#6370) 2009-11-10 19:02:33 +00:00
Howard Chu
a3f38ed932 ITS#6346 serialize all responses 2009-10-29 23:46:10 +00:00
Howard Chu
3d189671bd ITS#6310 dup entry before adding to cache 2009-10-24 05:59:39 +00:00
Rein Tollevik
739f8d0753 ITS#6335 Don't reuse a modtarget someone is about to remove 2009-10-16 17:27:18 +00:00
Howard Chu
eefe62b597 Implement policy checks on compare op 2009-10-15 07:11:39 +00:00
Pierangelo Masarati
716eaf0e8b update entryCSN (and operational attrs in general) when changing memberOf (ITS#6329) 2009-10-14 20:35:42 +00:00
Pierangelo Masarati
8bdf89ac6a make sure members are not used uninitialized 2009-10-07 22:44:14 +00:00
Howard Chu
e0cad0e988 ITS#6308 lock leak: must release entry using same op that acquired it 2009-09-29 06:21:32 +00:00
Howard Chu
2e601e8291 ITS#6288 don't deref sort control if it wasn't set 2009-09-29 03:10:03 +00:00
Howard Chu
2d2fca51d2 ITS#6242 need managedsait to replace glue entries with their real values 2009-09-27 22:42:04 +00:00
Pierangelo Masarati
07b7491249 fix LDIF comment when modifying (ITS#6286) 2009-09-08 04:40:24 +00:00
Pierangelo Masarati
e45c20cf92 fix uninitialized var (ITS#6266; actually, the problem was a bit more severe...) 2009-08-24 01:22:55 +00:00
Pierangelo Masarati
9f2360e2a9 fix uninitialized and off-by-one (thanks to valgrind) 2009-08-21 16:01:33 +00:00
Howard Chu
27c39c56c4 ITS#6152 add tests for cache refresh and Bind caching 2009-08-21 13:25:38 +00:00
Howard Chu
6d50de8526 ITS#6152 pwdModify support 2009-08-20 09:47:34 +00:00
Howard Chu
17d31e523f Fix prev commit 2009-08-20 09:46:40 +00:00
Howard Chu
2d28fe4d4c ITS#6265 must set orm_no_opattrs 2009-08-20 00:32:28 +00:00
Howard Chu
acd888b9de child DB should have ordering prefix 2009-08-19 23:46:37 +00:00
Pierangelo Masarati
9f13a2ae02 more cleanup of attr renaming 2009-08-19 23:13:13 +00:00
Pierangelo Masarati
afec8d12ad more cache monitoring (ITS#5178) 2009-08-19 23:09:52 +00:00