Commit Graph

1119 Commits

Author SHA1 Message Date
Howard Chu
7a76ded030 ITS#8321 track temporary cursors
In rebalance/split operations, temporary cursors need to be visible
to propagate fixups
2015-11-23 01:50:03 +00:00
Howard Chu
5c7b84b465 ITS#8321 fix mdb_cursor_put
Ignore sub-cursors that shouldn't be fixed up
2015-11-23 01:49:49 +00:00
Howard Chu
94831f7c3f ITS#8321 fix mdb_cursor_shadow()
Set a valid txn so that cursor fixup code works on the shadows
2015-11-23 01:49:37 +00:00
Howard Chu
0ec3967e1d ITS#8321 fix mdb_cursor_chk()
It was reporting spurious errors due to uninit'd cursors
2015-11-23 01:49:24 +00:00
Howard Chu
8773a08c43 ITS#8321 don't skip fixups on splitting cursors
Adjustments can't be skipped, in recursive calls each level must
fixup their own level.
2015-11-23 01:49:10 +00:00
Howard Chu
91dc62506b ITS#8321 Fix del/dupsort
When deleting a dupsort key, if other cursors pointed at that key,
set them to uninit'd, not EOF. They no longer have anything to
point at.
2015-11-23 01:48:59 +00:00
Howard Chu
94e8009ca4 ITS#8300 more for prev commit
Just tell explicitly which direction we moved/merged from
2015-11-23 01:47:39 +00:00
Howard Chu
ba85adb52d Silence some valgrind uninit warnings 2015-11-23 01:47:39 +00:00
Howard Chu
bfe2088946 Refix root split check from 5da67968af 2015-11-23 01:47:39 +00:00
Oskari Timperi
f13b971960 ITS#7992 assume Windows paths are UTF-8 2015-11-23 01:47:39 +00:00
Howard Chu
28b57ba8b9 ITS#8316 cursor fixup in page_merge
Deleting the merged page requires bumping down other ki's
of the page's parent.
2015-11-23 01:47:39 +00:00
Howard Chu
657dbcc811 ITS#8312, 8313, 8315 2015-11-19 17:29:42 +00:00
Howard Chu
1edb0e3a42 ITS#8315 fix ovpage_free
Keep dirty_room sync'd with dirty_list
2015-11-19 17:28:33 +00:00
Howard Chu
2fb8219aa3 ITS#8313 more for ITS#8062
dummy flags must be init'd due to 3d46d550
2015-11-19 17:28:23 +00:00
Hallvard Furuseth
db510359c9 ITS#8312 Fix loose pages in commit(nested txn) 2015-11-19 17:28:15 +00:00
Howard Chu
27f71b4dd3 ITS#8311 2015-11-18 10:27:50 +00:00
Howard Chu
71c07f0d60 ITS#8311 add comment 2015-11-18 10:24:41 +00:00
Howard Chu
f9d3dc8293 ITS#8311 fix page_split from update_key
Check for top of stack. Usually the cursor only has height 1 when
calling page_split, but not always.
2015-11-18 10:05:28 +00:00
Hallvard Furuseth
a9877f783a ITS#7209 2015-11-17 18:49:31 +01:00
Hallvard Furuseth
2a839d5dfa ITS#7209 Default MDB_DSYNC = O_SYNC if no O_DSYNC 2015-11-17 18:37:33 +01:00
Howard Chu
f6b7277e9a ITS#8310 2015-11-13 09:28:36 +00:00
Howard Chu
a90415f301 ITS#8310 fix mdb_rebalance cursor fixup
When collapsing root, must adjust entire cursor stack
2015-11-13 09:25:55 +00:00
Howard Chu
79b12bbd7b Tweak robust mutex detection for glibc 2015-11-11 11:51:07 +00:00
Howard Chu
4e1ec79f0e ITS#8304 2015-11-09 20:11:10 +00:00
Howard Chu
5d8f9ddf7e ITS#8304 fix page_merge
Was using the pre-touch dst page pointer instead of the touched page
2015-11-09 20:10:51 +00:00
Howard Chu
712942d392 ITS#8300 more for node_move
When moving a node from one page to another, make sure other cursors'
parent index gets adjusted too.
2015-11-06 10:19:49 +00:00
Howard Chu
7d022e05a8 ITS#8300 simplify 2015-11-04 22:46:04 +00:00
Howard Chu
0db71b9f1a ITS#8300 more for node_move fixups
When moving a node from the right neighbor, a different
adjustment is needed.
2015-11-04 22:31:01 +00:00
Howard Chu
e339fced30 ITS#8300 2015-11-04 21:03:22 +00:00
Howard Chu
9fc7c94aeb ITS#8300 fix node_move
Don't adjust other cursors when we added a node on the right.
2015-11-04 21:01:30 +00:00
Howard Chu
af45cf3a04 ITS#8300 fix rebalance after node_move
ITS#8258, ITS#7829 fixes checked parent index to see if we were moving
from a left neighbor. Should have just checked to see if current index
was 0, meaning we added on the left. (Parent index may not tell us
anything meaningful after a nested rebalance.)
2015-11-04 20:38:30 +00:00
Howard Chu
4359ffe08f ITS#8238, #8299 2015-11-04 18:17:50 +00:00
Howard Chu
17aab561f2 ITS#8238 fix DUPFIXED page_split
Parent mc_ki wasn't adjusted if new_indx was > split point
2015-11-04 18:11:12 +00:00
Howard Chu
c62b77b661 ITS#8299 fix page_merge cursor fixup
The parent's mc_ki has changed. We need to fix that up as well
in other cursors.
2015-11-04 17:05:55 +00:00
Howard Chu
caca4d8be6 Use MDB_USE_ROBUST not MDB_NO_ROBUST 2015-10-31 02:27:31 +00:00
Howard Chu
447f552756 Add MDB_NO_ROBUST to disable Robust Mutexes 2015-10-31 02:12:31 +00:00
Howard Chu
550df2a583 More misc updates 2015-10-26 20:18:19 +00:00
Hallvard Furuseth
f1e07f9d14 Fix typo in mdb_tassert().
No effect on current code.
2015-10-25 14:40:27 +01:00
Pavel Medvedev
56adc467a6 ITS#8069 char* strings on Windows are ASCII 2015-10-25 10:56:39 +01:00
Pavel Medvedev
22958b0f9e ITS#8067 add ssize_t typedef for MSVC 2015-10-25 10:56:39 +01:00
Hallvard Furuseth
de5b689308 Simpler mdb_env_write_meta() 2015-10-25 10:56:39 +01:00
Hallvard Furuseth
bde5c231bc Kill magic numbers for NUM_METAS, databases 2015-10-25 10:56:38 +01:00
Hallvard Furuseth
8901d9cfbc ITS#7377 Catch mdb_put() to blocked/read-only txns
...early enough that txn state is left unchanged.
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
01342bd5d2 ITS#7377 Always notice env error on txn startup.
Move the check to the end of txn startup.  Catches env
breakage which happens while the new txn waits for a lock.
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
602c978761 Cleanup: Drop !mt_dbxs hack, use MDB_TXN_FINISHED 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
a3ae2e7db1 Catch most uses of finished/parent txns.
* Add MDB_TXN_FINISHED, MDB_TXN_HAS_CHILD, MDB_TXN_BLOCKED.
* Clear mt_numdbs in writers, for TXN_DBI_EXIST() to catch.
  We already do in readers.
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
9266843fa6 Move code into mdb_txn_end(). Was mdb_txn_reset0.
Side effects:
* Clean txn up a bit even before freeing it.
* Tweak DEBUG output at txn end. Add DEBUG after commit(writer).
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
0cfc0a9736 Factor me_metas[toggle] out to mdb_env_pick_meta() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
490243424c Simpler mdb_node_add() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
6318038138 More ESECT declarations 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
110fba2ef1 Add DB_USRVALID, to avoid 'dbi == FREE_DBI' tests 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
b6f0179683 Simpler flag/DBI checks and MDB_DEBUG 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
06df0a4655 Simpler mdb_drop().
MDB_DBI_CHANGED(,MAIN_DBI) is never true.
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
e5f41ce56b Simpler mdb_node_shrink() 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
9d6c973f76 Simpler mdb_txn_commit().
mt_env is always set.
Commit(mt_child) resets mt_child, so parent need not.
2015-10-25 10:55:22 +01:00
Hallvard Furuseth
ee06adb311 mdb_txn_begin() cleanup 2015-10-25 10:55:22 +01:00
Hallvard Furuseth
cc2a50aca2 mdb_drop0(): Omit scanning DUPSORT sub-DB leaves 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
70788bfe45 Use mdb_cmp_long() for FREE_DBI 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
a36f7a7fc2 mdb_env_get_flags(): Hide internal flags 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
600e2b6ce0 Support robust mutexes/locks. Add mdb_mutex_t etc. 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
3a71450436 Add MDB_USE_POSIX_MUTEX.
So far just to help aligning mdb.master and mdb.RE.
We'll make it an option later.
2015-10-25 10:55:21 +01:00
Hallvard Furuseth
f25c4f0db9 Whitespace (align with mdb.master) 2015-10-25 10:55:21 +01:00
leo@yuriev.ru
086bc04cd2 ITS#7969 Use __sync_synchronize()
The rest of 9a80a8a8e8
plus commit a937740aa0.
2015-10-25 10:55:21 +01:00
Hallvard Furuseth
3f6fa7aece Set/clear mp_pad, md_pad (MDB_DUPFIXED data size).
mdb_xcursor_init1(): md_pad is only used when MDB_DUPFIXED.
mdb_page_split():    Copy mp_pad too. Used by mdb_page_list().
2015-10-25 10:55:21 +01:00
Hallvard Furuseth
c616689d9a Cleanup MDB_env.me_txn0.
More fallout from 4d02c741b1.
2015-10-25 10:55:21 +01:00
Hallvard Furuseth
c0170bc0ec Copy some env flags to txn. Factor out flags.
Taken from mdb_txn_begin(,,MDB_NOMETASYNC, MDB_NOSYNC,,)
without adding those two flags yet, to align with mdb.master:
Part of 54516639ac (Renumber...)
+ 8adee9464f (Fix per-txn...).
2015-10-25 10:55:21 +01:00
leo@yuriev.ru
c65ca298b9 ITS#7971 mdb_txn_renew0(): Fix new readers slots.
commit 9a8eb95674 (mdb_txn_renew0)
plus b2ab9910dd (reader allocation)
from mdb.master.
2015-10-25 10:55:21 +01:00
David Barbour
076b773d6b ITS#7994 Access to current transaction ID.
commit b660491d3f (mdb_txn_id())
plus c36c167cc4 (fix prev commit)
from mdb.master.
2015-10-25 10:55:21 +01:00
Hallvard Furuseth
f3d3f60e3d Try to avoid an invalid datafile after failed init 2015-10-25 10:55:21 +01:00
Hallvard Furuseth
aa10c98f3f For ITS#7789: Ensure mapsize >= pages in use.
Check new mapsizes against mm_last_pg.  Move
mdb_env_init_meta0() so it can set mm_last_pg earlier.
2015-10-25 10:55:21 +01:00
Howard Chu
fc3514152f ITS#8263, 8264, 7771, 8270 2015-10-25 08:13:25 +00:00
Ignacio Casal Quinteiro
52446f93e7 ITS#8270 win32: fix conversion error with MSVC 2015-10-25 08:10:34 +00:00
Howard Chu
24add6589b ITS#7771 fix cursor tracking on fake pages
node_del shifts nodes around, cursors pointing at fake pages
need to have their mc_pg[0] corrected.
2015-10-25 08:10:13 +00:00
Hallvard Furuseth
448b4c815a ITS#8263 streamline prev patch 2015-10-25 08:09:16 +00:00
Howard Chu
7e3c532823 ITS#8263 fix cursor tracking in cursor_put 2015-10-25 08:09:06 +00:00
Howard Chu
9ed1e57440 ITS#8264 fix cursor_del cursor tracking
Some destination fixups need to happen immediately after nodes
are moved, before rebalancing
2015-10-25 08:08:53 +00:00
Howard Chu
6f53771687 ITS#8258 2015-10-04 03:02:04 +01:00
Howard Chu
8bdadf68c5 ITS#8258 fix rebalance/split
The tree height can also increase during rebalance, not just shrink.
This can happen if update_key needs to split a parent branch page.
2015-10-04 02:13:07 +01:00
Howard Chu
eccea851ff ITS#8259 fix usage ordering 2015-09-30 18:11:49 +01:00
Howard Chu
be1795a616 ITS#8221 fix typos 2015-09-29 17:32:25 +01:00
Howard Chu
bc7d3d9124 ITS#8221, #8256 2015-09-27 22:37:28 +01:00
Howard Chu
4b01cb3727 ITS#8221 don't merge branch pages needlessly 2015-09-27 22:35:54 +01:00
Luke Yeager
ddb7478e06 ITS#8256 Create install directories if needed 2015-09-27 22:35:24 +01:00
Howard Chu
faeaa3ae8f ITS#7377, 8237 2015-09-12 23:08:14 +01:00
Howard Chu
d84fae3fe3 ITS#8237 fix ITS#7589 regression 2015-09-12 23:07:16 +01:00
Hallvard Furuseth
7f151b1137 ITS#7377 mdb_env_init_meta(): Catch calloc error 2015-09-12 23:07:07 +01:00
Howard Chu
9a8d38a9de Doc tweak - MDB_RESERVE / DUPSORT incompat
For those people who insist on ignoring the obvious.
2015-08-22 14:01:07 +01:00
Howard Chu
d7e4e206ad Return to release engineering 2015-08-21 21:42:25 +01:00
Howard Chu
e55956a591 Another MDB_APPEND doc tweak
Missed this in 7ce29b9edb
2015-08-21 21:41:36 +01:00
Howard Chu
5d67c6aed1 Release 0.9.16 2015-08-14 01:00:38 +01:00
Howard Chu
d139771b43 ITS#8192 fix reference to EINTR on WIN32 from ITS#8106 2015-07-30 00:51:04 +01:00
Howard Chu
c4ae054bce Updated for ITS#8181, #8190, #8200 2015-07-28 15:20:43 +01:00
Hallvard Furuseth
4b58502c77 ITS#8200 Fix mdb_midl_shrink() usage, return void 2015-07-28 15:13:22 +01:00
Hallvard Furuseth
1fd0341f76 ITS#8181 Verify that records are/aren't DBs.
Except we don't catch the user passing F_SUBDATA to
mdb_cursor_<put/del>, like an internal LMDB call.
2015-07-28 15:13:10 +01:00
Howard Chu
7513bd4618 ITS#8190 fix cursor EOF bug 2015-07-28 15:12:58 +01:00
Howard Chu
1b6085cb9b Return to Release Engineering 2015-07-02 18:04:25 +01:00
Howard Chu
56e4e20ebc Release 0.9.15 2015-06-19 14:10:32 +01:00
Hallvard Furuseth
416ecc7827 Update for mdb_env_open 2015-06-02 21:07:33 +02:00
Hallvard Furuseth
6794d898f8 Clarify mdb_env_open() doc of 'mode' param 2015-06-02 21:04:52 +02:00
Hallvard Furuseth
249d2b84dc more CHANGES 2015-05-29 03:08:32 +02:00
Hallvard Furuseth
2a1dd5ae1c ITS#8156 2015-05-28 21:13:24 +02:00
Hallvard Furuseth
a0b96697c5 ITS#8156 Fix MDB_MAXKEYSIZE doc 2015-05-28 20:51:39 +02:00
Hallvard Furuseth
277e536ffa ITS#8157 2015-05-28 00:12:53 +02:00
Hallvard Furuseth
6bfadb9178 ITS#8157 mdb_txn_renew0(): init after error checks 2015-05-28 00:12:18 +02:00
Hallvard Furuseth
91743d66e6 mtest*.c: Fix MDB_NOOVERWRITE, plug cursor leak 2015-05-28 00:10:29 +02:00
Hallvard Furuseth
822b2d502f ITS#8117 Fix MDB_INTEGERDUP keysize doc + md_dcmp 2015-05-28 00:08:51 +02:00
Howard Chu
6bd97d4286 ITS#8117 better fix
Don't change mc_dbx because we would need to undo the change if
the txn aborts. Make the fix (for get) match existing code for put.
2015-05-03 07:52:47 +01:00
Howard Chu
7127753244 Revert "ITS#8117 cleanup prev commit"
This reverts commit 47c4e747a0.

Revert "ITS#8117 fix INTEGERDUP compare"

This reverts commit ba45e0c05a.
2015-05-03 07:43:50 +01:00
Howard Chu
0fd2214a8b ITS#8117 2015-04-29 17:30:02 +01:00
Howard Chu
47c4e747a0 ITS#8117 cleanup prev commit 2015-04-29 17:30:02 +01:00
Howard Chu
ba45e0c05a ITS#8117 fix INTEGERDUP compare 2015-04-29 17:12:40 +01:00
Howard Chu
5cdde0c5b7 ITS#8109 2015-04-23 05:52:13 +01:00
Howard Chu
b7511480c5 ITS#8109 fix mdb_cursor_del0 on empty DB 2015-04-23 05:50:48 +01:00
Howard Chu
8cf73291fb ITS#8106 2015-04-23 03:27:33 +01:00
Howard Chu
32d46d4ea2 ITS#8106 retry writes on EINTR 2015-04-23 03:26:03 +01:00
Hallvard Furuseth
5c89827817 Cleanup mtest* and sample-*.
Fix mdb_txn_begin(&read-only txn) calls. Test mdb_env_set_maxreaders().
Rename DBI open/close functions. Move mdb_dbi_close() out of txn.
2015-04-19 03:07:53 +02:00
Hallvard Furuseth
1693012d57 Reformat mdb_dbi_open() doc for clarity 2015-04-19 03:07:53 +02:00
Hallvard Furuseth
f46b642b06 mdb_txn_renew(): Clear error from previous txn 2015-04-19 03:05:47 +02:00
Howard Chu
dce0911b17 ITS#8062 fix uninit'd cursor index 2015-04-19 03:05:47 +02:00
Hallvard Furuseth
2072ae6a3b Fix EACCES description 2015-04-19 03:05:47 +02:00
Howard Chu
b0032feb85 ITS#8062 also handle subcursors 2015-04-16 00:19:40 +01:00
Howard Chu
ddc4aa1aa3 ITS#8062 2015-04-15 23:48:09 +01:00
Howard Chu
97c7b6151e ITS#8062 fix rebalance
(Probably fixes the ITS, definitely fixes a bug) when collapsing
the root page, fixups of other cursors was incomplete.
2015-04-15 23:30:52 +01:00
Quanah Gibson-Mount
dd58f3dde4 ITS#8066 2015-02-27 17:15:23 -06:00
Howard Chu
82b6a04bb7 ITS#8066 fix mdb_load with large values 2015-02-27 17:14:52 -06:00
Quanah Gibson-Mount
b7d1afad42 Happy New Year 2015-02-12 11:28:55 -06:00
Quanah Gibson-Mount
21a374f2d4 Happy New Year 2015-02-12 11:28:21 -06:00
Hallvard Furuseth
6586299f55 Restrictive mdb_copy file mode.
Copied from 58ddb5527b.
2015-01-15 07:19:30 +01:00
leo@yuriev.ru
8230b1b630 ITS#7970 LMDB: Critical Heisenbug
Inconsistent reading & SIGSEGV due to the race condition.
2015-01-14 19:24:18 +01:00
leo@yuriev.ru
1e5d79831c ITS#7969 LMDB: volatile.
Globally shared fields of meta-data were not 'volatile'.
Code from 9a80a8a8e8,
except the unportable __synchronize().
2015-01-14 19:24:18 +01:00
Howard Chu
ea80418cfc Fix potential null deref (coverity) 2015-01-13 19:22:42 +00:00
Hallvard Furuseth
0599dee9d4 ITS#8021 doc: Don't mix MDB_WRITEMAP + non-WRITEMAP 2015-01-12 12:20:31 +01:00
Howard Chu
bf3961e3c7 More cleanup for fdatasync hack 2015-01-12 10:41:32 +00:00
Howard Chu
e85c944a3a Tweak conditionals for fdatasync hack 2015-01-11 11:41:08 +00:00
Howard Chu
0b9f42d1f4 ITS#8021 env_sync is invalid in RDONLY env 2015-01-09 11:25:07 +00:00
Howard Chu
4500d49f36 fdatasync hack, again
Check for ext3/ext4 fs, then check kernel version.
2015-01-08 13:03:55 +00:00
Howard Chu
888a76f651 Revert "Fix prev commit for env_sync0"
This reverts commit e95c9231fc.

Revert "Hack for potential ext3/ext4 corruption issue"

This reverts commit 91155b9d67.
2015-01-08 12:57:08 +00:00
Howard Chu
fe8b13f225 Tweak fdatasync hack description 2014-12-22 18:07:08 +00:00
Howard Chu
e95c9231fc Fix prev commit for env_sync0 2014-12-21 00:14:16 +00:00
Howard Chu
02495837dc Update for fsync hack 2014-12-18 04:46:43 +00:00
Howard Chu
91155b9d67 Hack for potential ext3/ext4 corruption issue
Use regular fsync() if we think this commit grew the DB file.
2014-12-18 04:45:02 +00:00
Howard Chu
e6ac9c2314 Update for 0.9.15 2014-12-17 15:29:48 +00:00
Howard Chu
a0accc86f2 Fix MDB_APPEND doc
We actually compare the new key against the last key, to prevent
corruption.
2014-12-15 20:45:02 +00:00
Hallvard Furuseth
f1417e2634 make clean: remove *.lo 2014-12-15 20:44:42 +00:00
Howard Chu
dcccd8a89a Clarify mdb_dbi_open doc
The concurrency restriction is on threads within a single process.
Multiple processes can use mdb_dbi_open without affecting each other.
2014-12-15 20:44:30 +00:00
Leo Yuriev
196e07ca58 ITS#7987 fix excessive space for single write txn 2014-12-05 21:07:55 +00:00
Hallvard Furuseth
f284c3232d Fix WIN32 -> _WIN32 2014-12-05 18:43:07 +01:00
Hallvard Furuseth
8704eff591 mdb_strerror: Silence warning @ Windows 2014-12-01 20:17:27 +01:00
Hallvard Furuseth
5bf495abdc Fix comments 2014-12-01 20:17:27 +01:00
Hallvard Furuseth
3aa7537adc Simplify recent changes a bit. 2014-12-01 20:17:27 +01:00