Commit Graph

128 Commits

Author SHA1 Message Date
Kurt Zeilenga
3dadeb3efe happy belated New Year 2010-04-13 22:17:29 +00:00
Hallvard Furuseth
4bed42ae5a For ITS#6215: Do not expose obsolete Seqorset. Note ber_write(,,,nonzero) is gone. 2009-07-29 17:07:52 +00:00
Hallvard Furuseth
36d2dc034d More ITS#6215 -
Speedup & less memory allocation:
  Simplify the work to encode tag, length, integer/enum, sequence/set.
  Drop struct seqorset and allocations of it.  Replace BerElement.ber_sos.
  Drop ber_write(,,,nonzero) support. Callers, if any, need to be rewritten.
  Make ber_log_sos_dump() and ber_sos_dump() stubs, they could no longer work.
Fix ber_write() buffer overrun after ber_start_seqorset().
Check overflow and max sizes, e.g. for functions returning int size.
Some cleanup, and handwaves in the direction of supporting CHAR_BIT>8.
Add/fix comments and a few descriptive types/macros.
2009-07-29 16:49:42 +00:00
Hallvard Furuseth
12a6f3e055 ITS#6215: Fix buffer overrun and write through NULL pointer 2009-07-29 14:57:09 +00:00
Howard Chu
d39bd12e9f Skip redundant PACKETS logging 2009-03-13 23:10:37 +00:00
Kurt Zeilenga
4af9eb9715 Update copyright notices 2009-01-22 00:40:04 +00:00
Howard Chu
aebcd93721 ITS#5580: Revert prev commit, failed on byte-at-a-time input. Different
approach used here.
2008-07-02 01:33:15 +00:00
Howard Chu
14f1138ab5 ITS#5580 fix length decoding, verified with PROTOS 2008-06-27 02:36:41 +00:00
Kurt Zeilenga
c890c96d13 Happy New Year (belated) 2008-01-08 00:19:56 +00:00
Howard Chu
bdac543b3b Cleanup debug calls 2007-10-18 01:35:07 +00:00
Hallvard Furuseth
973a2b41b7 Make LDAP_MEMORY_DEBUG a bitmask. #define LDAP_MEMORY_DEBUG_ASSERT. ITS#4990. 2007-07-24 20:53:23 +00:00
Howard Chu
23ba7dfa12 Add ber_skip_data() to help positioning in structured BER data 2007-03-20 12:29:06 +00:00
Kurt Zeilenga
da6d9eb046 happy new year 2007-01-02 20:00:42 +00:00
Howard Chu
57c329a3af ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)
2006-09-14 06:35:34 +00:00
Hallvard Furuseth
02bb67044b Cleanup since last patch (remove unused label) 2006-04-13 22:13:42 +00:00
Pierangelo Masarati
dfc8e7f6b8 better fix for ITS#4483 2006-04-09 22:29:42 +00:00
Pierangelo Masarati
23c620a637 don't leak a BerElement 2006-04-08 17:34:00 +00:00
Kurt Zeilenga
acbb5cf689 Happy new year! 2006-01-03 23:11:52 +00:00
Howard Chu
10c94f4e58 Cleanup lbo_valid / meminuse / memfuncs 2005-11-12 18:26:17 +00:00
Pierangelo Masarati
9129a2f7ee silence warnings 2005-09-10 18:59:35 +00:00
Kurt Zeilenga
dc0eacd40b Happy New Year! 2005-01-01 20:49:32 +00:00
Kurt Zeilenga
d611a4b49a unifdef -UNEW_LOGGING 2004-09-04 04:54:28 +00:00
Howard Chu
affe835984 NUL-terminate alloc'd berbuf (ITS#3086) 2004-04-15 10:25:14 +00:00
Kurt Zeilenga
3c598e89fb Happy new year 2004-01-01 19:15:16 +00:00
Kurt Zeilenga
85013a9d98 acknowledgements and notices 2003-11-26 22:51:15 +00:00
Kurt Zeilenga
327880b984 Notice updates 2003-11-25 23:17:08 +00:00
Kurt Zeilenga
db097047af code cleanup 2003-07-08 03:46:20 +00:00
Hallvard Furuseth
1fa40181d9 Cast unsigned char *p to char *. 2003-06-03 17:51:38 +00:00
Howard Chu
13aa48e47a Fix reading multibyte lengths 2003-05-22 06:24:23 +00:00
Kurt Zeilenga
6035ecfe7b Reverse unintended commit 2003-05-22 05:33:04 +00:00
Kurt Zeilenga
df1381fa38 cleanup 2003-05-22 05:32:06 +00:00
Kurt Zeilenga
6d36ba9d9f Add trickle code to test ber_get_next.
Use etest {...} | dtest {...} to test.
2003-05-22 04:37:44 +00:00
Kurt Zeilenga
bfa6808c48 Fix dtest ber_get_next() usage 2003-05-22 03:35:36 +00:00
Howard Chu
3d9fd17678 ber_get_next - set errno to 0 before calling ber_int_sb_read(), otherwise
an EOF will return with the previously set errno value.
2003-05-20 04:08:35 +00:00
Jong Hyuk Choi
4f58efc4d1 - change in message to modlist conversion 2003-05-20 01:45:12 +00:00
Howard Chu
3fc96a24ee More ITS#2490 - fix retries for multi-byte lengths 2003-05-19 12:14:15 +00:00
Howard Chu
5eb0ec070c ITS#2490 - more retry checks 2003-05-19 10:37:09 +00:00
Howard Chu
9757665aed ITS#2490 - allow retry for incomplete reads of BER tag & len 2003-05-19 10:33:18 +00:00
Howard Chu
a413bab19a Clean up prev commit 2003-04-24 04:20:17 +00:00
Howard Chu
b6111d793e Fix multi-byte tag parsing 2003-04-24 03:59:45 +00:00
Howard Chu
bcf7ab26e4 ITS#2465 fix? ber_get_next must read at least sizeof(tag)+sizeof(len)
which should be at most 8 bytes. However if we read more than the minimum
message length, we have a problem because we steal bytes from any following
message, and there is no buffer mechanism to push back excess data.
The shortest legitimate message is Unbind at 7 bytes, but there shouldn't
be anything following it. Abandon at 8 bytes is next, so always requesting
at least 8 bytes should be safe. Always requesting 9 was a problem.

Please double-check these assumptions...
2003-04-24 02:10:18 +00:00
Howard Chu
42e7845d81 More malloc context tweaks 2003-04-10 06:14:16 +00:00
Howard Chu
ca12bb75c7 Extended API for ber_mem functions, add context argument.
Must always use ber_mem funcs, even if CSRIMALLOC is present.
2003-04-09 13:25:11 +00:00
Howard Chu
e240135305 ITS#2434 ber accessors 2003-04-09 09:41:02 +00:00
Kurt Zeilenga
e41ca42de1 mark a few translatable strings 2003-04-06 06:19:13 +00:00
Kurt Zeilenga
1b37568b00 Use ifdef not comment to comment out code 2003-03-22 22:28:57 +00:00
Howard Chu
50ecec94eb Fix ITS#2344, prev commit changed too much. 2003-03-03 23:44:22 +00:00
Howard Chu
ec497cf529 Use fixed sizes for ber_get_next to avoid 64-bit hangs. 2003-03-02 04:02:39 +00:00
Howard Chu
5354dbf269 ber_flush shouldn't be logging with _ANY, changed to _TRACE 2003-01-31 22:45:19 +00:00
Kurt Zeilenga
bd9bf709aa ITS#2275: PROTOS ber_get_next() fix
Needs review!!!!
2003-01-22 22:29:11 +00:00