Commit Graph

19269 Commits

Author SHA1 Message Date
Pierangelo Masarati
53343b421c force the generation of a new CSN (ITS#6766) 2011-01-03 00:04:53 +00:00
Pierangelo Masarati
ab4eb5e673 skip operations when internal 2011-01-02 23:36:30 +00:00
Pierangelo Masarati
d562608e40 memberof handling of rename (ITS#6700) 2011-01-02 23:03:13 +00:00
Pierangelo Masarati
7c77d9b801 fix control value generation (ITS#6652) 2011-01-02 17:19:14 +00:00
Pierangelo Masarati
0a12ea91df hex digits need to be in pairs (ITS#6652) 2011-01-02 15:58:48 +00:00
Pierangelo Masarati
cddaeff565 fix reqControls validator (partially addresses ITS#6652) 2011-01-02 15:50:00 +00:00
Pierangelo Masarati
b672d8535d make sure initialization is only tried once; improve error messages 2011-01-02 15:06:11 +00:00
Pierangelo Masarati
f2df9f0cf5 add some logging (under TRACE) 2011-01-02 12:29:19 +00:00
Pierangelo Masarati
5c8d655bbb quick fix for null DN 2011-01-02 02:15:21 +00:00
Pierangelo Masarati
59b220506d more about ITS#6645 2011-01-01 20:50:00 +00:00
Pierangelo Masarati
58bf3de504 add more rename/delete tests 2011-01-01 19:49:27 +00:00
Pierangelo Masarati
cb1414ba28 fix logging 2011-01-01 17:26:15 +00:00
Pierangelo Masarati
cd1fb3003c check return value 2011-01-01 16:10:23 +00:00
Pierangelo Masarati
6631d41c16 ber_flatten must return -1 on unmatched "{" "}" (ITS#6764) 2011-01-01 16:06:45 +00:00
Hallvard Furuseth
bdb078a778 ITS#6758 Reset dangerous REP_ENTRY_* flags.
If SlapReply.sr_un cannot contain an entry but does or soon may
contain another member than sru_search: Ensure nothing will see
leftover REP_ENTRY_* flags and try to clean up the "entry" there.
2010-12-31 20:53:17 +00:00
Hallvard Furuseth
b26c767ed6 ITS#6758 slap.h: Cast REP_* #defines to slap_mask_t 2010-12-31 20:02:41 +00:00
Hallvard Furuseth
9467059b0b ITS#6758 fix/add slap_send_search_entry() comments 2010-12-31 19:57:53 +00:00
Hallvard Furuseth
a4c2d54127 ITS#6758 result.c:Use rs_*(). Frees entries earlier.
For readability, use rs_flush_entry() where slap_send_search_entry() and
slap_send_search_reference() release entries before network operations.

This change also frees entires marked MUSTBEFREED earlier.
2010-12-31 18:14:31 +00:00
Hallvard Furuseth
f4a3304477 ITS#6758 Use rs_*() to manage SlapReply entries.
Some noop changes + fixes entry leaks and REP_ENTRY_MODIFIABLE flag leaks.
2010-12-31 17:55:36 +00:00
Hallvard Furuseth
15aa7c472a noop commit: cleanup 0 -> REP_RESULT in SlapReply 2010-12-31 14:08:34 +00:00
Hallvard Furuseth
713886ec07 ITS#6758, pcache.c: Avoid SlapReply reuse.
refresh_merge(): Do not reuse Search SlapReply parameter for a Modify,
use a local one and copy its sr_err to the parameter.  The parameter is
from refresh_query().  Move its SlapReply parameter to a local variable.
2010-12-31 13:46:48 +00:00
Hallvard Furuseth
6d7c1880a8 ITS#6758 Avoid SlapReply reuse.
Caller provides a SlapReply and reads the result after the operation,
then reuses it.  Reinitialize before reuse, or move declaration inwards.
2010-12-31 13:08:11 +00:00
Hallvard Furuseth
04f8fa5619 ITS#6760: Fix rwm entry handling 2010-12-31 12:01:03 +00:00
Hallvard Furuseth
13f52646b2 ITS#6758 Avoid SlapReply reuse, simple cases.
Caller provides and reuses a SlapReply it does not read after
initialization.  So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().
2010-12-31 10:46:22 +00:00
Hallvard Furuseth
cb15a4c687 ITS#6758 rs_reinit() += slap_reply_t parameter 2010-12-31 09:45:16 +00:00
Hallvard Furuseth
b120b2a05b ITS#6758 config_build_entry, avoid SlapReply reuse
Do not use the 'SlapReply *rs' passed to config_build_entry().  Instead
pass a new one to op->o_bd->be_add() and copy the output sr_err to rs.
This takes care of most SlapReply reuse in bconfig.c.
2010-12-31 09:02:34 +00:00
Hallvard Furuseth
ab1bc728fa ITS#6758 bconfig.c: ensure sr_text==NULL if sr_err==LDAP_SUCCESS
config_modify_internal(): Do not send rs->sr_text with success.
config_back_modify(): When slap_bv2ad() can set rs->sr_text,
set sr->sr_err too and catch failure.
2010-12-31 08:45:48 +00:00
Howard Chu
089cf2d421 ITS#6670 partial fix - ignore member/memberof pointing to same entry 2010-12-31 01:38:24 +00:00
Hallvard Furuseth
abf7f2efce ITS#6758 back-bdb: Delay setting sr->sr_entry until we know it will be used 2010-12-31 00:04:38 +00:00
Hallvard Furuseth
1ea8de9fda ITS#6758 Do not set sr_err=error before be_search.
glue_op_search() set LDAP_UNWILLING_TO_PERFORM before be_search() as
well as when there was no be_search.
2010-12-30 23:59:23 +00:00
Hallvard Furuseth
d2b024be4a ITS#6758 Reset some SlapReply flags & data.
Reset data more consistenlty.  When resetting sr_entry after sending
data, reset sr_flag as well.  Reset rs_attrs and Extended Operation
oid/data after setting and sending them.
2010-12-30 23:55:07 +00:00
Hallvard Furuseth
f7a77545ad noop commit for ITS#6758: simplify future commits 2010-12-30 23:48:41 +00:00
Hallvard Furuseth
98966abeef noop commit for ITS#6758: Remove no-effect code.
Unused variable resets, unused SlapReply parameters to some functions.
2010-12-30 23:43:12 +00:00
Hallvard Furuseth
cd6e9156e7 Remove lint (unused vars/labels/funcs/default:s) 2010-12-30 23:34:55 +00:00
Hallvard Furuseth
5c3f806fca ITS#6758 Add rs_reinit(), rs_flush_entry() 2010-12-30 23:32:07 +00:00
Hallvard Furuseth
ea2b675dca ITS#6758 Add rs_assert*, RS_ASSERT, USE_RS_ASSERT 2010-12-30 23:29:46 +00:00
Hallvard Furuseth
c9e85af35c ITS#6759: assert;Debug -> Debug;assert 2010-12-30 23:19:02 +00:00
Pierangelo Masarati
41aa82350e silence valgrind 2010-12-30 21:52:09 +00:00
Pierangelo Masarati
ce4f5abb6e should also work for SASL binds (whenever supported) 2010-12-30 21:41:36 +00:00
Pierangelo Masarati
7443e6fc8c op->o_conn->c_sb may be 0 for internal operations 2010-12-30 21:41:07 +00:00
Rein Tollevik
a1a5affeb0 ITS#6754: Fail if there are unrecognized command-line arguments. 2010-12-30 19:45:08 +00:00
Howard Chu
8018924efd ITS#6741 support Bitstring in ldap_X509dn2bv() 2010-12-30 19:38:57 +00:00
Howard Chu
41f15a0080 ITS#6684 fix ppolicy crash, fix Makefile install target 2010-12-30 18:40:01 +00:00
Kurt Zeilenga
46f4813632 Remove dead code. 2010-12-30 17:46:26 +00:00
Howard Chu
97d9b07814 ITS#5862 Assert control for rootDSE/subschema 2010-12-30 17:28:19 +00:00
Pierangelo Masarati
f3dd90a553 s/0/O/ 2010-12-30 15:58:48 +00:00
Pierangelo Masarati
538b582cdc fix perror; removed extra sequence opening (is it needed; if yes, it must also be closed, see #if 0) 2010-12-30 15:51:25 +00:00
Pierangelo Masarati
2ad0a297b8 verify credentials extop: support for simple bind 2010-12-30 15:49:34 +00:00
Pierangelo Masarati
7dfc54378c s/VCRequest/VCResponse/ 2010-12-30 14:12:26 +00:00
Kurt Zeilenga
3242a3fab4 Fix prototype to match code 2010-12-28 22:59:15 +00:00