Commit Graph

482 Commits

Author SHA1 Message Date
Howard Chu
4d7be1c161 ITS#9112 cleaner error handling during connection setup
And additional debug code for tracking errant close()s
2019-10-28 23:01:08 +00:00
Howard Chu
0fa0f8ff07 ITS#9052 zero out sasl_ssf in connection_init 2019-07-10 21:29:39 +01:00
Nadezhda Ivanova
e9fa4af4d8 Move initialization of Connection mutexes to connections_init 2019-02-28 17:27:45 +00:00
Ondřej Kuzník
97a310b312 ITS#8731 Apply doc/devel/variadic_debug/04-variadic.cocci 2019-02-15 16:51:53 +00:00
Quanah Gibson-Mount
b45a6a7dc7 Happy New Year! 2019-01-14 18:46:16 +00:00
Quanah Gibson-Mount
59e9ff6243 Happy New Year 2018-03-22 15:35:24 +00:00
Howard Chu
8b1fb962fc ITS#8725 connection fixes
Fix op_finish, must resched connection to pick up pending ops.
Fix op completion counter.
2017-09-08 17:39:14 +01:00
Howard Chu
75999a18c3 ITS#8725 Add SLAPD_ASYNCOP return code
Tell frontend the op will finish asynchronously, leave it alone
2017-09-07 18:07:39 +01:00
Howard Chu
a0cc1d9655 ITS#8054 add queue time to log
Show time spent in conn+threadpool queues before an op actually executes.
Also clean up timestamp handling
2017-03-16 14:21:31 +00:00
Quanah Gibson-Mount
1df85d3427 Happy New Year! 2017-01-03 12:36:47 -08:00
Quanah Gibson-Mount
6c4d6c880b Happy New Year! 2016-01-29 13:32:05 -06:00
Howard Chu
2160427f89 ITS#8232 avoid redundant abandon processing 2015-08-29 19:44:33 +01:00
Quanah Gibson-Mount
1705fa7e55 Happy New Year 2015-02-11 15:36:57 -06:00
Howard Chu
fccca0ead9 Minor cleanup (coverity) 2015-01-14 16:59:54 +00:00
Howard Chu
32f05e96f7 Flesh out txn support
Only in back-mdb; back-bdb needs work but it's deprecated;
not worth the effort. In particular txn, retry after deadlocks
makes the whole thing too messy.
2014-09-15 23:48:23 +01:00
Kurt Zeilenga
5c878c1bf2 Happy new year (belated) 2014-01-25 05:21:25 -08:00
Howard Chu
d51ee964fc ITS#7694 more for IPv6 CLDAP, slapd fix 2013-10-10 10:48:08 -07:00
Howard Chu
88d22a1ca3 Simplify write waiter handling
Writer threads do their own wait using select/poll instead of
asking the listener thread. Eliminates one mutex+one condvar
per conn plus multiple wakeups of the listener thread. Also
fixes writetimeout to wait an exact time, instead of the
approximation used in the listener thread.
2013-09-07 14:53:02 -07:00
Howard Chu
7d6d6944c5 ITS#7683 log tls prot/cipher info
Note: I could not test the MozNSS patch due to the absence of
NSS PEM support on my machine. Given the review comments in
https://bugzilla.mozilla.org/show_bug.cgi?id=402712 I doubt that
trustworthy PEM support will be appearing for MozNSS any time soon.
2013-09-07 12:22:09 -07:00
Howard Chu
ca310ebff4 Add channel binding support
Currently only implemented for OpenSSL.
Needs an option to set the criticality flag.
2013-08-26 23:31:48 -07:00
Hallvard Furuseth
f38c8b79d4 ITS#7543 Fix log output "conn=-1 ... ACCEPT" 2013-03-18 20:28:07 +01:00
Kurt Zeilenga
0fd1bf30b8 Happy New Year 2013-01-02 10:22:57 -08:00
Hallvard Furuseth
db49dfecc9 ITS#7131 Fix connection loop connindex usage.
connection_<first/next>() takes a ber_socket_t *index, not int*.
2012-01-24 00:47:48 +01:00
Hallvard Furuseth
2b538761e9 ITS#7125 Document connection loop API.
Code comments belong in the code, not in commit messages.
2012-01-24 00:47:48 +01:00
Kevan Carstensen
7e893c75d1 ITS#7113 fix check order in connection_write() 2012-01-21 17:27:47 -08:00
Hallvard Furuseth
221d3ccdc6 ITS#7125 Fix Connection.c_mutex usage.
Partial revert of 9e00b6cc6ce2857490b33218bdaf1339319c5f60:connection.c.
2012-01-13 16:07:39 +01:00
Kurt Zeilenga
2bbf9804b9 Happy New Year! 2012-01-01 07:10:53 -08:00
Pierangelo Masarati
d324ab5c74 import ITS#6925 patch; fix peeraddr variable name clash in LDAP_CONNECTIONLESS code; fix scope of addr[] when inet_ntop(3) is used 2011-09-09 01:09:04 +02:00
Pierangelo Masarati
415b8ec84b release mutex only *after* backend connection initialization (ITS#6993) 2011-08-22 11:23:54 -06:00
Howard Chu
9e00b6cc6c Add strictrefresh syncrepl option
Only affects delta-syncrepl - stop listening to clients while
refresh is running.
2011-04-15 11:13:38 -07:00
Hallvard Furuseth
6223282235 Catch ber_scanf errors properly 2011-01-12 14:41:33 +00:00
Kurt Zeilenga
966cef8c9a Happy New Year 2011-01-05 00:42:37 +00:00
Hallvard Furuseth
13f52646b2 ITS#6758 Avoid SlapReply reuse, simple cases.
Caller provides and reuses a SlapReply it does not read after
initialization.  So reinitialize or move the declaration inwards.
In case of refint, move the rs parameter into refint_repair().
2010-12-31 10:46:22 +00:00
Hallvard Furuseth
c9e85af35c ITS#6759: assert;Debug -> Debug;assert 2010-12-30 23:19:02 +00:00
Hallvard Furuseth
5feeec67d7 ITS#6747 Fix LDAP_CONNECTIONLESS Debug(), warnings 2010-12-14 15:06:32 +00:00
Kurt Zeilenga
3dadeb3efe happy belated New Year 2010-04-13 22:17:29 +00:00
Howard Chu
7c9e4df765 ITS#6412, refix #6304 - only check for writes if sockbuf NEEDS_WRITE 2009-12-04 02:44:00 +00:00
Pierangelo Masarati
c315ede9d5 connid is unsigned; offset real conns by maxrid + 1 2009-11-21 21:44:45 +00:00
Howard Chu
2f351f964d Move connection state enums to slap.h to ease debugging 2009-11-19 11:24:14 +00:00
Howard Chu
99381a43e1 ITS#6304 retry if tls_accept() returns 1 2009-11-15 22:39:35 +00:00
Howard Chu
d6fbe1c7ca ITS#6361 remove asserts 2009-11-13 23:48:51 +00:00
Howard Chu
b0fdc08e06 ITS#6276 wake up blocked writers if we're pausing 2009-08-28 23:00:46 +00:00
Howard Chu
a975c61451 More for #6220, don't timeout idle connections when writetimeout is
set and idletimeout is not.
2009-08-17 11:28:25 +00:00
Howard Chu
553f0f2ffd ITS#6220 don't check write timeouts when global_writetimeout isn't set 2009-07-21 02:04:46 +00:00
Hallvard Furuseth
0f5378c8f7 Fix Debug format in last commit 2009-06-28 21:23:59 +00:00
Howard Chu
c62ebb9da2 ITS#6189 delay resetting the SLAP_C_BINDING state until the Bind handler
has fully returned to the connection manager. This may result in
"deferring operation: binding" messages being logged again (ITS#3850) but
it should not cause any hangs.
2009-06-28 03:37:20 +00:00
Hallvard Furuseth
41fa4f03b6 More ITS#6104: mutex-protected check of o_cancel value from other thread 2009-06-05 23:26:09 +00:00
Howard Chu
8edeaefe72 ITS#6056 partially revert ITS#5886, close sequencing was broken 2009-05-28 17:46:25 +00:00
Howard Chu
aa9e241581 ITS#6111 connection_state_closing() -> connection_valid() 2009-05-14 04:03:23 +00:00
Howard Chu
9767c87531 Partially revert prev commit, leave rs->sr_err == SLAPD_ABANDON 2009-05-11 04:23:51 +00:00