Commit Graph

482 Commits

Author SHA1 Message Date
Hallvard Furuseth
29aa1d07c7 For ITS#6215: No need to maintain ber->ber_usertag except at ber_printf "!" 2009-07-29 17:21:54 +00:00
Hallvard Furuseth
4bed42ae5a For ITS#6215: Do not expose obsolete Seqorset. Note ber_write(,,,nonzero) is gone. 2009-07-29 17:07:52 +00:00
Hallvard Furuseth
36d2dc034d More ITS#6215 -
Speedup & less memory allocation:
  Simplify the work to encode tag, length, integer/enum, sequence/set.
  Drop struct seqorset and allocations of it.  Replace BerElement.ber_sos.
  Drop ber_write(,,,nonzero) support. Callers, if any, need to be rewritten.
  Make ber_log_sos_dump() and ber_sos_dump() stubs, they could no longer work.
Fix ber_write() buffer overrun after ber_start_seqorset().
Check overflow and max sizes, e.g. for functions returning int size.
Some cleanup, and handwaves in the direction of supporting CHAR_BIT>8.
Add/fix comments and a few descriptive types/macros.
2009-07-29 16:49:42 +00:00
Hallvard Furuseth
53f884ac1d Remove useless asserts that will be re-assert()ed before the variable is used 2009-07-29 15:06:28 +00:00
Hallvard Furuseth
12a6f3e055 ITS#6215: Fix buffer overrun and write through NULL pointer 2009-07-29 14:57:09 +00:00
Hallvard Furuseth
4b01f4b23a ITS#6080 again: simplify ber_strnlen, don't use strnlen, revert _GNU_SOURCE 2009-05-01 03:10:25 +00:00
Hallvard Furuseth
4e3f04edc3 Fix previous fix: Don't #ifdef HAVE_STRNLEN before portable.h #defines that 2009-05-01 02:17:28 +00:00
Hallvard Furuseth
a59f93f32f Update previous commit: #define _GNU_SOURCE if needed for strnlen() 2009-05-01 02:11:42 +00:00
Pierangelo Masarati
85b47ab0e7 define and use ber_strnlen() (ITS#6080); please regenerate configure and include/portable.hin 2009-04-29 11:38:31 +00:00
Howard Chu
d39bd12e9f Skip redundant PACKETS logging 2009-03-13 23:10:37 +00:00
Howard Chu
07e79f26a4 Revert prev commit 2009-02-10 21:29:56 +00:00
Pierangelo Masarati
2b95e7d288 partially addresses an issue with ITS#5931 2009-02-10 12:44:12 +00:00
Kurt Zeilenga
4af9eb9715 Update copyright notices 2009-01-22 00:40:04 +00:00
Hallvard Furuseth
4028c83c67 ber_decode_oid(): Fix typo in comment 2008-08-06 13:36:53 +00:00
Howard Chu
aebcd93721 ITS#5580: Revert prev commit, failed on byte-at-a-time input. Different
approach used here.
2008-07-02 01:33:15 +00:00
Howard Chu
14f1138ab5 ITS#5580 fix length decoding, verified with PROTOS 2008-06-27 02:36:41 +00:00
Kurt Zeilenga
c890c96d13 Happy New Year (belated) 2008-01-08 00:19:56 +00:00
Howard Chu
2701782cba ITS#5224 add any necessary socket libraries 2007-11-12 07:59:54 +00:00
Howard Chu
bdac543b3b Cleanup debug calls 2007-10-18 01:35:07 +00:00
Howard Chu
670febf7d5 ITS#5105 from Alexey Melnikov @ isode 2007-08-24 21:58:20 +00:00
Hallvard Furuseth
973a2b41b7 Make LDAP_MEMORY_DEBUG a bitmask. #define LDAP_MEMORY_DEBUG_ASSERT. ITS#4990. 2007-07-24 20:53:23 +00:00
Hallvard Furuseth
17afb33c19 ITS#5010: OID encode/decode fixes and paranoia. #define LBER_OID_COMPONENT_MAX. 2007-07-23 12:57:23 +00:00
Hallvard Furuseth
e1d42189fa ITS#4990: Fix LDAP_MEMORY_DEBUG and LDAP_MEMORY_DEBUG=0 compilation.
Declare ber_int_meminuse.  Fix '#if' -> '#ifdef' LDAP_MEMORY_DEBUG.
2007-07-04 22:55:24 +00:00
Hallvard Furuseth
bfdb026fab ITS#5007: Remove void* pointer arithmetic, that's a gcc extension. 2007-06-09 23:41:36 +00:00
Hallvard Furuseth
3750520f6f Fix HP-UX crash: Replace socklen_t with ber_socklen_t from configure. ITS#4629. 2007-06-09 23:35:20 +00:00
Hallvard Furuseth
bbc719ca56 ITS#4948: '#if <undefined macro>' -> '#ifdef' warning cleanup 2007-05-09 18:17:10 +00:00
Hallvard Furuseth
545b5555fb ber_decode_oid(), ber_encode_oid(): cast bv_val to unsigned char* 2007-04-04 17:51:10 +00:00
Howard Chu
c6df30118f ITS#4893 fix prev commit 2007-03-25 12:18:06 +00:00
Howard Chu
7426ab07fc ITS#4893 define LDAP_PF_LOCAL_SENDMSG in <ac/socket.h> if a message must
be sent to transmit client credentials. Buffer the message data.
2007-03-25 04:40:22 +00:00
Howard Chu
724784e6cb Use AC_MEMCPY 2007-03-25 04:31:34 +00:00
Howard Chu
b213588f95 Add options for ber_get_stringbv() to omit NUL-terminator, to allow
non-destructive in-place parsing
2007-03-23 15:27:38 +00:00
Howard Chu
9fe8f72310 Add DER OID encoder/decoder 2007-03-20 15:10:16 +00:00
Howard Chu
23ba7dfa12 Add ber_skip_data() to help positioning in structured BER data 2007-03-20 12:29:06 +00:00
Howard Chu
e0ed944be3 Added ber_bvarray_dup_x() 2007-02-05 04:31:38 +00:00
Kurt Zeilenga
da6d9eb046 happy new year 2007-01-02 20:00:42 +00:00
Howard Chu
57c329a3af ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)
2006-09-14 06:35:34 +00:00
Pierangelo Masarati
8f1c5c4df5 improve previous commit 2006-06-15 01:47:39 +00:00
Pierangelo Masarati
8b76e15d28 fix ber_bvreplace() in case dst is NULL and src is empty 2006-06-15 01:42:25 +00:00
Hallvard Furuseth
02bb67044b Cleanup since last patch (remove unused label) 2006-04-13 22:13:42 +00:00
Pierangelo Masarati
dfc8e7f6b8 better fix for ITS#4483 2006-04-09 22:29:42 +00:00
Pierangelo Masarati
23c620a637 don't leak a BerElement 2006-04-08 17:34:00 +00:00
Kurt Zeilenga
cbc11c9233 unifdef -DLDAP_NULL_IS_NULL 2006-02-14 23:18:12 +00:00
Kurt Zeilenga
acbb5cf689 Happy new year! 2006-01-03 23:11:52 +00:00
Pierangelo Masarati
eb734a167b add severity-aware logging (ITS#4282) 2005-12-27 16:29:37 +00:00
Pierangelo Masarati
4a6f4369c0 don't malloc empty strings for matched, error 2005-11-12 18:42:03 +00:00
Howard Chu
10c94f4e58 Cleanup lbo_valid / meminuse / memfuncs 2005-11-12 18:26:17 +00:00
Howard Chu
0f9ad702c3 ITS#4046 fix recvfrom len 2005-09-28 08:36:24 +00:00
Howard Chu
2807a2596b Simplify array operations 2005-09-13 07:51:51 +00:00
Pierangelo Masarati
9129a2f7ee silence warnings 2005-09-10 18:59:35 +00:00
Hallvard Furuseth
d47eaa0ecc Fix printf formats for LDAP_MEMORY_TRACE 2005-08-02 14:08:30 +00:00
Hallvard Furuseth
5c5a834db8 Handle LBER_SB_OPT_[GS]ET_FD arg as ber_socket_t like elsewhere, not as int. 2005-08-01 03:48:53 +00:00
Pierangelo Masarati
aa0b0f642f don't malloc when not required? 2005-07-21 19:10:16 +00:00
Pierangelo Masarati
1b11741a30 mostly revert previous commit 2005-07-20 19:26:46 +00:00
Pierangelo Masarati
c789d494c4 allow to unregister (and free) memory handling functions 2005-07-20 19:07:04 +00:00
Hallvard Furuseth
81ecb0b153 assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL). 2005-07-18 06:22:33 +00:00
Pierangelo Masarati
12c32c3e6c fix previous commit 2005-04-27 02:38:55 +00:00
Pierangelo Masarati
2f877b48b1 introduce ber_bvreplace() 2005-04-21 03:40:50 +00:00
Kurt Zeilenga
dc0eacd40b Happy New Year! 2005-01-01 20:49:32 +00:00
Kurt Zeilenga
e983616d75 More NEW_LOGGING removal 2004-10-19 01:40:38 +00:00
Kurt Zeilenga
d611a4b49a unifdef -UNEW_LOGGING 2004-09-04 04:54:28 +00:00
Kurt Zeilenga
e0a9ea2f50 Move MSVC port to the Attic 2004-09-04 04:37:41 +00:00
Howard Chu
24b7f5c42c Fix 't' tag option 2004-07-09 10:19:20 +00:00
Kurt Zeilenga
93b72e36e8 cleanup 2004-06-30 22:28:15 +00:00
Kurt Zeilenga
781c2d02a1 fix Compare bug in liblber/memory.c (ITS#3116) 2004-04-26 23:16:45 +00:00
Kurt Zeilenga
62da0b6738 AC_STRERROR_R 2004-04-25 00:19:06 +00:00
Howard Chu
affe835984 NUL-terminate alloc'd berbuf (ITS#3086) 2004-04-15 10:25:14 +00:00
Kurt Zeilenga
b3fdf881c3 ITS#3072: remove extraneous assignment 2004-04-08 20:20:36 +00:00
Howard Chu
c558bd49bc ITS#2992 Windows fixes from Alexey Melnikov 2004-03-05 12:24:06 +00:00
Howard Chu
f8d54b4e87 Fix prev EBCDIC commit 2004-02-04 22:53:17 +00:00
Howard Chu
9f3b0d60f9 Fix EBCDIC conversion for syslog() 2004-02-03 03:58:38 +00:00
Kurt Zeilenga
3c598e89fb Happy new year 2004-01-01 19:15:16 +00:00
Kurt Zeilenga
c5f83acf6e cleanup 2003-12-07 05:12:36 +00:00
Howard Chu
f01c60dd66 ITS#2538 plug leak 2003-12-07 04:48:50 +00:00
Kurt Zeilenga
85013a9d98 acknowledgements and notices 2003-11-26 22:51:15 +00:00
Kurt Zeilenga
159de0f135 Updated notices and acknowledgements 2003-11-26 07:16:36 +00:00
Kurt Zeilenga
e3a4c4ec9c Notice/Acknowledge updates 2003-11-26 02:58:56 +00:00
Kurt Zeilenga
327880b984 Notice updates 2003-11-25 23:17:08 +00:00
Howard Chu
ede6ea1f64 Fix typo in LTFINISH invcation 2003-10-01 02:26:41 +00:00
Kurt Zeilenga
db097047af code cleanup 2003-07-08 03:46:20 +00:00
Hallvard Furuseth
a231098e28 Fix typo in comment 2003-06-27 19:12:07 +00:00
Hallvard Furuseth
0f29f0af96 #define *_OPT_ON &ber_pvt_opt_on. The old (void*)1 definition could be == NULL. 2003-06-06 13:50:01 +00:00
Hallvard Furuseth
1fa40181d9 Cast unsigned char *p to char *. 2003-06-03 17:51:38 +00:00
Howard Chu
a3b73b50ce Fix includes for EBCDIC 2003-05-29 10:02:10 +00:00
Howard Chu
5d0ba372e5 Fix LBER_OPT_MEMCTX behavior 2003-05-28 22:17:08 +00:00
Howard Chu
13aa48e47a Fix reading multibyte lengths 2003-05-22 06:24:23 +00:00
Kurt Zeilenga
71e0359f37 Back out last change... I forget ber_get_next eats a sequence 2003-05-22 05:41:13 +00:00
Kurt Zeilenga
6035ecfe7b Reverse unintended commit 2003-05-22 05:33:04 +00:00
Kurt Zeilenga
df1381fa38 cleanup 2003-05-22 05:32:06 +00:00
Kurt Zeilenga
a08e72a9e8 Remove wrapping sequence to align with dtest 2003-05-22 04:45:50 +00:00
Kurt Zeilenga
6d36ba9d9f Add trickle code to test ber_get_next.
Use etest {...} | dtest {...} to test.
2003-05-22 04:37:44 +00:00
Kurt Zeilenga
bfa6808c48 Fix dtest ber_get_next() usage 2003-05-22 03:35:36 +00:00
Howard Chu
3d9fd17678 ber_get_next - set errno to 0 before calling ber_int_sb_read(), otherwise
an EOF will return with the previously set errno value.
2003-05-20 04:08:35 +00:00
Jong Hyuk Choi
4f58efc4d1 - change in message to modlist conversion 2003-05-20 01:45:12 +00:00
Howard Chu
3fc96a24ee More ITS#2490 - fix retries for multi-byte lengths 2003-05-19 12:14:15 +00:00
Howard Chu
5eb0ec070c ITS#2490 - more retry checks 2003-05-19 10:37:09 +00:00
Howard Chu
9757665aed ITS#2490 - allow retry for incomplete reads of BER tag & len 2003-05-19 10:33:18 +00:00
Hallvard Furuseth
5ee9264465 Fix assignment of <char/int>* to unsigned <char/int>* and vice versa. 2003-05-02 13:29:28 +00:00
Howard Chu
23b63aac39 Free ber mem arrays in reverse order. (better for sl_free) 2003-04-29 21:09:02 +00:00
Hallvard Furuseth
778a38f49c Reduce warnings: Add missing 0 or NULL initializers for struct members. 2003-04-29 16:36:19 +00:00
Howard Chu
deea8db4cd EBCDIC fix - ber_pvt_strcopy is now lutil_strcopy 2003-04-25 12:32:15 +00:00