Commit Graph

11984 Commits

Author SHA1 Message Date
Howard Chu
fc05c63b63 ITS#8127 fix ftello for Win32 2015-05-07 10:48:42 +01:00
Emmanuel Lécharny
9f9bf53d61 ITS#8131 fix typo in prev commit 2015-05-06 16:50:41 +01:00
Howard Chu
930decf5ff ITS#8131 improve back-meta logs 2015-05-06 16:40:14 +01:00
Hallvard Furuseth
a59f336a61 ITS#8092 fix previous fix.
slap_auxprop_lookup() returns void with old sasl versions.
2015-05-04 21:05:57 +02:00
Hallvard Furuseth
f2b96c19cc Fallback typedef for slap_sasl_cb_ft 2015-05-04 20:52:00 +02:00
Quanah Gibson-Mount
2c34d2fda6 ITS#8120 Move final CHECK_CSN block to before the mutex is unlocked. 2015-04-29 22:30:17 -05:00
Jan Synacek
fb1bf1caa8 More for ITS#8105
Fix multiple argument handling. For example:

perlModuleConfig homedir /home/jsynacek

should be converted to

olcPerlModuleConfig: homedir /home/jsynacek

and not to

olcPerlModuleConfig: homedir
olcPerlModuleConfig: /home/jsynacek
2015-04-27 11:19:20 +01:00
Howard Chu
da0639a7e6 Silence warnings 2015-04-23 06:10:40 +01:00
Howard Chu
d7bf6fcaae ITS#8108 silence rootdn check on hidden backends
select_backend() skips hidden backends so it fails to match the
rootdn of a database that has been hidden. rootpw tries to see
if the rootdn matches the current backend but the check fails
when hidden. Ignore this check on hidden backends since one
cannot Bind to a hidden backend anyway.
2015-04-23 05:58:50 +01:00
Ryan Tandy
4f82c10120 ITS#8107 don't shadow rc 2015-04-23 05:16:12 +01:00
Jan Synacek
25bbf116ad ITS#8105 back-perl: correctly convert perlModuleConfig
perlModuleConfig lines are not converted when using slaptest -f -F.
2015-04-16 02:55:56 +01:00
Howard Chu
15347d1180 ITS#8103 fix crash with more than 65535 aliases in a scope 2015-04-13 13:11:29 -07:00
Howard Chu
dcd0fd27f6 ITS#8040 use NOMETASYNC for lazycommit
not NOSYNC. Might be configurable in the future, but we don't
really want to add more config options at present
2015-04-09 15:56:22 +01:00
Ondřej Kuzník
cf3e10ee15 ITS#8057 Use an actual entry for modify/modrdn checks 2015-04-08 23:26:27 +01:00
Howard Chu
525aa23800 ITS#8040 document lazycommit 2015-04-08 23:18:03 +01:00
Howard Chu
012b7f0e7d ITS#8092 no-op if there's no context 2015-04-01 21:17:35 +01:00
Howard Chu
ff7c0e5779 ITS#8081 - more for #8063
Prev patch broke underlying assumption that mods queue and execute
in order. Now must search list for matching mod to dequeue.
2015-03-21 21:32:48 +00:00
Howard Chu
8eb9aa7dc5 ITS#8063 more for prev commit 2015-02-25 06:11:44 +00:00
Howard Chu
8ad64c8f9a ITS#8063 don't block our own thread 2015-02-25 05:44:07 +00:00
Ondřej Kuzník
4b84b6af14 ITS#8057 Enforce uniqueness unless permitted by ACL 2015-02-16 17:30:59 +00:00
Quanah Gibson-Mount
1705fa7e55 Happy New Year 2015-02-11 15:36:57 -06:00
Howard Chu
129299a933 ITS#8051 use a regexp 2015-02-04 05:21:46 +00:00
Howard Chu
2fbecdd756 ITS#8051 add DN qualifier 2015-02-04 03:53:13 +00:00
Howard Chu
3b130b65a4 ITS#8049 fix typo 2015-02-04 02:40:30 +00:00
Howard Chu
2f1a2dd329 ITS#8046 fix vrFilter_free 2015-02-04 02:03:55 +00:00
Howard Chu
3349ca0bee ITS#8048 fix slapo-sock result 2015-02-03 10:35:52 +00:00
Howard Chu
cb3952db4b ITS#8039 more cleanup 2015-02-03 10:23:39 +00:00
Howard Chu
a32a2da33a ITS#8040 experimental Lazy Commit 2015-02-02 10:50:22 +00:00
Howard Chu
b1d1c74247 Cleanup prev commit 2015-02-02 08:45:57 +00:00
Howard Chu
bb9287ba1a More for ITS#8043 2015-02-02 08:42:28 +00:00
Howard Chu
bc1e08e296 ITS#8043 don't leave dangling syncops 2015-01-31 13:04:53 +00:00
Howard Chu
edf359795c ITS#8039 cleanup 2015-01-31 12:52:56 +00:00
Howard Chu
c4b43c0077 More for presentlist_free 2015-01-31 01:12:54 +00:00
Howard Chu
4929ad5e81 More for presentlist (ITS#8042) 2015-01-31 01:03:23 +00:00
Howard Chu
c8d40af0d2 ITS#8039 fix prev commit
Don't overload ri_csn with cookie, use a separate berval
2015-01-31 00:12:29 +00:00
Howard Chu
a2d4ed146d ITS#8039 plug syncprov memleak
Rewrote the psearch result handling to keep track of which
queues are using which results.
2015-01-30 08:55:47 +00:00
Howard Chu
3f5e705996 Fix prev commit 2015-01-30 08:06:11 +00:00
Howard Chu
1fa702e968 Streamline presentlist
This reduces presentlist memory usage by about 50%. It's still
about 2.5x greater than it should be.
2015-01-30 00:54:21 +00:00
Howard Chu
84fde1bb02 ITS#8038 free presentlist at end of refresh 2015-01-29 05:15:33 +00:00
Howard Chu
97ed9736e5 ITS#8036 cleanup prev commit 2015-01-27 23:53:19 +00:00
Howard Chu
217d6ffcdb ITS#8036 more for prev commit 2015-01-27 23:39:46 +00:00
Howard Chu
969d477168 ITS#8036 fix regression from ITS#7904 2015-01-27 22:26:33 +00:00
Howard Chu
b53d813413 ITS#8035 plug memleaks in syncrepl 2015-01-27 20:29:34 +00:00
Howard Chu
c5378df634 ITS#8011 fix prev patch
Remove assert. This is merely a cache of parent DNs, failure to
insert doesn't affect outcome.
2015-01-27 18:30:23 +00:00
Howard Chu
c32e74763f ITS#8027 require non-empty AttributeList 2015-01-20 11:35:40 +00:00
Howard Chu
047f275987 Fix 0e66a3d1bf
clear rc, otherwise syncrepl stops
2015-01-14 20:27:49 +00:00
Howard Chu
869324ff9f Fix typo in 45146ba21a 2015-01-14 19:05:17 +00:00
Howard Chu
30ae5fa2cf GSER issuer quoting fix (coverity) 2015-01-14 18:56:12 +00:00
Howard Chu
59ee92213b Minor cleanup (coverity) 2015-01-14 17:52:22 +00:00
Howard Chu
fccca0ead9 Minor cleanup (coverity) 2015-01-14 16:59:54 +00:00
Howard Chu
bc3dbcbde9 Minor cleanup (coverity) 2015-01-14 13:27:45 +00:00
Howard Chu
c25208cd14 Minor cleanup (coverity) 2015-01-14 12:48:44 +00:00
Howard Chu
0677f67d29 Minor cleanup (coverity) 2015-01-14 12:23:19 +00:00
Howard Chu
86d81fa153 Minor cleanup (coverity) 2015-01-14 12:16:24 +00:00
Howard Chu
e861305d50 Minor cleanup (coverity) 2015-01-14 11:30:33 +00:00
Howard Chu
0e5f63ae6d Minor cleanup (coverity) 2015-01-14 11:08:51 +00:00
Howard Chu
651804842f Fix missing error return (coverity) 2015-01-14 10:37:13 +00:00
Howard Chu
45146ba21a Fix UTF8stringvalidate loop termination (coverity) 2015-01-14 10:35:20 +00:00
Howard Chu
67c13d0ccf Fix NULL in debug output (coverity) 2015-01-14 10:22:50 +00:00
Howard Chu
0e66a3d1bf check ber_scanf(syncUUIDs) result (coverity) 2015-01-14 10:13:16 +00:00
Howard Chu
14a3efa48a plug unlikely memleak (coverity) 2015-01-13 22:48:07 +00:00
Howard Chu
74d89e567c plug memleak in cr index (coverity) 2015-01-13 22:01:17 +00:00
Howard Chu
19af642a2d ACL write/manage fixes (coverity) 2015-01-13 21:43:22 +00:00
Howard Chu
975dce7ffb varargs cleanup (coverity) 2015-01-13 18:32:28 +00:00
Howard Chu
79cce59ad4 Fix insecure chroot (coverity) 2015-01-13 18:23:16 +00:00
Howard Chu
2cf553563b Fix fprintf format (coverity) 2015-01-13 18:11:49 +00:00
Howard Chu
6046584531 ITS#8022 don't skip TLS init for ldaps:// targets 2015-01-12 22:25:53 +00:00
Howard Chu
9266a43d6c ITS#8016 return errmsg for unknown envflags 2015-01-05 09:37:27 +00:00
Leo Yuriev
67a65ec701 ITS#8011: few corrections for lmdb-backend;
dn2id.c:
  + assertion for mdb_id2l_insert() result;
  - unnecessary assignment;

search.c:
  - unused variable 'first';
  + range-check for mdb_idl_search() result;
2015-01-04 07:41:07 +00:00
Leo Yuriev
7c2951819f ITS#5452,#8012: fix syncprov syncops freeing
Detaching a syncops record from op-list conditionally,
only when it was freed by syncprov_free_syncop.

The syncprov_free_syncop() and syncprov_drop_psearch() now
returns a flag, which is nonzero if the given syncops was freed.
2015-01-04 07:27:29 +00:00
Howard Chu
0b2438fbec ITS#8013 fix syncprov_matchops test_filter usage 2015-01-04 07:20:41 +00:00
Howard Chu
c5cc2f241f ITS#8014 plug onetime leak in slapadd -w 2015-01-04 07:01:47 +00:00
Howard Chu
2930a68808 ITS#7780,#7781 fix prev commit 2014-12-18 19:35:09 +00:00
Ondřej Kuzník
8958d2b7cb ITS#7780,ITS#7781 Fix slapo-constraint with 0 count 2014-12-18 19:34:55 +00:00
Howard Chu
e8771b785c ITS#8007 fix d06f5e7c1b
duplicate OID, oops
2014-12-16 20:08:32 +00:00
Howard Chu
d06f5e7c1b ITS#8007 Add maxentrysize config option 2014-12-15 21:35:48 +00:00
Ondřej Kuzník
508f4158bc ITS#7797 Fix segfault in slapo-collect 2014-12-12 01:35:30 +00:00
Howard Chu
9accfbb73a ITS#7995 fix slap_bv2undef_ad 2014-12-10 02:06:50 +00:00
Leo Yuriev
8ba5a27829 ITS#7968 add locks for syncrepl cookiestate
Mutex must be held even for a read-access of a cookie state,
as there may be a race with write in other thread.
2014-12-05 19:44:19 +00:00
Howard Chu
b0225e8e60 ITS#7976 fix delta-mmr/accesslog interaction 2014-10-30 15:00:13 +00:00
Howard Chu
e6e073d31e ITS#7975 fix onelevel search 2014-10-29 18:05:00 +00:00
Howard Chu
10d5815c62 Fix typo in cancel config 2014-10-15 11:21:19 +01:00
Leo Yuriev
b0e46fb9f9 ITS#7965 mdb_dn2id
heap corruption due to returning a reference to a local variable
2014-10-14 13:15:16 +01:00
Quanah Gibson-Mount
db564ab516 Silence compiler warning by adding explicit return 0 to ppolicy_db_destroy 2014-10-03 15:35:39 -05:00
Howard Chu
766103a912 Fix mdb_txn cleanup 2014-09-19 19:22:14 +01:00
Howard Chu
8bdd54c4c1 ITS#7942 tweak previous commit
Only free when cleaning up operation controls, not response controls.
(This only makes a difference on search requests, which may have
multiple responses with the same set of controls.)
2014-09-18 06:49:26 +01:00
Howard Chu
9d9913392a ITS#7942 plug leak in controls 2014-09-18 02:06:38 +01:00
Howard Chu
af8f1e0741 ITS#7941 fix for repeated tags
Make sure ntags isn't incremented if we're skippnig the tag
2014-09-18 00:33:33 +01:00
Howard Chu
09137b6646 Consolidate LDAP_TXN precheck
This commit was accidentally omitted from previous push
2014-09-16 00:09:10 +01:00
Howard Chu
f9cb538fbd Add updateControls to txn response 2014-09-15 23:49:26 +01:00
Howard Chu
32f05e96f7 Flesh out txn support
Only in back-mdb; back-bdb needs work but it's deprecated;
not worth the effort. In particular txn, retry after deadlocks
makes the whole thing too messy.
2014-09-15 23:48:23 +01:00
Howard Chu
11594db633 ITS#7937 flush data to socket 2014-09-11 10:24:09 +01:00
Leo Yuriev
c1f04881be ITS#7915 fix memory leaks in previous patch 2014-09-10 11:51:44 +01:00
Howard Chu
4f66cfa1b4 ITS#7935 partially revert prev patch
Can't allow special chars in RDN, not all OSs/filesystems support it.
2014-09-09 14:40:11 +01:00
Howard Chu
f88970efc1 ITS#7935 fix schema RDN normalization 2014-09-09 14:35:43 +01:00
Howard Chu
3d52e63366 ITS#7929 don't log internal searches 2014-09-08 15:40:28 +01:00
Howard Chu
4ea2fe90e8 ITS#7934 add missing normalization of attrs 2014-09-08 14:57:57 +01:00
Jan Synacek
1ad90643b5 ITS#7933 fix frontend config 2014-09-08 14:04:38 +01:00
hyc
846cf30842 ITS#7930 additional fix
bypass cleanup handlers for suppressed search result msgs
2014-09-06 09:49:32 +01:00
hyc
18d9470984 ITS#7930 partial fix
Only restore op->o_req_dn if no one else changed it on us.
2014-09-06 09:14:46 +01:00
Howard Chu
92c7a89130 ITS#7928 fix syncprov abandon cleanup 2014-08-29 02:19:35 +01:00
Howard Chu
9a8cb6091a ITS#7702 better fix
Check for duplicate scopes in search_aliases, not later.
2014-08-28 18:21:21 +01:00
Howard Chu
f42c7c6bbc Revert "ITS#7702 fix results with aliases"
This reverts commit cac00c6a97.
2014-08-28 17:51:46 +01:00
Howard Chu
b669f5b706 ITS#7904 init wwctx earlier 2014-08-27 11:50:32 +01:00
Howard Chu
cac00c6a97 ITS#7702 fix results with aliases
Aliases pointing within the original search scope could cause
the same entry to be returned multiple times. Check for subtree
scope and duplicate scopes.
2014-08-26 20:07:40 +01:00
Howard Chu
e5f5a4ab5f ITS#7927 fix double-free of searchref 2014-08-26 19:17:33 +01:00
Howard Chu
b07e31aa02 Cleanup mdb_ad_get 2014-08-21 20:26:00 -07:00
Howard Chu
be02e8ddd0 ITS#7906,#7923 Don't free configinfo in _db_close 2014-08-20 13:49:37 -07:00
Howard Chu
3feffb9a0a ITS#7904 more tweaks
Must save/restore mcd cursor if we're doing a scope-based search.
2014-08-20 13:06:51 -07:00
Howard Chu
cd02e6054e ITS#7922 delete dead code
Harmless, but stupid.
2014-08-19 20:31:20 -07:00
Quanah Gibson-Mount
9c54ff2f0b Fix typo 2014-08-18 12:18:44 -05:00
Howard Chu
27f3ef2cfd ITS#7920 fix for slapacl
This needs to be streamlined in 2.5, current tool API is a mess.
2014-08-13 20:49:05 -07:00
Howard Chu
3f0839d8df ITS#7838 fix typos in prev commit 2014-08-13 19:53:56 -07:00
Howard Chu
10b6c9f0f2 ITS#7919 fix cache DB config
Don't accept config directives for cache DB until the cache backend type
has been set.
2014-08-13 19:22:17 -07:00
Howard Chu
d8e280e87c ITS#7906 more cleanup
db_open/close were not symmetric with init/destroy
2014-08-11 13:48:29 -07:00
Howard Chu
8b89b45615 ITS#7906 minor cleanup
rename ppolicy_close -> ppolicy_db_close for consistency
2014-08-05 19:37:28 -07:00
Howard Chu
08792a77fd ITS#7906 better fix
don't free pwcons unless we're actually destroying this DB
2014-08-05 19:36:30 -07:00
Howard Chu
7f7a82c0f5 ITS#7915 fix translucent_modify
Go directly to local backend when fetching local entry
2014-08-04 13:42:35 -07:00
Howard Chu
d8c060104d ITS#7915 fix mdb_entry_release
In server mode, make sure the entry was actually ours
2014-08-04 13:36:48 -07:00
Howard Chu
f7a2438112 ITS#7895 drop toolmode checks in str2entry
They were obsoleted by ITS#6737 and have been redundant ever since.
(commit 15f1e7bdb7)
2014-08-02 11:17:12 -07:00
Howard Chu
5ac3dbefcd ITS#7912 fix index config 2014-07-31 11:31:14 -07:00
Howard Chu
e5dae640f2 ITS#7909 fix slap_callback init 2014-07-30 06:55:36 -07:00
Quanah Gibson-Mount
e091e0bb63 ITS#7908
Add olcSssVlvMaxPerConn to the olcSssVlvConfig objectClass
2014-07-28 13:04:43 -05:00
Howard Chu
05402c396d ITS#7906 fix ppolicy_connection_destroy
It can still run after ppolicy_close has freed the connection table
2014-07-24 17:04:56 -07:00
Howard Chu
e17878933f ITS#7904 writewait patch
Assigned ITS#, tweaking. This ITS includes
	4f05d992f2
	716b35e191
	be792fae2c
2014-07-23 13:12:51 -07:00
Howard Chu
4f05d992f2 Fix prev commit 2014-07-22 21:55:23 -07:00
Howard Chu
716b35e191 More for writewait callback
Must also reset search cursors
2014-07-22 21:52:24 -07:00
Howard Chu
031640456b ITS#7903 preserve Sorted status of attrs 2014-07-22 20:24:58 -07:00
Howard Chu
f0475bab5a ITS#7902 fix str2entry / sorted vals 2014-07-22 20:21:35 -07:00
Howard Chu
be792fae2c Add sc_writewait callback
Invoked before a blocked writer waits for socket to be writable.
Use in back-mdb to release reader txn while waiting.
2014-07-22 19:17:15 -07:00
Ondřej Kuzník
a773a0cc14 ITS#7894 Let back-config use backend to release entries 2014-07-22 14:49:20 -07:00
Howard Chu
03d927485e ITS#7249 partial fix for memberof on frontendDB 2014-07-21 08:44:42 -07:00
Michael Stroeder
8605eedb31 ITS#7838 add ORDERING rules to ppolicy attrs 2014-07-18 13:04:15 -07:00
Howard Chu
8c62b323ba ITS#7868 fix slapo-sock db_init 2014-07-18 12:03:07 -07:00
Howard Chu
1f168a0b8f ITS#7893 (#6508) fix a_numvals 2014-07-09 13:07:53 -07:00
Howard Chu
b9abbdf623 Add missing mdb_strerror calls to debug msgs 2014-07-09 11:21:41 -07:00
Ondrej Kuznik
01f698bce9 ITS#7256 A few issues discovered during testing slapmodify.
- bdb deallocates cursor after some tool operations but expects it to be
  around every time it is called
- mdb tries to allocate a second transaction while it already holds one,
  deadlocking
- op->o_hdr must exist for most uses of op, but o_tmpmfuncs need not
- what about indexing after a tool modify? Does it happen automatically?
2014-07-08 17:28:12 -07:00
Ondrej Kuznik
d3a5ab824d ITS#7256 Consolidate cleanup code at one location. 2014-07-08 17:28:12 -07:00
Ondrej Kuznik
07c563b8a5 ITS#7256 Rework entry retrieval and cleanup.
When doing deletes, lastmod has no entry to work on.
2014-07-08 17:28:11 -07:00
Ondrej Kuznik
fde1f80aa8 ITS#7256 Add some necessary checks. 2014-07-08 17:28:10 -07:00
Ondrej Kuznik
304c0cbbff ITS#7256 Set backend for operation.
slap_tool_entry_check does it but it is not called every time.
2014-07-08 17:28:09 -07:00
Ondrej Kuznik
7810dccdff ITS#7256 Let slapmodify ignore unknown operations
ldapmodify already does the same.
2014-07-08 17:28:07 -07:00
Ondrej Kuznik
cede821cef ITS#7256 Allow deletes with slapmodify 2014-07-08 17:28:06 -07:00
Ondrej Kuznik
f05602927d ITS#7256 mplement bi_tool_entry_delete for back-ldif 2014-07-08 17:28:04 -07:00
Ondrej Kuznik
c048b7cad6 ITS#7256 Introduce bi_tool_entry_delete 2014-07-08 17:26:05 -07:00
Ondrej Kuznik
17e223b896 ITS#7212 rudimentary slapmodify support for back-config 2014-07-08 17:25:58 -07:00
Ondrej Kuznik
5ee5251fa4 ITS#7212 slapmodify support for back-ldif 2014-07-08 17:25:58 -07:00
Howard Chu
282d215924 Fixup for win64 commit
couldn't avoid ifdefs. Silence warnings.
2014-06-23 08:21:36 -07:00
Howard Chu
dda779d83e Windows64 32/64 silliness
On Windows64, long is the same size as int. Use size_t when we
need an actual 64 bit unsigned long.
2014-06-23 08:00:11 -07:00
Paul B. Henson
85d467aca6 ITS#7161 ppolicy pwdFailureTime resolution should be better than 1 second 2014-06-15 13:42:46 -07:00