Commit Graph

7480 Commits

Author SHA1 Message Date
Hallvard Furuseth
b1e4b27388 #include <ac/ctype.h>, needed by last commit 2005-08-08 20:19:25 +00:00
Pierangelo Masarati
b286c9264b plug another one-time leak 2005-08-08 20:01:04 +00:00
Pierangelo Masarati
64af435895 ITS#3914 bug was very close to that leak: rwm_dnattr_rewrite() already freed the original value (all this stuff may need work) 2005-08-08 19:49:48 +00:00
Pierangelo Masarati
47351e3b5c fix yet another leak (not related to ITS#3914, though) 2005-08-08 19:41:10 +00:00
Hallvard Furuseth
3142c03e5a Fix typo in previous commit (slapi_dn.c -> slapi_dn.lo) 2005-08-08 14:30:34 +00:00
Pierangelo Masarati
cccf35c749 allow textual log levels in command line 2005-08-08 14:01:40 +00:00
Luke Howard
d463430295 Remove slapi_x_be_select() 2005-08-08 13:26:02 +00:00
Luke Howard
d96f3615b3 New file - slapi_dn.c 2005-08-08 13:25:24 +00:00
Luke Howard
7d557f0b0d Add Slapi_DN API 2005-08-08 13:24:18 +00:00
Howard Chu
ae8a333bc8 ITS#3917 init schema before parsing args 2005-08-08 12:51:38 +00:00
Howard Chu
9365649dad ITS#3922 fix syncrepl ctxcsn leak 2005-08-08 12:38:19 +00:00
Luke Howard
3858ce0728 Add slapi_x_be_select() (to be replaced with slapi_be_select() when
we support Slapi_DN API)
2005-08-08 11:01:39 +00:00
Luke Howard
ef81368404 Don't return frontend as SLAPI_BACKEND, return actual backend instead
for compat with 2.2 plugins

Add a couple of backend SLAPI APIs
2005-08-08 09:33:02 +00:00
Luke Howard
17ffdc07b6 Don't decrement descriptor count until we have checked connection is not UDP 2005-08-08 03:44:17 +00:00
Luke Howard
0dd503a339 Add missing break statement in switch for SLAPI_SEARCH_ATTRS handler 2005-08-08 03:39:00 +00:00
Pierangelo Masarati
e24cc0589f more cleanup 2005-08-07 22:22:27 +00:00
Pierangelo Masarati
d79d9be840 free Env 2005-08-07 21:53:38 +00:00
Pierangelo Masarati
3d075186bf don't leak entry/referrals in case of reference 2005-08-07 21:26:15 +00:00
Pierangelo Masarati
09f749da96 remove unnecessary data from search_info 2005-08-07 20:43:07 +00:00
Pierangelo Masarati
779d94312f cleanup candidate list in case of abandon, even if it occurs while selecting candidates 2005-08-07 20:11:41 +00:00
Pierangelo Masarati
433c7923c5 cleanup candidate list in case of abandon 2005-08-07 20:04:47 +00:00
Pierangelo Masarati
125059ccb5 more cleanup 2005-08-07 18:56:19 +00:00
Pierangelo Masarati
92527ee15b plug more leaks; few remain (but seem to be in ODBC) 2005-08-07 17:28:26 +00:00
Pierangelo Masarati
52fb4b47fe fix previous commit 2005-08-07 16:48:26 +00:00
Pierangelo Masarati
8fdfe1fcd0 plug yet another one-time leak 2005-08-07 16:45:13 +00:00
Pierangelo Masarati
ca00d860d6 plug selected leaks at shutdown 2005-08-07 16:38:20 +00:00
Pierangelo Masarati
a6d4a82782 more about freeing replica resources 2005-08-07 15:20:14 +00:00
Pierangelo Masarati
e549e4463a free replica info as appropriate 2005-08-07 15:01:13 +00:00
Pierangelo Masarati
d8a90fd7d5 cleanup resources 2005-08-07 14:13:29 +00:00
Pierangelo Masarati
468e03a655 plug more leaks 2005-08-07 12:55:15 +00:00
Pierangelo Masarati
c3b977b2da ACL logging was incomplete (and misleading) 2005-08-07 11:36:18 +00:00
Pierangelo Masarati
be355833a0 fix use of uninitialized value; beautify logs 2005-08-07 10:49:40 +00:00
Pierangelo Masarati
e281e08e79 remove cruft 2005-08-07 10:49:01 +00:00
Luke Howard
bba3f62bdc Always restore op->o_callback in SLAPI overlay - was spinning indefinitely 2005-08-07 03:13:57 +00:00
Pierangelo Masarati
fa27310d77 use trylock only where necessary 2005-08-07 00:35:11 +00:00
Pierangelo Masarati
47d39181d6 cleanup 2005-08-06 21:03:26 +00:00
Pierangelo Masarati
8b54d3b7e1 fix potential leak (if URL form is broken); cleanup 2005-08-06 20:56:02 +00:00
Luke Howard
6911e0022b Plug some leaks in SLAPI modifications handling 2005-08-06 14:58:25 +00:00
Pierangelo Masarati
682a1981a1 use macros instead of literals 2005-08-06 11:29:08 +00:00
Pierangelo Masarati
955253966b fix ordered indexing check 2005-08-05 00:08:22 +00:00
Pierangelo Masarati
cc361f7aa0 don't need compare if entry_get is available 2005-08-03 00:33:37 +00:00
Pierangelo Masarati
61f11773ba address ITS#3914 2005-08-02 23:22:10 +00:00
Pierangelo Masarati
4ed743cc84 remove unrequired member; address ITS#3913 2005-08-02 22:48:30 +00:00
Pierangelo Masarati
9da3dbf3c8 more fixes to parsing of (deprecated) config directives (ITS#3915) 2005-08-02 22:21:44 +00:00
Luke Howard
b620a0e23c slapi/slapi_utils.c rev 1.172 removed the 'dup' parameter to
slapi_int_ldapmods2modifications(), but a 'dup' test remains in the
function body. Should always evaluate to TRUE.
2005-08-02 16:12:09 +00:00
Hallvard Furuseth
cc79022b71 Cleanup (unused variable ad_oldest) 2005-08-02 10:36:48 +00:00
Howard Chu
b98d3b5903 ITS#3912 missed an invocation of entry_schema_check in last round of changes 2005-08-02 09:44:44 +00:00
Hallvard Furuseth
ad0be35f47 Remove unused variable. 2005-08-02 08:50:02 +00:00
Hallvard Furuseth
a3f3143cc5 Fix off-by-one pointer error. Garbage byte between uuid and csn in slog_entry. 2005-08-02 08:43:27 +00:00
Pierangelo Masarati
4148ddc31f save 1 function call... 2005-08-02 08:13:16 +00:00
Pierangelo Masarati
673ea82eab fix typo in previous commit 2005-08-01 23:40:40 +00:00
Pierangelo Masarati
c8a5fd2df2 fix various leaks 2005-08-01 23:32:14 +00:00
Pierangelo Masarati
9a64785e4d plug leaks; fix map initialization 2005-08-01 22:40:18 +00:00
Howard Chu
91ea3a113a Add static build for accesslog 2005-08-01 22:02:23 +00:00
Luke Howard
12d006d17d Add o_no_schema_check to operation structure
entry_schema_check() nows takes Operation instead of Backend as first
argument, allows it to check o_no_schema_check
2005-08-01 15:26:13 +00:00
Luke Howard
381a4d62c5 SLAPI no longer needs to be initialized here 2005-08-01 15:25:17 +00:00
Luke Howard
b1f478f161 Add slapi_dn_isbesuffix()
Fix slapi_dn_beparent() logic
Fix slapi_int_ldapmods2modifications() memory management, values
always need to be duplicated because of prettying in slap_mods_check()
2005-08-01 15:24:46 +00:00
Luke Howard
9a45f87ede Fix crasher in SLAPI_SEARCH_ATTRS handler
Add SLAPI_X_OPERATION_NO_SCHEMA_CHECK, SLAPI_X_MANAGEDIT
Fix modlist memory management
2005-08-01 15:24:02 +00:00
Luke Howard
65ac57bcac Plug leaks 2005-08-01 15:23:12 +00:00
Luke Howard
e70ab8655c Centralize SLAPI initialization into slapi_over_config() 2005-08-01 15:22:56 +00:00
Hallvard Furuseth
5949d65b57 Plug memory leak 2005-08-01 03:58:43 +00:00
Hallvard Furuseth
486bfe7e17 slap_mods2entry(,,,dup=1,,,) realloced insufficient space for attr->a_nvals 2005-08-01 03:56:36 +00:00
Luke Howard
71d76fbeba slap_mods2entry() should not zero pointers into the modifications
list because checking is performed on these, rather than the entry.

slap_mods_free() now takes an extra argument indicating whether to
free the values or not.
2005-08-01 02:16:02 +00:00
Hallvard Furuseth
e404a15082 Cleanup 2005-07-31 18:17:13 +00:00
Luke Howard
2b5cf310e6 Fix slapi_dn_beparent() behaviour (again) 2005-07-31 14:17:36 +00:00
Luke Howard
f0101fe5a7 Fix slapi_dn_beparent() logic 2005-07-31 06:45:39 +00:00
Luke Howard
040a0956ac Support SLAPI_X_OPERATION_DELETE_GLUE_PARENT 2005-07-31 05:42:51 +00:00
Luke Howard
1a2f3b5f2d Restore 2.2 SLAPI behaviour: target DN is not normalized
(actually, in 2.2 the target DN was not even prettied, but this
will do)
2005-07-31 05:23:56 +00:00
Luke Howard
d0ad4b3f3e Allow overlays to override operational attributes on add (needed
to preserve 2.2 SLAPI behaviour; see comments for further info)
2005-07-31 05:19:37 +00:00
Luke Howard
30610c6f70 Fix logic error in slap_mods2entry() 2005-07-31 05:12:20 +00:00
Luke Howard
40ec064b66 Fix logic error in slap_mods_no_repl_user_mod_check() 2005-07-31 05:04:37 +00:00
Luke Howard
6f0edd6c22 Call slap_mods2entry() in do_add(), so that global overlays (including
global SLAPI plugins) have access to op->ora_e.

Note that slap_mods2entry() is still called in fe_op_add() in order to
add any operational attributes.
2005-07-31 04:56:27 +00:00
Hallvard Furuseth
014393dfa2 Initialize a_flags of new Attribute in str2entry2(). 2005-07-30 23:54:00 +00:00
Hallvard Furuseth
42a9661071 Initialize i (#changes) if no mods. Simplify (*modp) to lmod. 2005-07-30 23:46:07 +00:00
Hallvard Furuseth
80275d382b Remove warning that HDB code is experimental and unsupported 2005-07-30 23:42:41 +00:00
Hallvard Furuseth
e1742d1cb4 Change diskNode.(n)rdn from unsigned char to char, matching their usage. 2005-07-30 23:39:44 +00:00
Hallvard Furuseth
20cde48439 Remove ";" after do{...}while(0) macros 2005-07-30 23:36:38 +00:00
Hallvard Furuseth
9601e1e7ec serialNumberAndIssuerPretty() and serialNumberAndIssuerNormalize()
were confused about realloced memory.
2005-07-30 23:30:42 +00:00
Pierangelo Masarati
d921f216ac fix referrals handling (needs work) 2005-07-30 16:25:18 +00:00
Pierangelo Masarati
d959d771bf support increment; don't bother too much about return values of send_search_* functions 2005-07-30 15:00:41 +00:00
Pierangelo Masarati
40badfc664 fix conditional compilation of config schema 2005-07-30 12:20:52 +00:00
Pierangelo Masarati
6fe8f5dd18 ...otherwise it doesn't work with overlays 2005-07-30 10:37:34 +00:00
Luke Howard
f5afe4fdc7 Back out previous commit, appears not to match frontend - still
investigating
2005-07-30 08:30:36 +00:00
Luke Howard
98e49eca60 slapi_add_internal_pb() should not set op->ora_e, this is done by frontend 2005-07-30 08:19:26 +00:00
Luke Howard
60e17c1fff Don't instantiate SLAPI overlay in tool mode 2005-07-29 16:45:25 +00:00
Howard Chu
be4e918799 Add note about core.ldif and openldap.ldif 2005-07-29 12:19:08 +00:00
Howard Chu
d982beeb87 Install LDIF schema files too 2005-07-29 12:09:39 +00:00
Howard Chu
53d94be203 Fix install-schema - move old schema dir out of the way, always install
a fresh copy of everything.
2005-07-29 12:06:12 +00:00
Pierangelo Masarati
f76e1055f8 treat extra args as errors 2005-07-29 09:01:44 +00:00
Howard Chu
9164a4790d ITS#3900 move olcDefaultSearchBase to frontend DB
expose config DB
2005-07-29 02:48:31 +00:00
Pierangelo Masarati
aace773cb6 more table-driven config cleanup 2005-07-29 01:00:48 +00:00
Pierangelo Masarati
7b1fae08c7 don't complain during EMIT 2005-07-28 18:25:43 +00:00
Pierangelo Masarati
614d936ef4 suffix must be present (ITS#3901) 2005-07-28 16:54:49 +00:00
Luke Howard
0582504893 Remember to NULL terminate control arrays - not sure how I managed to
make this error in multiple places
2005-07-28 09:56:55 +00:00
Luke Howard
f32bfe729f pblock_add_control() needs to call slapi_dup_control() 2005-07-28 09:48:44 +00:00
Luke Howard
f1e604a3ac Add slapi_int_dn_pretty()/slapi_int_dn_normalize() to support plugins
that override distinguishedName syntax and matching rule
2005-07-28 09:02:13 +00:00
Luke Howard
e4ff86c198 Add slapi_over_call_plugins() to ensure that global plugins are
invoked from slap_callbacks
2005-07-28 08:52:50 +00:00
Luke Howard
53ad7ffbff Add some debugging for failed plugin loads 2005-07-28 08:35:28 +00:00
Pierangelo Masarati
e8c4911a39 check return value from add (ITS#3891) 2005-07-28 00:06:14 +00:00
Luke Howard
06f8a27771 Add pblock_be_call() for calling against actual backend 2005-07-27 16:29:32 +00:00
Luke Howard
2ffdbf7fef Fix memory management regressions in pblock modifications handling
Fix backwards logic in slapi_attr_types_equivalent()
2005-07-27 16:11:12 +00:00
Hallvard Furuseth
3226cdf2a3 bdb_locker_id, bdb_locker_id_free: BerkeleyDB lock ids are u_int32_t, not int. 2005-07-27 12:19:16 +00:00
Luke Howard
38f10e1f63 PBlock SlapReply needs to be a pointer into that supplied by caller
for overlay ops
2005-07-27 10:09:44 +00:00
Hallvard Furuseth
a9aa5050f8 Silence warning 2005-07-27 09:34:05 +00:00
Luke Howard
fe8c0553d3 Zero new superior before calling pblock_set_dn() 2005-07-27 09:26:42 +00:00
Hallvard Furuseth
f6f367fda6 pb in slapi_op_func was freed uninitialized if preop_type==0 && !internal_op 2005-07-27 09:13:30 +00:00
Hallvard Furuseth
5a6eabb69d Silence unused variable warnings 2005-07-27 08:52:32 +00:00
Hallvard Furuseth
202b309dd1 Silence unused variable warnings with #ifdef LDAP_DYNAMIC_OBJECTS 2005-07-27 08:50:37 +00:00
Hallvard Furuseth
f5dd017738 Silence warnings (rearrange if(dryrun) vs. if(verbose) 2005-07-27 08:48:43 +00:00
Hallvard Furuseth
397d7171c0 Silence unused variable warnings with #ifdef LDAP_CONTROL_X_CHAINING_BEHAVIOR 2005-07-27 08:44:11 +00:00
Luke Howard
197bc7bba9 s/op_compare/op_delete for LDAP_REQ_DELETE 2005-07-27 08:32:31 +00:00
Luke Howard
f87a07910f Support object extensions on internal SLAPI operations 2005-07-26 09:56:18 +00:00
Luke Howard
edc575888c slapi_op_type_to_string/slapi_op_get_type implementation 2005-07-26 04:34:23 +00:00
Pierangelo Masarati
111f5fdc5c more fixes to back-ldap runtime configuration (ITS#3895) 2005-07-26 00:11:11 +00:00
Pierangelo Masarati
e161f50ac0 silence warning 2005-07-25 23:06:12 +00:00
Hallvard Furuseth
f020796f73 Update previous fix: utime() needs <sys/types.h> as well as <utime.h> on Linux 2005-07-25 22:53:21 +00:00
Pierangelo Masarati
a6d9e7d933 use operation slab for column binding 2005-07-25 22:11:09 +00:00
Pierangelo Masarati
f423e65d58 fix operational attributes collection (ITS#3882) 2005-07-25 21:57:20 +00:00
Hallvard Furuseth
6d6a4b7dda Cast unsigned char*slotbuf passed as char* 2005-07-25 21:05:52 +00:00
Hallvard Furuseth
d9889aebd2 Fix debug format %d -> %lu 2005-07-25 21:03:08 +00:00
Pierangelo Masarati
739128a016 silence warning(s) 2005-07-25 20:50:33 +00:00
Pierangelo Masarati
0de20c028f destroy limits at exit 2005-07-25 20:50:03 +00:00
Pierangelo Masarati
136fe60e0e improve verbstomask diagnostics 2005-07-25 20:48:24 +00:00
Pierangelo Masarati
a91ebfac79 plug leaks 2005-07-25 20:47:39 +00:00
Pierangelo Masarati
5ecdfd13b4 cleanup 2005-07-25 20:47:01 +00:00
Luke Howard
cdefacccc6 Fix ITS#3882 2005-07-25 13:19:38 +00:00
Luke Howard
88737d900a more cleanups 2005-07-25 13:17:15 +00:00
Luke Howard
48c951007a Harmonize Slapi_PBlock field nomenclature with rest of slapd 2005-07-25 11:13:15 +00:00
Luke Howard
ba8acc0c4a However, SLAPI_PLUGIN_VERSION is treated as an opaque type 2005-07-25 10:55:37 +00:00
Luke Howard
4836f2a5c5 Heads up: fix for SLAPI compliance: when calling slapi_pblock_set() with
an integer or long integer parameter, the value argument is a pointer to
the integeral value rather than the value itself.
2005-07-25 10:53:45 +00:00
Luke Howard
93540e339a Use SLAPI_LOG_OPERATION instead of private flag 2005-07-25 10:24:02 +00:00
Luke Howard
7a69353aac Even more SLAPI cleanups 2005-07-25 10:10:58 +00:00
Luke Howard
ddbbbe2348 more SLAPI cleanups 2005-07-25 10:06:03 +00:00
Luke Howard
1254419f16 More SLAPI cleanups 2005-07-25 09:54:13 +00:00
Luke Howard
bb04c4eb9d Fix pblock_delete_param(), this function never worked 2005-07-25 05:38:31 +00:00
Luke Howard
43ec05a45a use slapi_pblock_delete_param() 2005-07-25 05:03:09 +00:00
Luke Howard
8d48005d83 Careful not to disturb result codes 2005-07-25 04:43:07 +00:00
Luke Howard
4c513d05f7 plug leak 2005-07-25 04:39:58 +00:00
Luke Howard
eec4651913 Don't discard plugin status code 2005-07-25 04:31:16 +00:00
Luke Howard
48d1046a35 Make slapi_pblock directly overlaid on operation/connection/slapreply
structures

This removes a lot of copying. It's still a bit tricky where the internal
slapd data types are different to those exposed via SLAPI (eg. modifications)
or the internal values are not allocated on the heap (eg. controls). Some
copying is necessary in these cases.
2005-07-25 04:19:33 +00:00
Pierangelo Masarati
3e84f692aa there might definitely be concurrency issues, but it's not pooled connections' fault 2005-07-23 22:03:35 +00:00
Pierangelo Masarati
e810105f87 (mostly) reverting previous commit (overconservative) 2005-07-23 22:02:12 +00:00
Pierangelo Masarati
796316bc84 strengthen concurrency protection 2005-07-23 19:39:51 +00:00
Pierangelo Masarati
bea2e5494c reverse logic (chasing a dangling pointer...) 2005-07-23 19:38:57 +00:00
Pierangelo Masarati
2b34c829d2 cleanup 2005-07-23 19:16:50 +00:00
Pierangelo Masarati
4655f12858 same for overlays; fix typo ("Overlays" instead of "Overlay" in parent entry) 2005-07-23 15:55:29 +00:00
Pierangelo Masarati
5aadfdfedb add back-config suppor to back-monitor; advertize what backends provide back-config support; HEADS-UP: changed monitor OIDs (reflected in OID repository) 2005-07-23 15:29:16 +00:00
Luke Howard
69230b2b9f more slapi cleanup 2005-07-23 13:21:28 +00:00
Luke Howard
35942c40ae update for new backend types 2005-07-23 13:14:13 +00:00
Luke Howard
92df34238a Cleanup of SLAPI internal operation code; use frontendDB rather than
duplicating frontend code, and o->o_callback rather than overriding
entry send clalbacks.

Support for SLAPI internal operation plugins.
2005-07-23 12:03:13 +00:00