Howard Chu
14c5a5dff1
Revert "ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE"
...
This reverts commit 372b3ddb85
.
Original code works as designed.
2013-04-14 16:53:30 -07:00
Claude Brisson
372b3ddb85
ITS#7570 fix MDB_GET_MULTIPLE and MDB_NEXT_MULTIPLE
2013-04-11 15:10:23 -07:00
Howard Chu
fbe6a6051b
Fix 227329c8e1
...
mdb_dbi_close() must allow any dbi < maxdbs, since opens in an
uncommitted txn don't increment env->me_numdbs.
2013-04-07 19:21:46 -07:00
Howard Chu
e43fa77eaa
Revert "Fix 6beaad52129da5353fd40c0ec48e6a78c4f71a2e"
...
This reverts commit 8eef7a4275
.
Previous commit was correct, duplicate keys should not appear here.
2013-04-05 03:44:56 -07:00
Howard Chu
227329c8e1
Fixes for dbi_open/close, ITS#7515
2013-04-05 02:58:08 -07:00
Howard Chu
6b46799379
ITS#7561 Fix mdb_drop bugs
...
Check for overflow pages, reset cursor position properly.
2013-04-04 16:52:55 -07:00
Howard Chu
8eef7a4275
Fix 6beaad5212
...
In APPEND don't immediately reject matching key, since this
is valid for APPENDDUP.
2013-04-04 07:25:21 -07:00
Howard Chu
6beaad5212
Fix d3990eb2f8
...
Append mode should *reject* keys that are too small.
Also allow APPENDDUP in mdb_put().
2013-04-03 18:26:41 -07:00
Howard Chu
e31d748dbe
Fix rebalance when collapsing root page
...
When fixing other cursors, must also fix their depth.
2013-04-01 20:34:40 -07:00
Howard Chu
cb1cc64831
More fixes for MDB_LAST
...
Make sure C_INITIALIZED gets set on successful call
2013-04-01 19:49:40 -07:00
Howard Chu
3213fc4db7
ITS#7556 fix cursor_sibling for PREV
2013-04-01 19:06:05 -07:00
Hallvard Furuseth
7d643d3acb
Plug MDB memory leak of DB names.
2013-03-31 23:50:02 +02:00
Hallvard Furuseth
ccb7b26916
Silence signedness warning
2013-03-31 23:48:10 +02:00
Hallvard Furuseth
a70b026f6b
Fix MDB_DEBUG compile when no varargs macros.
...
Variables mdb_debug, mdb_debug_start were used undefined.
2013-03-31 23:47:45 +02:00
Howard Chu
30da15a18d
Tweak mode_t def per Hallvard's suggestion
2013-03-31 20:56:08 +01:00
Howard Chu
0c568117ce
MSVC doesn't define mode_t
2013-03-31 08:10:43 -08:00
Howard Chu
7aae15739b
Fix CURSOR_LAST/CURSOR_PREV
2013-03-29 01:08:06 -07:00
Howard Chu
863fa77a08
ITS#7553 better fix
2013-03-26 11:24:59 -07:00
Howard Chu
8a99b00acc
ITS#7553 deinit cursor after deleting last node
2013-03-25 12:15:53 -07:00
Howard Chu
bccbcd1938
Silence stupid warnings
2013-03-25 11:53:32 -07:00
Claude Brisson
bbb27cde4a
bugfix for mdb_cursor_put with MDB_MULTIPLE
...
If the variable dkey.mv_size is non-zero, then it means dkey
contains some original data which has to be put back in the
child db, typically when the child db has just been created.
But when using MDB_MULTIPLE, if this variable has not been
reset to zero, we may come back to this section and wrongly
think that there is some original data to be taken care of.
2013-03-23 14:03:12 -07:00
Howard Chu
77001f549b
ITS#7538 fallout from ITS#7536 fix.
...
Allow leaf pages to have only 1 key.
2013-03-12 17:29:34 -07:00
Howard Chu
3247d7cbd6
Precalculate max size of a node
2013-03-12 17:25:49 -07:00
Howard Chu
8c1d95a438
Fix f97552a83a
...
Causes Bus Error on SPARC
2013-03-11 10:28:25 -07:00
Howard Chu
f80171e079
Check for MADV_RANDOM
...
Android supports madvise but not posix_madvise
2013-03-11 06:04:54 -07:00
Howard Chu
9c4ee82297
ITS#7377 Fix c0f3d9b9a8
...
Add missing parens
2013-03-11 05:59:07 -07:00
Howard Chu
b1da555c4c
Turn off readahead on main mmap
...
It's harmful when the DB is larger than RAM.
2013-03-11 05:49:14 -07:00
Howard Chu
d74330128a
ITS#7536 fix mdb_rebalance
...
A page must always have at least 2 keys (unless it's a root page)
2013-03-06 15:10:22 -08:00
Howard Chu
6dab37f2ac
Use CC/LDFLAGS to link the shared lib
2013-02-25 05:06:51 -08:00
Howard Chu
d8b407d9a2
Install manpages too
2013-02-25 02:02:15 -08:00
Howard Chu
26e4222ffb
Delete obsolete @todo
...
We do it now... (coalescing freelist entries in page_alloc)
2013-02-24 23:43:36 -08:00
Howard Chu
58e27b6c20
Add sample apps for comparison/education purposes
2013-02-24 23:43:18 -08:00
Howard Chu
66c9f03055
Add $(DESTDIR) to make install target
2013-02-25 06:50:51 +00:00
Howard Chu
3394bac2c0
Update error code instances
2013-02-20 05:08:52 -08:00
Hallvard Furuseth
80cd881184
Tweak MDB_INCOMPATIBLE description
2013-02-20 12:19:45 +01:00
Hallvard Furuseth
fbd76c44e4
Tweak prev commit: Restore if-test as an assert
2013-02-20 09:08:41 +01:00
Hallvard Furuseth
208e5c614d
ITS#7515 Fix mdb_txn_commit(nested txn).
...
Don't modify the parent txn until the current txn cannot fail.
Don't assume new dirty child pgnos > dirty parent pgnos.
Page alloc/touch: Fail if child+parent dirty pages would exceed
dirty_list's maxsize. Avoids an error situation in commit.
2013-02-19 18:44:10 -08:00
Hallvard Furuseth
f43ae20be7
ITS#7512 Plug mdb_txn_abort(nested txn) page leaks.
...
Also catch mdb_cursor_shadow() errors.
2013-02-19 22:03:04 +01:00
Hallvard Furuseth
f97552a83a
Check DB flags when refreshing a stale MDB DBI.
...
It's hairy to figure out when a DBI is valid. Catch destructive
user errors, and flags which another process changed under us.
2013-02-19 22:02:37 +01:00
Hallvard Furuseth
2dbb8bb833
mdb_cursor_prev,mdb_cursor_next: Fix return value.
...
Return mdb_node_read()'s return value if it fails, not 1.
(Can happen if mdb_page_get() fails and NDEBUG is #defined.)
2013-02-19 22:02:15 +01:00
Hallvard Furuseth
e4af9ee5da
ITS#7515 mdb_dbi_open(): Also open in parent txns.
...
This makes aborting nested and non-nested txns more
similar: The new DBI is available to the surrounding
context (parent txn and MDB_env respectively).
2013-02-19 22:01:29 +01:00
Hallvard Furuseth
4b67270374
mdb_page_alloc(): Handle freeDB txnid range holes.
...
A txn writes no freeDB entry if previous txn dropped mainDB and a read
txn prevents freelist entry reuse. This surprised mdb_page_alloc (and
mdb_txn_commit too before 65c053a6e7
).
2013-02-19 21:17:33 +01:00
Hallvard Furuseth
f19655eabc
ITS#7517 Document that dirty DBs may not be closed
2013-02-19 21:15:26 +01:00
Hallvard Furuseth
8ad25001ff
ITS#7485 Document key/data size limits in lmdb.h.
...
mdb.c already describes them. The user doc should too.
2013-02-19 21:14:23 +01:00
Hallvard Furuseth
ef25056cfb
Revert "ITS#7515 update parent's mt_next_pgno on child commit"
...
This reverts commit fd4861bf00
.
It duplicated earlier code.
2013-02-17 08:42:14 +01:00
Howard Chu
fd4861bf00
ITS#7515 update parent's mt_next_pgno on child commit
2013-02-17 00:49:53 +00:00
Howard Chu
890f1da3ee
Don't limit retries when coalescing freelist
...
Try to use whatever's available.
2013-02-17 00:48:43 +00:00
Hallvard Furuseth
00d7a96bd5
ITS#7515 Fix MDB parent/child txn interaction.
...
mdb_txn_commit(child): Copy more state. Copy all of mt_dbs:
Include mainDB, and even freeDB since mdb_drop() can update
it. Don't skip DBs with unchanged root, this could break
when the new was newly opened and the old unused junk.
mdb_page_get(): Search parents' dirty lists.
2013-02-16 19:11:20 +01:00
Hallvard Furuseth
d90581fa5a
ITS#7377 Catch MDB failure updating root pointers.
...
"cannot fail" was wrong, it fails at least when exceeding mapsize.
2013-02-16 19:08:54 +01:00
Hallvard Furuseth
c7db955a94
ITS#7517 Don't save dropped dirty MDB databases.
...
mdb_txn_commit's attempt to save the DB could corrupt another DB if
another thread had called mdb_dbi_open and reused the closed DBI.
2013-02-16 19:08:37 +01:00