Commit Graph

7220 Commits

Author SHA1 Message Date
Pierangelo Masarati
0de20c028f destroy limits at exit 2005-07-25 20:50:03 +00:00
Pierangelo Masarati
136fe60e0e improve verbstomask diagnostics 2005-07-25 20:48:24 +00:00
Pierangelo Masarati
a91ebfac79 plug leaks 2005-07-25 20:47:39 +00:00
Pierangelo Masarati
5ecdfd13b4 cleanup 2005-07-25 20:47:01 +00:00
Luke Howard
cdefacccc6 Fix ITS#3882 2005-07-25 13:19:38 +00:00
Luke Howard
88737d900a more cleanups 2005-07-25 13:17:15 +00:00
Luke Howard
48c951007a Harmonize Slapi_PBlock field nomenclature with rest of slapd 2005-07-25 11:13:15 +00:00
Luke Howard
ba8acc0c4a However, SLAPI_PLUGIN_VERSION is treated as an opaque type 2005-07-25 10:55:37 +00:00
Luke Howard
4836f2a5c5 Heads up: fix for SLAPI compliance: when calling slapi_pblock_set() with
an integer or long integer parameter, the value argument is a pointer to
the integeral value rather than the value itself.
2005-07-25 10:53:45 +00:00
Luke Howard
93540e339a Use SLAPI_LOG_OPERATION instead of private flag 2005-07-25 10:24:02 +00:00
Luke Howard
7a69353aac Even more SLAPI cleanups 2005-07-25 10:10:58 +00:00
Luke Howard
ddbbbe2348 more SLAPI cleanups 2005-07-25 10:06:03 +00:00
Luke Howard
1254419f16 More SLAPI cleanups 2005-07-25 09:54:13 +00:00
Luke Howard
bb04c4eb9d Fix pblock_delete_param(), this function never worked 2005-07-25 05:38:31 +00:00
Luke Howard
43ec05a45a use slapi_pblock_delete_param() 2005-07-25 05:03:09 +00:00
Luke Howard
8d48005d83 Careful not to disturb result codes 2005-07-25 04:43:07 +00:00
Luke Howard
4c513d05f7 plug leak 2005-07-25 04:39:58 +00:00
Luke Howard
eec4651913 Don't discard plugin status code 2005-07-25 04:31:16 +00:00
Luke Howard
48d1046a35 Make slapi_pblock directly overlaid on operation/connection/slapreply
structures

This removes a lot of copying. It's still a bit tricky where the internal
slapd data types are different to those exposed via SLAPI (eg. modifications)
or the internal values are not allocated on the heap (eg. controls). Some
copying is necessary in these cases.
2005-07-25 04:19:33 +00:00
Pierangelo Masarati
3e84f692aa there might definitely be concurrency issues, but it's not pooled connections' fault 2005-07-23 22:03:35 +00:00
Pierangelo Masarati
e810105f87 (mostly) reverting previous commit (overconservative) 2005-07-23 22:02:12 +00:00
Pierangelo Masarati
796316bc84 strengthen concurrency protection 2005-07-23 19:39:51 +00:00
Pierangelo Masarati
bea2e5494c reverse logic (chasing a dangling pointer...) 2005-07-23 19:38:57 +00:00
Pierangelo Masarati
2b34c829d2 cleanup 2005-07-23 19:16:50 +00:00
Pierangelo Masarati
4655f12858 same for overlays; fix typo ("Overlays" instead of "Overlay" in parent entry) 2005-07-23 15:55:29 +00:00
Pierangelo Masarati
5aadfdfedb add back-config suppor to back-monitor; advertize what backends provide back-config support; HEADS-UP: changed monitor OIDs (reflected in OID repository) 2005-07-23 15:29:16 +00:00
Luke Howard
69230b2b9f more slapi cleanup 2005-07-23 13:21:28 +00:00
Luke Howard
35942c40ae update for new backend types 2005-07-23 13:14:13 +00:00
Luke Howard
92df34238a Cleanup of SLAPI internal operation code; use frontendDB rather than
duplicating frontend code, and o->o_callback rather than overriding
entry send clalbacks.

Support for SLAPI internal operation plugins.
2005-07-23 12:03:13 +00:00
Luke Howard
9a1c8cdb88 Allow sml_desc to be set by caller in slap_mods_check() 2005-07-23 12:00:52 +00:00
Luke Howard
efa1ba86bf set o_callback to NULL for read entry callback, avoids crash in replog callback 2005-07-23 11:55:09 +00:00
Pierangelo Masarati
4c1339cf22 add infrastructure to register verbmasks; allow to register loglevels programmatically; cleanup glue protos 2005-07-23 11:32:10 +00:00
Pierangelo Masarati
d2b863fa24 fix previous commit (see NOTE and FIXMEs) 2005-07-23 10:29:40 +00:00
Luke Howard
9e4ea429e5 Add fe_access_allowed(), should allow global ACL overlays to work 2005-07-23 04:18:48 +00:00
Pierangelo Masarati
bccf2a7282 backout previous commit: frontendDB doesn't have the right rootn, ACLs and so 2005-07-22 17:22:51 +00:00
Pierangelo Masarati
02870e815b renamed slapi_int_init_connection => slapi_int_connection_init for consistency; blind fix to ITS#3879 2005-07-22 16:57:20 +00:00
Pierangelo Masarati
9cb512bc03 exit the loop at some point (ITS#3878) 2005-07-22 16:37:20 +00:00
Hallvard Furuseth
a7f82239b6 assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL). 2005-07-22 14:35:16 +00:00
Hallvard Furuseth
cc27d26f48 rs->sr_flags should be saved in variables of type slap_mask_t, not int. 2005-07-22 13:28:49 +00:00
Hallvard Furuseth
4a57978a4b '#if 0' out variables used only in #if 0. Fix '#if 0'-ed out counting loops. 2005-07-22 13:21:10 +00:00
Hallvard Furuseth
100634c920 Remove unused variables. 2005-07-22 13:18:28 +00:00
Luke Howard
1c6124019f remove redundant variable 2005-07-22 09:40:22 +00:00
Luke Howard
645923b273 Remove redundant ACL check in operational attributes overlay 2005-07-22 09:39:36 +00:00
Luke Howard
db3cc3ea22 Cleanup SLAPI headers 2005-07-22 09:35:27 +00:00
Luke Howard
a8980ffe9e Do not cache group evaluation if result is SLAP_CB_CONTINUE 2005-07-22 08:27:51 +00:00
Luke Howard
3e47ba5aef Fix bug in control merging (this probably still isn't right...) 2005-07-22 08:26:20 +00:00
Luke Howard
77ced839c0 Add caching to slapi_over_acl_group(); performance is terrible otherwise 2005-07-22 08:23:33 +00:00
Luke Howard
e6ed981ab9 Don't fail if no group plugins 2005-07-22 07:55:45 +00:00
Luke Howard
cb786e3330 Remove SLAPI pblock from operation structure 2005-07-22 07:54:17 +00:00
Luke Howard
0799e6a246 more cleanups 2005-07-22 06:46:07 +00:00
Luke Howard
95b0b26ad5 cleanup SLAPI overlay 2005-07-22 06:24:39 +00:00
Luke Howard
f5e67edb79 Fix dangling mutex in SLAPI bind preop handler 2005-07-22 06:16:03 +00:00
Luke Howard
8c52d0e401 Ensure backend is set before calling send_ldap_extended();
whoami was crashing for anonymous clients
2005-07-22 05:49:55 +00:00
Luke Howard
0b631c0d2f fix error in previous commit 2005-07-22 05:38:32 +00:00
Luke Howard
44bb946436 More use of SLAPI accessor macros 2005-07-22 05:33:47 +00:00
Luke Howard
de10624dc3 Use accessor macros for SLAPI parameter blocks, should make it
easier to move into overlay private data
2005-07-22 05:26:15 +00:00
Luke Howard
c477ad064f Set SLAPI_REQUESTOR_ISROOT for internal operations 2005-07-22 05:14:42 +00:00
Luke Howard
6da978d5a0 Support for global ACL overlays, corresponding SLAPI support 2005-07-22 05:01:09 +00:00
Luke Howard
6ae5ce5b66 Cleaner version of previous patch (keep operational attr code in backend.c) 2005-07-22 03:44:04 +00:00
Luke Howard
27adb43cbf Move backend_operational() implementation into frontend so global
overlays can be called
2005-07-22 03:40:06 +00:00
Luke Howard
a253fbdab4 terminate function array in slapi_int_get_plugins() 2005-07-22 03:24:09 +00:00
Pierangelo Masarati
4be9f57b29 more on leaks & small fixes to unparsing 2005-07-22 03:23:58 +00:00
Pierangelo Masarati
6adfb5dd2f note an issue 2005-07-22 03:23:26 +00:00
Luke Howard
acae40faa0 SLAPI plugins are no longer global; global SLAPI plugins should be
associated with the frontend
2005-07-22 03:17:36 +00:00
Luke Howard
ed80d1011f add over_acl_group/over_acl_attribute 2005-07-22 03:05:41 +00:00
Luke Howard
24f0ee316e function rename 2005-07-22 02:51:55 +00:00
Pierangelo Masarati
1ac6bf4d1d fix back-ldap unparsing 2005-07-22 02:29:49 +00:00
Pierangelo Masarati
5128702536 don't crash if no underlying database was initialized 2005-07-22 02:08:41 +00:00
Howard Chu
38968623d1 Fix prev commit 2005-07-22 01:53:19 +00:00
Pierangelo Masarati
4e6fd1a44f the swap was intended; please see ITS#3876 2005-07-22 01:00:21 +00:00
Howard Chu
ddf6c7b298 Plug more memleaks 2005-07-21 23:26:40 +00:00
Howard Chu
a70c294359 Plug memleak in enum_tree 2005-07-21 21:59:35 +00:00
Howard Chu
769c6232a2 Add config_back_db_close, free some structures 2005-07-21 21:27:37 +00:00
Pierangelo Masarati
49619058ee really fix the invalid free issue (I totally overlooked this piece of code) 2005-07-21 20:23:47 +00:00
Pierangelo Masarati
4ceeea4efa should fix the invalid free issue 2005-07-21 19:14:09 +00:00
Luke Howard
746bb6033a cleanup 2005-07-21 19:02:56 +00:00
Luke Howard
4f851f3ddb Fix typo 2005-07-21 18:58:49 +00:00
Pierangelo Masarati
1efe2e80f4 attempt to fix invalid free 2005-07-21 18:17:58 +00:00
Luke Howard
e2853c98f8 more cleanups 2005-07-21 18:17:57 +00:00
Luke Howard
f9633806da more cleanups 2005-07-21 18:16:32 +00:00
Luke Howard
001754eb65 remove SLAPI cruft 2005-07-21 18:07:16 +00:00
Luke Howard
ee770389d1 Fix some SLAPI bugs 2005-07-21 17:34:16 +00:00
Luke Howard
b8f86c4f28 Add support for post-result SLAPI plugins
Use overlay_op_walk again - needed to match 2.2 SLAPI behaviour
2005-07-21 17:15:44 +00:00
Luke Howard
ffe20229dc Move most of SLAPI frontend into overlay 2005-07-21 16:35:20 +00:00
Pierangelo Masarati
3df0f16292 cleanup 2005-07-21 14:27:31 +00:00
Pierangelo Masarati
ab4bb3e617 glue's enum conflicts with slap_operation_t 2005-07-21 14:23:49 +00:00
Pierangelo Masarati
b358bd82ad condition SLAP_OVERLAY_ACCESS 2005-07-21 14:23:15 +00:00
Pierangelo Masarati
ca8a734b92 make sure we notice if this gets out of sync with slap_operation_e 2005-07-21 14:13:57 +00:00
Luke Howard
857543c1f8 add prototype for overlay_op_walk() 2005-07-21 13:35:59 +00:00
Luke Howard
772b95e588 Add overlay_op_walk() 2005-07-21 13:35:32 +00:00
Luke Howard
13a8d5046f Add slap_operation_t 2005-07-21 13:35:19 +00:00
Pierangelo Masarati
fe2492309a improve messages 2005-07-21 08:54:04 +00:00
Luke Howard
0bf8a366a5 SLAPI cleanups 2005-07-21 08:39:37 +00:00
Luke Howard
7129f9ef91 Factor out common code in SLAPI internal ops
Allow internal operation pblock to forward connection/operation parameters
2005-07-21 08:34:25 +00:00
Luke Howard
8d600eca08 Enable SLAPI pre-entry plugins (we really need to move SLAPI into an
overlay...)
2005-07-21 04:01:54 +00:00
Pierangelo Masarati
1b11741a30 mostly revert previous commit 2005-07-20 19:26:46 +00:00
Pierangelo Masarati
c789d494c4 allow to unregister (and free) memory handling functions 2005-07-20 19:07:04 +00:00
Pierangelo Masarati
3df83d7089 destroy cache on exit 2005-07-20 14:59:56 +00:00
Pierangelo Masarati
628da7be89 fix uninitialized value use 2005-07-20 14:19:52 +00:00
Pierangelo Masarati
6f3363f0d9 Under some circumstances, port 9010 is already in use and may cause problems to referrals whose server is supposed to be unavailable 2005-07-20 11:17:06 +00:00
Pierangelo Masarati
e6ecb77b0e drop stored procedures 2005-07-20 11:16:09 +00:00
Luke Howard
d6d202693d Fix order of statements in SLAPI internal modrdn implementation 2005-07-20 08:19:22 +00:00
Luke Howard
f12103f36b Fix regression in SLAPI ACL plugins owing to accidental commit
Support ACL_WADD/ACL_WDEL in SLAPI ACL evaluation/plugins
2005-07-20 08:00:24 +00:00
Luke Howard
25ae11ccd9 Unset intop callback parameters before they go out of scope 2005-07-20 04:24:02 +00:00
Pierangelo Masarati
77ad940c10 more on deadlock/dangling pointers 2005-07-20 00:50:35 +00:00
Pierangelo Masarati
5748d3ff72 connection_client leave c_peer_* fields NULL 2005-07-20 00:49:33 +00:00
Pierangelo Masarati
a27a32ccc4 fix arbitrary precision number display when no big number library is available 2005-07-19 21:56:15 +00:00
Pierangelo Masarati
499906f464 use appropriate format when no arbitrary precision library is available 2005-07-19 19:31:24 +00:00
Pierangelo Masarati
c4aedadc56 improve previous commit 2005-07-19 19:13:50 +00:00
Pierangelo Masarati
b838f3e2a1 Solaris doesn't like being passed NULL pointers to [vsf[n]]printf 2005-07-19 18:59:50 +00:00
Pierangelo Masarati
ac590d6b55 fix previous commit 2005-07-19 18:03:06 +00:00
Luke Howard
7bd627d491 Reenable pre-result plugins, these were supported in OpenLDAP 2.2
Pre-entry and pre-referral plugins will be enabled after testing
2005-07-19 15:39:25 +00:00
Luke Howard
04e499e28c back out previous commit, fat fingers 2005-07-19 15:36:24 +00:00
Luke Howard
2d7a2144dc result.c 2005-07-19 15:35:00 +00:00
Pierangelo Masarati
551dab0d03 more cleanup 2005-07-19 15:13:32 +00:00
Pierangelo Masarati
0f18805d65 Memory cleanup 2005-07-19 14:39:43 +00:00
Pierangelo Masarati
be1a5057a9 ObjectClass cleanup 2005-07-19 14:39:19 +00:00
Pierangelo Masarati
16934eb8ef cleanup 2005-07-19 14:38:55 +00:00
Pierangelo Masarati
707082fcb7 AttributeType cleanup 2005-07-19 14:38:34 +00:00
Pierangelo Masarati
c5c0c3e4f5 fix previous commit (ITS#3871) 2005-07-19 14:25:10 +00:00
Pierangelo Masarati
882f43bf01 more about rewrite leaks 2005-07-19 14:24:26 +00:00
Pierangelo Masarati
efe74fbae0 fix yet another leak 2005-07-19 11:16:24 +00:00
Luke Howard
c8ef1e1861 Always set sml_desc when converting from LDAPMods 2005-07-19 09:37:36 +00:00
Luke Howard
0acd5d97bd Check op->o_bd != NULL 2005-07-19 08:40:26 +00:00
Luke Howard
4832af0a50 Fix callback API for cast safety
Copy controls returned by backend to pblock before they go out of scope
2005-07-19 08:39:56 +00:00
Luke Howard
6f5dde0734 Fix pointer error in readback control 2005-07-19 08:39:05 +00:00
Luke Howard
2007c4b8b9 Add slap_parse_ctrl() API for parsing already decoded controls; needed
for SLAPI internal operations to use controls
2005-07-19 08:38:46 +00:00
Luke Howard
5eda803bc1 Add slapi_x_filter_set_attribute_type() API 2005-07-19 06:55:56 +00:00
Luke Howard
9e9c4b5397 Implement more of SLAPI 5.x - all SLAPI internal operations now take pblocks
as the canonical argument (wrappers for old APIs are provided)
2005-07-19 06:48:45 +00:00
Luke Howard
07ffdd8893 Associate global plugins with frontendDB
When unparsing plugin configuration, don't crash if no arguments
(dynamically registered plugins such as computed attributes don't
have arg vectors)
2005-07-19 06:47:43 +00:00
Luke Howard
ed424c55ee Support for pre-entry, pre-result, pre-referral SLAPI plugins (not
enabled yet; behind #ifdef notdef)
2005-07-19 06:46:53 +00:00
Luke Howard
7de0268c98 Global plugins are now associated with frontendDB 2005-07-19 06:46:14 +00:00
Luke Howard
979e64d0f0 The order of uidNumber and gidNumber was swapped in revision 1.331,
which breaks existing ACLs. This patch restores the old behaviour.
2005-07-19 06:45:57 +00:00
Hallvard Furuseth
9d5308163c assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL). 2005-07-19 05:03:12 +00:00
Howard Chu
c8bffb5584 Fix bdb_tool_dn2id_get() - nobody should be calling bdb_dn2id() directly,
always call through the cache instead - bdb_cache_find_ndn().
2005-07-19 02:12:34 +00:00
Luke Howard
c09550766b Fix another crasher if parent is NULL 2005-07-19 01:37:48 +00:00
Luke Howard
da758bb150 Fix crasher in hdb_dn2id() when parent is NULL 2005-07-19 01:32:29 +00:00
Pierangelo Masarati
54a0c02c3d implement per-target, per-operation timeouts 2005-07-19 00:43:38 +00:00
Pierangelo Masarati
1100973301 trim unused (wrong) code 2005-07-19 00:30:34 +00:00
Pierangelo Masarati
51346cfa68 fix ITS#3862 2005-07-18 21:32:31 +00:00
Luke Howard
ee2c377d08 Fix for previous commit 2005-07-18 14:11:55 +00:00
Luke Howard
cfbb52459b Fix pointer error 2005-07-18 14:09:47 +00:00
Hallvard Furuseth
965c270cbb Fix format arg to "overlay...configuration failed" message 2005-07-18 08:30:33 +00:00
Hallvard Furuseth
df0e227201 Remove spurious snprintf(..., "<%s> cannot be deleted") lacking a format arg 2005-07-18 08:28:25 +00:00
Hallvard Furuseth
2b70a083e6 Delete unused variable. 2005-07-18 06:30:47 +00:00
Hallvard Furuseth
03c85cc68d send_ldap_controls() returns int, so fix return LBER_ERROR to -1. 2005-07-18 06:28:28 +00:00
Hallvard Furuseth
81ecb0b153 assert expects int. (int)<nonnull ptr/long> can be 0. Use assert(arg!=0/NULL). 2005-07-18 06:22:33 +00:00
Hallvard Furuseth
c2b65937fe Fix cast in BDB_ID2DISK(): unsigned char *_p ... = (char *)...; 2005-07-18 05:58:43 +00:00
Hallvard Furuseth
ae3ef7b3cd Make ConfigArgs.lineno int like elsewhere instead of unsigned long 2005-07-18 05:48:21 +00:00
Hallvard Furuseth
8adef9eec8 Delete unused variables 2005-07-18 05:34:04 +00:00