Commit Graph

384 Commits

Author SHA1 Message Date
Quanah Gibson-Mount
f6ad222e41 Happy New Year! 2020-01-09 16:50:21 +00:00
Ondřej Kuzník
97a310b312 ITS#8731 Apply doc/devel/variadic_debug/04-variadic.cocci 2019-02-15 16:51:53 +00:00
Ondřej Kuzník
254d2adab0 ITS#8731 Rework logging 2019-02-15 16:51:53 +00:00
Quanah Gibson-Mount
b45a6a7dc7 Happy New Year! 2019-01-14 18:46:16 +00:00
Quanah Gibson-Mount
59e9ff6243 Happy New Year 2018-03-22 15:35:24 +00:00
Howard Chu
a0cc1d9655 ITS#8054 add queue time to log
Show time spent in conn+threadpool queues before an op actually executes.
Also clean up timestamp handling
2017-03-16 14:21:31 +00:00
Quanah Gibson-Mount
1df85d3427 Happy New Year! 2017-01-03 12:36:47 -08:00
Quanah Gibson-Mount
6c4d6c880b Happy New Year! 2016-01-29 13:32:05 -06:00
Howard Chu
2d5996ac60 ITS#8054 Cleanup duration patch
Don't need op->o_hr_time, just use o_tincr, that's what it
was intended for anyway. Use "etime=" like other products do.
Simplify ifdefs. Use gettimeofday, it's always available now.
2015-10-31 11:57:06 +00:00
Emily Backes
5324d283d9 ITS#8054 operation duration logging 2015-10-31 11:55:23 +00:00
Quanah Gibson-Mount
1705fa7e55 Happy New Year 2015-02-11 15:36:57 -06:00
Howard Chu
be792fae2c Add sc_writewait callback
Invoked before a blocked writer waits for socket to be writable.
Use in back-mdb to release reader txn while waiting.
2014-07-22 19:17:15 -07:00
Kurt Zeilenga
5c878c1bf2 Happy new year (belated) 2014-01-25 05:21:25 -08:00
Hallvard Furuseth
7bb8b706c5 ITS#6758 Add SLAP_OP() &co, contrib:wrap_slap_ops.
Add framework for debug macros SLAP_OP(), slap_be_op(),
slap_bi_op() around LDAP-operation backend calls.

contrib/slapd-tools/wrap_slap_ops converts code to use them.

Code compiles as before by default.  #define USE_RS_ASSERT
enables debugging, $NO_RS_ASSERT tweaks it. See slapd/result.c.
2013-12-11 14:40:45 +01:00
Howard Chu
88d22a1ca3 Simplify write waiter handling
Writer threads do their own wait using select/poll instead of
asking the listener thread. Eliminates one mutex+one condvar
per conn plus multiple wakeups of the listener thread. Also
fixes writetimeout to wait an exact time, instead of the
approximation used in the listener thread.
2013-09-07 14:53:02 -07:00
Howard Chu
f096ed1125 ITS#6164 avoid conn->c_mutex in send_ldap_ber
This may possibly trigger ITS#5835 again. Revert if so.
2013-01-09 01:57:48 -08:00
Kurt Zeilenga
0fd1bf30b8 Happy New Year 2013-01-02 10:22:57 -08:00
Howard Chu
a766cdf268 Revert "ITS#7292 plug memleak in control values"
This reverts commit 9e3af2356b.
2012-06-08 04:11:29 -07:00
Howard Chu
9e3af2356b ITS#7292 plug memleak in control values 2012-06-07 13:18:31 -07:00
Howard Chu
16c97dee9c ITS#7076 fix dup result messages on entry/searchref error 2012-06-07 05:43:13 -07:00
Kurt Zeilenga
2bbf9804b9 Happy New Year! 2012-01-01 07:10:53 -08:00
Howard Chu
68ee165fb5 ITS#7115 blocked writers should not interfere with pool pause 2011-12-21 01:24:23 -08:00
Howard Chu
a4df185adf ITS#7019 fix dsa-specific attr check for Persist updates 2011-11-07 15:25:07 -08:00
Howard Chu
49c6ddf99c Revert "ITS#6981 don't free entries prematurely"
This reverts commit 877ebdf5ef.
2011-11-02 09:25:45 -07:00
Howard Chu
877ebdf5ef ITS#6981 don't free entries prematurely 2011-11-01 16:24:10 -07:00
Howard Chu
f502695c81 Revert "ITS#6981 don't flush entries until after cleanup callbacks"
This reverts commit b68fa5ecd7.
2011-11-01 16:14:12 -07:00
Howard Chu
b68fa5ecd7 ITS#6981 don't flush entries until after cleanup callbacks 2011-11-01 13:17:06 -07:00
Howard Chu
d69ca65afd ITS#7060 fix str2result return code parsing 2011-11-01 12:59:36 -07:00
Howard Chu
9cb0386851 ITS#7062 call response callbacks even if connection was dropped 2011-11-01 11:02:00 -07:00
Hallvard Furuseth
074fe6c298 ITS#6763,7053 Cleanup after sending entry/searchref.
slap_send_search_entry(), slap_send_search_reference(): Never skip
the cleanup code.  Sending an entry did on sizeLimitExceeded/busy.
Sending a ref dropped rs_flush_entry() on error.
2011-10-24 01:06:42 +02:00
Pierangelo Masarati
d8f97f58e2 ITS#6899
tag read entry response control value with [APPLICATION 4] (SearchResultEntry)
2011-06-08 22:19:09 +02:00
Hallvard Furuseth
42cb7f06f1 cleanup: Rename rs_ensure_entry_modifiable().
The name rs_entry2modifiable() is more reasonably sized.
For now, leave behind a macro rs_ensure_entry_modifiable in proto-slap.h.
2011-01-28 16:33:55 +00:00
Hallvard Furuseth
a67100a7c1 ITS#6758 whitespace fix for rev 1.350 2011-01-21 12:09:47 +00:00
Hallvard Furuseth
ecc19f03a0 ITS#6758 Remove comment; broken rs.sr_type idea 2011-01-21 11:43:20 +00:00
Hallvard Furuseth
fb6aa52870 Support $NO_RS_ASSERT. Add comments.
Use a private rs_assert_() helper function instead of libc assert.
2011-01-21 11:41:45 +00:00
Kurt Zeilenga
966cef8c9a Happy New Year 2011-01-05 00:42:37 +00:00
Hallvard Furuseth
bdb078a778 ITS#6758 Reset dangerous REP_ENTRY_* flags.
If SlapReply.sr_un cannot contain an entry but does or soon may
contain another member than sru_search: Ensure nothing will see
leftover REP_ENTRY_* flags and try to clean up the "entry" there.
2010-12-31 20:53:17 +00:00
Hallvard Furuseth
9467059b0b ITS#6758 fix/add slap_send_search_entry() comments 2010-12-31 19:57:53 +00:00
Hallvard Furuseth
a4c2d54127 ITS#6758 result.c:Use rs_*(). Frees entries earlier.
For readability, use rs_flush_entry() where slap_send_search_entry() and
slap_send_search_reference() release entries before network operations.

This change also frees entires marked MUSTBEFREED earlier.
2010-12-31 18:14:31 +00:00
Hallvard Furuseth
f4a3304477 ITS#6758 Use rs_*() to manage SlapReply entries.
Some noop changes + fixes entry leaks and REP_ENTRY_MODIFIABLE flag leaks.
2010-12-31 17:55:36 +00:00
Hallvard Furuseth
cb15a4c687 ITS#6758 rs_reinit() += slap_reply_t parameter 2010-12-31 09:45:16 +00:00
Hallvard Furuseth
5c3f806fca ITS#6758 Add rs_reinit(), rs_flush_entry() 2010-12-30 23:32:07 +00:00
Hallvard Furuseth
ea2b675dca ITS#6758 Add rs_assert*, RS_ASSERT, USE_RS_ASSERT 2010-12-30 23:29:46 +00:00
Hallvard Furuseth
c9e85af35c ITS#6759: assert;Debug -> Debug;assert 2010-12-30 23:19:02 +00:00
Pierangelo Masarati
938778ffd9 free controls, if needed (ITS#6629) 2010-08-29 17:23:08 +00:00
Kurt Zeilenga
3dadeb3efe happy belated New Year 2010-04-13 22:17:29 +00:00
Hallvard Furuseth
1a7b18bcca ITS#5340: REP_ENTRY_MUSTFLUSH, rs_replace_entry(), rs_ensure_entry_modifiable() 2009-12-10 00:07:34 +00:00
Howard Chu
2fd6d4749a Cleanup pointless compare in debug msgs 2009-11-21 21:34:33 +00:00
Howard Chu
dc86747a4d Fix typo in 1.250 fake sorted results control 2009-07-13 02:42:38 +00:00
Hallvard Furuseth
5b98495d5c ITS#6101, reset rs->sr_rspdata in send_ldap_disconnect() 2009-07-07 22:30:28 +00:00